Patch Detail
Show a patch.
GET /api/patches/19529/?format=api
{ "id": 19529, "url": "https://patchwork.libcamera.org/api/patches/19529/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19529/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240223155954.4139705-2-kieran.bingham@ideasonboard.com>", "date": "2024-02-23T15:59:52", "name": "[1/3] ipa: libipa: Allow retrieving the name of a CameraSensorHelperFactory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8e82416f2adebac18d9bf21fd432ff56fa641a24", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19529/mbox/", "series": [ { "id": 4177, "url": "https://patchwork.libcamera.org/api/series/4177/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4177", "date": "2024-02-23T15:59:51", "name": "libipa: Fix CameraSensorHelper gain helpers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4177/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19529/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19529/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08A70C3263\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Feb 2024 16:00:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A73D662809;\n\tFri, 23 Feb 2024 17:00:00 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92F0F627FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Feb 2024 16:59:58 +0100 (CET)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43C00D52;\n\tFri, 23 Feb 2024 16:59:49 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vwEALkPr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708703989;\n\tbh=Q+1zVWXDyXRmHJN4cxUi7LV29DDCPHUqyyn7SxehJAQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vwEALkPrlG7xB6rK49ybKlRrldHEvVM/5mwJMGcfeAuqG8aZ+ItvLVUAXVIZvFs7/\n\tPs2pUeJGg0HhS1LpeA8iOYgIrgWf8JIVGPnMtQUfxgefwBW042nK+9dnB1LXuh5mcJ\n\t/zHVSCgPkctPjUGQiqClx56WKcJZoYdzz1sxONwg=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Subject": "[PATCH 1/3] ipa: libipa: Allow retrieving the name of a\n\tCameraSensorHelperFactory", "Date": "Fri, 23 Feb 2024 15:59:52 +0000", "Message-Id": "<20240223155954.4139705-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240223155954.4139705-1-kieran.bingham@ideasonboard.com>", "References": "<20240223155954.4139705-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Support the test suite iterating the factories by exposing a const\nretriever of the factory name.\n\n---\nAn alternative here is to just allow direct access to the\ncreateInstance() from the test too, without having to re-search\nall of the factories each time. But I felt this was less\nof a de-restriction of the existing interfaces.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.h | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\nindex 3ea1806cb1fd..dcdbe82b7ac9 100644\n--- a/src/ipa/libipa/camera_sensor_helper.h\n+++ b/src/ipa/libipa/camera_sensor_helper.h\n@@ -68,6 +68,8 @@ public:\n \n \tstatic std::vector<CameraSensorHelperFactoryBase *> &factories();\n \n+\tconst std::string &name() const { return name_; };\n+\n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)\n \n", "prefixes": [ "1/3" ] }