Patch Detail
Show a patch.
GET /api/patches/19508/?format=api
{ "id": 19508, "url": "https://patchwork.libcamera.org/api/patches/19508/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19508/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240218164908.15921-4-laurent.pinchart@ideasonboard.com>", "date": "2024-02-18T16:49:06", "name": "[v3,3/5] ipa: rkisp1: Fix histogram weights configuration", "commit_ref": "a5e6b7f0dbf74b77991aa149c6d659872dade87c", "pull_url": null, "state": "accepted", "archived": false, "hash": "ba4a3c0a1a808bab25e03704a7899b628912f6f8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19508/mbox/", "series": [ { "id": 4171, "url": "https://patchwork.libcamera.org/api/series/4171/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4171", "date": "2024-02-18T16:49:03", "name": "ipa: rkisp1: Support the i.MX8MP ISP", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4171/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19508/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19508/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 866FCC3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 18 Feb 2024 16:49:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 522F562802;\n\tSun, 18 Feb 2024 17:49:12 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96D9A62806\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Feb 2024 17:49:10 +0100 (CET)", "from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D0312298;\n\tSun, 18 Feb 2024 17:49:04 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P5LCI3GM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708274944;\n\tbh=l5G8RaEuhsqyRYO0i7tXbSaP9wpcsJG9l9IPc0lQSPM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=P5LCI3GM0a/h6B1ofbg1pzy8wxaamYGqhIYY+RqXr5mf2NgSeGrq/RoeOew+M4Q2E\n\tGU3bpNFiej+87Mb/f8+t81K2uYaxlHVI265glPyO6gXEhbaaHPu9GUDZWpjFH+d4iA\n\tL8Q9hxdTx54SjDj7P0KPrSb27tvR4WFm87NnhoDM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v3 3/5] ipa: rkisp1: Fix histogram weights configuration", "Date": "Sun, 18 Feb 2024 18:49:06 +0200", "Message-ID": "<20240218164908.15921-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240218164908.15921-1-laurent.pinchart@ideasonboard.com>", "References": "<20240218164908.15921-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The histogram weights are initialized to hardcoded 1's for each\nhistogram grid cell. The code uses the wrong variable for the grid size,\nresulting in some weights having a 0 value. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex da705b14754c..47a6f7b26744 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -175,7 +175,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n \t/* Set an average weighted histogram. */\n \tSpan<uint8_t> weights{\n \t\tparams->meas.hst_config.hist_weight,\n-\t\tcontext.hw->numHistogramBins\n+\t\tcontext.hw->numHistogramWeights\n \t};\n \tstd::fill(weights.begin(), weights.end(), 1);\n \t/* Step size can't be less than 3. */\n", "prefixes": [ "v3", "3/5" ] }