Patch Detail
Show a patch.
GET /api/patches/19464/?format=api
{ "id": 19464, "url": "https://patchwork.libcamera.org/api/patches/19464/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19464/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240123143535.52255-3-kieran.bingham@ideasonboard.com>", "date": "2024-01-23T14:35:33", "name": "[v2,2/4] libcamera: formats: Fix sort ordering of R10_CSI2P", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eba7634b45efb076a81cc1f7d438bfdd8c3309d5", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19464/mbox/", "series": [ { "id": 4159, "url": "https://patchwork.libcamera.org/api/series/4159/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4159", "date": "2024-01-23T14:35:31", "name": "Mono format fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4159/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19464/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19464/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D586DC32BC\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Jan 2024 14:35:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77CC262950;\n\tTue, 23 Jan 2024 15:35:43 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2E9262944\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jan 2024 15:35:40 +0100 (CET)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E729B1BB1;\n\tTue, 23 Jan 2024 15:34:26 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KCLV4qw9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1706020467;\n\tbh=mesbsB+AloSGClq3XdJdl/JtYcGp5eAUO/GCK4W87wE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KCLV4qw9sh3Zld9WHsNuGwiAbvy7UlxDuWJdt9By1HuxQrBaGMyPpLCPV/5HXNpGr\n\tiOjJNupXMRiK/C+qbK38VZFieJ4f7Q6VNE3Q1eQ13ZbCB/lSxfqsf+8nqIS+63XkuZ\n\tYZ1bBbeQB/4dC2mgp2taVr82ljvddF94CQX7dnvM=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Subject": "[PATCH v2 2/4] libcamera: formats: Fix sort ordering of R10_CSI2P", "Date": "Tue, 23 Jan 2024 14:35:33 +0000", "Message-Id": "<20240123143535.52255-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240123143535.52255-1-kieran.bingham@ideasonboard.com>", "References": "<20240123143535.52255-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move formats::R10_CSI2P to be grouped with the formats::R10 counterpart\nand keep the section of format declarations sorted in increasing bit\ndepth.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nv2: new patch\n\n src/libcamera/formats.cpp | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 46ccd43ba63a..8a606a7c37f1 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -497,6 +497,16 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::R10_CSI2P, {\n+\t\t.name = \"R10_CSI2P\",\n+\t\t.format = formats::R10_CSI2P,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_Y10P), },\n+\t\t.bitsPerPixel = 10,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 4,\n+\t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::R12, {\n \t\t.name = \"R12\",\n \t\t.format = formats::R12,\n@@ -517,16 +527,6 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n-\t{ formats::R10_CSI2P, {\n-\t\t.name = \"R10_CSI2P\",\n-\t\t.format = formats::R10_CSI2P,\n-\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_Y10P), },\n-\t\t.bitsPerPixel = 10,\n-\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n-\t\t.packed = true,\n-\t\t.pixelsPerGroup = 4,\n-\t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n-\t} },\n \n \t/* Bayer formats. */\n \t{ formats::SBGGR8, {\n", "prefixes": [ "v2", "2/4" ] }