Patch Detail
Show a patch.
GET /api/patches/19463/?format=api
{ "id": 19463, "url": "https://patchwork.libcamera.org/api/patches/19463/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19463/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240123143535.52255-2-kieran.bingham@ideasonboard.com>", "date": "2024-01-23T14:35:32", "name": "[v2,1/4] libcamera: formats: Add 16-bit mono format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b670beed5ab79a4209a199d9976539bbecd4a860", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19463/mbox/", "series": [ { "id": 4159, "url": "https://patchwork.libcamera.org/api/series/4159/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4159", "date": "2024-01-23T14:35:31", "name": "Mono format fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4159/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19463/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19463/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B35E9C324D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Jan 2024 14:35:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 057776294C;\n\tTue, 23 Jan 2024 15:35:42 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6AA556291F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jan 2024 15:35:40 +0100 (CET)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A20351B9A;\n\tTue, 23 Jan 2024 15:34:26 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kwv2IEC3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1706020466;\n\tbh=BmzCCcLuyva/zjuOSrfNltcKTq4ZcVfM0DnReBl+HUQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kwv2IEC3ElXN3Tk04Zup1UetwXgHTeuI1Zr+8G1vPk7Zj/ZlWKq92jp9Ak2Qe4srK\n\t1me2jsZr/jg+mRrVpdZwtYiTlV7qoF/cMxNd+/R1AHGZe1e5KR0IBcgY4I7ETN7ts5\n\tSh9eUvSNZul1jQByaAMRCbJFoxOl1DEpNmFFW3so=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Subject": "[PATCH v2 1/4] libcamera: formats: Add 16-bit mono format", "Date": "Tue, 23 Jan 2024 14:35:32 +0000", "Message-Id": "<20240123143535.52255-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240123143535.52255-1-kieran.bingham@ideasonboard.com>", "References": "<20240123143535.52255-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Naushir Patuck <naush@raspberrypi.com>\n\nAdd the relevant definitions for a 16-bit mono pixel and media-bus\nformat.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n--\nv2:\n - Fix ordering\n - Remove blank line\n - also update mbusCodeToBayer\n\n src/libcamera/bayer_format.cpp | 3 +++\n src/libcamera/formats.cpp | 10 ++++++++++\n src/libcamera/formats.yaml | 2 ++\n src/libcamera/v4l2_pixelformat.cpp | 2 ++\n src/libcamera/v4l2_subdevice.cpp | 1 +\n 5 files changed, 18 insertions(+)", "diff": "diff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\nindex 3bf15fb48f36..175617a0edf5 100644\n--- a/src/libcamera/bayer_format.cpp\n+++ b/src/libcamera/bayer_format.cpp\n@@ -170,6 +170,8 @@ const std::map<BayerFormat, Formats, BayerFormatComparator> bayerToFormat{\n \t\t{ formats::R10, V4L2PixelFormat(V4L2_PIX_FMT_Y10) } },\n \t{ { BayerFormat::MONO, 10, BayerFormat::Packing::CSI2 },\n \t\t{ formats::R10_CSI2P, V4L2PixelFormat(V4L2_PIX_FMT_Y10P) } },\n+\t{ { BayerFormat::MONO, 16, BayerFormat::Packing::None },\n+\t\t{ formats::R16, V4L2PixelFormat(V4L2_PIX_FMT_Y16) } },\n };\n \n const std::unordered_map<unsigned int, BayerFormat> mbusCodeToBayer{\n@@ -208,6 +210,7 @@ const std::unordered_map<unsigned int, BayerFormat> mbusCodeToBayer{\n \t{ MEDIA_BUS_FMT_Y8_1X8, { BayerFormat::MONO, 8, BayerFormat::Packing::None } },\n \t{ MEDIA_BUS_FMT_Y10_1X10, { BayerFormat::MONO, 10, BayerFormat::Packing::None } },\n \t{ MEDIA_BUS_FMT_Y12_1X12, { BayerFormat::MONO, 12, BayerFormat::Packing::None } },\n+\t{ MEDIA_BUS_FMT_Y16_1X16, { BayerFormat::MONO, 16, BayerFormat::Packing::None } },\n };\n \n } /* namespace */\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 447e623803c7..46ccd43ba63a 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -507,6 +507,16 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::R16, {\n+\t\t.name = \"R16\",\n+\t\t.format = formats::R16,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_Y16), },\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::R10_CSI2P, {\n \t\t.name = \"R10_CSI2P\",\n \t\t.format = formats::R10_CSI2P,\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex 539ac0b33084..d8a379923b56 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -11,6 +11,8 @@ formats:\n fourcc: DRM_FORMAT_R10\n - R12:\n fourcc: DRM_FORMAT_R12\n+ - R16:\n+ fourcc: DRM_FORMAT_R16\n \n - RGB565:\n fourcc: DRM_FORMAT_RGB565\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 5551c62eb39b..731dc10f1d73 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -135,6 +135,8 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{\n \t\t{ formats::R10_CSI2P, \"10-bit Greyscale Packed\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_Y12),\n \t\t{ formats::R12, \"12-bit Greyscale\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_Y16),\n+\t\t{ formats::R16, \"16-bit Greyscale\" } },\n \n \t/* Bayer formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR8),\ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 75ad11e55272..265240dbd405 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -88,6 +88,7 @@ const std::map<uint32_t, V4L2SubdeviceFormatInfo> formatInfoMap = {\n \t{ MEDIA_BUS_FMT_YUYV10_2X10, { 20, \"YUYV10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_YVYU10_2X10, { 20, \"YVYU10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_Y12_1X12, { 12, \"Y12_1X12\", PixelFormatInfo::ColourEncodingYUV } },\n+\t{ MEDIA_BUS_FMT_Y16_1X16, { 16, \"Y16_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_UYVY8_1X16, { 16, \"UYVY8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_VYUY8_1X16, { 16, \"VYUY8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_YUYV8_1X16, { 16, \"YUYV8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n", "prefixes": [ "v2", "1/4" ] }