Patch Detail
Show a patch.
GET /api/patches/19446/?format=api
{ "id": 19446, "url": "https://patchwork.libcamera.org/api/patches/19446/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19446/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240122133332.64190-1-mail@eliasnaur.com>", "date": "2024-01-22T13:33:10", "name": "[v2] pipeline: rpi: always initialize the embedded buffer in tryRunPipeline", "commit_ref": "0dc737d3e31112973c9286eb7775b8f730352a75", "pull_url": null, "state": "accepted", "archived": false, "hash": "91aa9df38d5c3a1983d9fcda667426076f056028", "submitter": { "id": 159, "url": "https://patchwork.libcamera.org/api/people/159/?format=api", "name": "Elias Naur", "email": "mail@eliasnaur.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19446/mbox/", "series": [ { "id": 4155, "url": "https://patchwork.libcamera.org/api/series/4155/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4155", "date": "2024-01-22T13:33:10", "name": "[v2] pipeline: rpi: always initialize the embedded buffer in tryRunPipeline", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4155/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19446/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19446/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD5B8BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 22 Jan 2024 13:33:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECA8D6291F;\n\tMon, 22 Jan 2024 14:33:44 +0100 (CET)", "from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com\n\t[IPv6:2607:f8b0:4864:20::e34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1040961D30\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Jan 2024 14:33:43 +0100 (CET)", "by mail-vs1-xe34.google.com with SMTP id\n\tada2fe7eead31-466f6d4b6d3so660373137.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Jan 2024 05:33:42 -0800 (PST)", "from localhost.localdomain ([189.174.206.139])\n\tby smtp.gmail.com with ESMTPSA id\n\te27-20020a0561020f9b00b004698691d31bsm1177306vsv.30.2024.01.22.05.33.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Jan 2024 05:33:40 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=eliasnaur.com header.i=@eliasnaur.com\n\theader.b=\"4Xnu3kIW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=eliasnaur.com; s=google; t=1705930421; x=1706535221;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=R8SLgnbeiiqr8ZOq4nAIiXN9U6HpgoAHIsfxrYGfAaE=;\n\tb=4Xnu3kIWrZP50Lo+3zDkSnrR+UIGu8A+s0IsH93KzJREDUnm5gYp9hvDfJ74YwPQim\n\tS1RdYYfjYsqGIReAFpZzd53z5ry3NBEEnn0oScTBKUgYUJ1zpyzvZnxshrEGSLqZSEMA\n\tUZ93X8b8cO1mGvDD2pZ5rdhmtjV5EKj04RuXrkUnfV+ZekNIOfUhyvQS8cH1RhNtx3WR\n\t0HWwgyGSzXanr0SZHFvHYd8hAzqnVKeI3byu+nYSnEhITqgPSsGf1RulAPso5jbUXmWa\n\tTz+p4Y55YsriMbi6i7mhpgoEwbHf70g6YeDBYPJ65Qs+f3QUIqN0VVYolaVFUkaWR6hS\n\txfPg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705930421; x=1706535221;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=R8SLgnbeiiqr8ZOq4nAIiXN9U6HpgoAHIsfxrYGfAaE=;\n\tb=CV7rHOd+Cw3vaXsdDjZC4xBLFFtSHiJsTA6/B1GpP0cf7PW24FZ8EiG8RpjdL8FAd/\n\tsp3ffjs+0UoIsCdBAg5lxlyz20PaGEYBRp+SYzgTi5nowFXuzZfz6qjFn07uPW14PFzj\n\tUAjWDZ++Br6TGVB/2pvJHuMbQWv1EFMzJiBPPzmj+X6APCfoDTFM3vaBaiyhJZx19251\n\twATOocwOqVIzdV4/kXJy0t8uNp/+YtDR7SB8ynsIo5qnpwrjvTrfAe2DYtc/tdyzbz0V\n\tO7RJW2xcXLx/d5DCLE6wREf7gHU1BbnLhAAVXyVGxCFy9UfxL9DGNDWNO6mTpBPAFops\n\tFvZA==", "X-Gm-Message-State": "AOJu0Yw2Vw0WCv30D4rVRNRiCnexUeY9KWBBhKhaXVK+2oGZvqCJUDA9\n\t83+NIMp2r18Nrds9tSUPQRzySLAc+OfA3WDcB5YBaMIXUq1hH4tFYiDixiI6U34NX4ItfdWabBE\n\tPlA==", "X-Google-Smtp-Source": "AGHT+IF+NUQ+AygmSstH3It4J9aL9dA4P+dVQQGHXGRnaDVrvL5gHvCv6UwucLvAKKUBSOXEdAKM1w==", "X-Received": "by 2002:a67:efd7:0:b0:46a:601e:ff57 with SMTP id\n\ts23-20020a67efd7000000b0046a601eff57mr194509vsp.5.1705930421563; \n\tMon, 22 Jan 2024 05:33:41 -0800 (PST)", "From": "Elias Naur <mail@eliasnaur.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2] pipeline: rpi: always initialize the embedded buffer in\n\ttryRunPipeline", "Date": "Mon, 22 Jan 2024 08:33:10 -0500", "Message-ID": "<20240122133332.64190-1-mail@eliasnaur.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Elias Naur <mail@eliasnaur.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Vc4CameraData::findMatchBuffers may return successfully with a null\nembedded buffer, in which case the embedded buffer id would be left\nuninitialized.\n\nWithout this change, libcamera v0.2.0 usually crashes for me with an\nassertion error:\n\n ipa_base.cpp:397 assertion \"it != buffers_.end()\" failed in prepareIsp()\n\nSigned-off-by: Elias Naur <mail@eliasnaur.com>\n---\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\nindex 26102ea7..a52f0e7a 100644\n--- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n+++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n@@ -945,6 +945,7 @@ void Vc4CameraData::tryRunPipeline()\n \tparams.requestControls = request->controls();\n \tparams.ipaContext = request->sequence();\n \tparams.delayContext = bayerFrame.delayContext;\n+\tparams.buffers.embedded = 0;\n \n \tif (embeddedBuffer) {\n \t\tunsigned int embeddedId = unicam_[Unicam::Embedded].getBufferId(embeddedBuffer);\n", "prefixes": [ "v2" ] }