Patch Detail
Show a patch.
GET /api/patches/19327/?format=api
{ "id": 19327, "url": "https://patchwork.libcamera.org/api/patches/19327/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19327/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<ZXt0yJ2dqUIn6Ari@duo.ucw.cz>", "date": "2023-12-14T21:34:00", "name": "[libcamera-devel] Avoid segfault with bad configuration", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b1ebbfb9f2045edab3d227e8c82fda9efdd351b7", "submitter": { "id": 49, "url": "https://patchwork.libcamera.org/api/people/49/?format=api", "name": "Pavel Machek", "email": "pavel@ucw.cz" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19327/mbox/", "series": [ { "id": 4118, "url": "https://patchwork.libcamera.org/api/series/4118/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4118", "date": "2023-12-14T21:34:00", "name": "[libcamera-devel] Avoid segfault with bad configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4118/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19327/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19327/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D94ADBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 14 Dec 2023 21:34:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2878F62B32;\n\tThu, 14 Dec 2023 22:34:03 +0100 (CET)", "from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C55461D97\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Dec 2023 22:34:01 +0100 (CET)", "by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid E91821C006F; Thu, 14 Dec 2023 22:34:00 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702589643;\n\tbh=OjKqM7d+w8BUlKiqUae1KcSRjAKjT/heD7L8ljW5qp8=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=CArs7vTuU7Ude2SHIvidfIUDq5thyajm61nABGVRCa5IPDjjEnhegrVMo5J9OJq4O\n\tt9uSsX35IhB/qR56BNlZ1ZtySqdnTAMurfc6ij4FmZKO9SpShaIZSe8XEgHlHMaXr4\n\tQKJ/7gbU/PV8z71fK8n4bxtqbsZt1V6v8+ceN92AUzd8IyJTuwbFNu/jxOP/V1OTQs\n\tYcwcL6EqW4zZc1dqWcFWYz2bxmMpDry9c8BhiDF4elh00C7/Xfk54ffBK2k1sjvvD3\n\tRvlYECGleD9e9en+pPXqqB3OHlAp4c819OahMP2JMlJ4nFPBD9qZkq46+Zpw3sTRDU\n\tkObpRvaa1zsJw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1702589640;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type;\n\tbh=zkTCoVpie48sjXcrbhUD3V/orSYISXxGQXjhiQNciBs=;\n\tb=Ea9Kw7U6owQC9KSqHXWRuHW5FkSN+wqoWkJbPoSUOMp4W82q1UN2bZS8K7tbceReUPlx5u\n\tw8U9hKXQK/hYWLnSDOpiWohGveW8O7fNvpWf0IB5/jviJEFrlWM5M6YHxeSCZ6LD7lOoym\n\t7iUUAxvj43IfLMkN8qhf6dFS1b1N+AE=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"Ea9Kw7U6\"; dkim-atps=neutral", "Date": "Thu, 14 Dec 2023 22:34:00 +0100", "To": "libcamera-devel@lists.libcamera.org", "Message-ID": "<ZXt0yJ2dqUIn6Ari@duo.ucw.cz>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"vpfclkIdZqZZUoV+\"", "Content-Disposition": "inline", "Subject": "[libcamera-devel] [PATCH] Avoid segfault with bad configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Pavel Machek <pavel@ucw.cz>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Without this patch, I get segfault instead of \"Failed to get default\nstream configuration\" message.\n \nSigned-off-by: Pavel Machek <pavel@ucw.cz>", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex bdc7bfe5..8a315bfd 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1138,6 +1138,8 @@ SimplePipelineHandler::generateConfiguration(Camera *camera, Span<const StreamRo\n \t */\n \tfor ([[maybe_unused]] StreamRole role : roles) {\n \t\tStreamConfiguration cfg{ StreamFormats{ formats } };\n+\t\tif (!formats.begin()->first)\n+\t\t\tcontinue;\n \t\tcfg.pixelFormat = formats.begin()->first;\n \t\tcfg.size = formats.begin()->second[0].max;\n \n", "prefixes": [ "libcamera-devel" ] }