Patch Detail
Show a patch.
GET /api/patches/19303/?format=api
{ "id": 19303, "url": "https://patchwork.libcamera.org/api/patches/19303/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19303/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231211105638.1787362-1-paul.elder@ideasonboard.com>", "date": "2023-12-11T10:56:38", "name": "[libcamera-devel] utils: ipc: Fix deserialization of multiple fd parameters", "commit_ref": "1d0d2cf67cb7100cfc7a368347271f88365b0a52", "pull_url": null, "state": "accepted", "archived": false, "hash": "65b2af75f823fe70451d7ac87717b761f5c0c092", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19303/mbox/", "series": [ { "id": 4112, "url": "https://patchwork.libcamera.org/api/series/4112/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4112", "date": "2023-12-11T10:56:38", "name": "[libcamera-devel] utils: ipc: Fix deserialization of multiple fd parameters", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4112/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19303/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19303/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD0F3BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 11 Dec 2023 10:56:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE90962B32;\n\tMon, 11 Dec 2023 11:56:55 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C767629DF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 Dec 2023 11:56:53 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83AC9922;\n\tMon, 11 Dec 2023 11:56:07 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702292216;\n\tbh=WBo/sNhd+lvgqzO2S5e5PKoSHjIlO1rJf09oStXQDfI=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=VFLfCZRGDvnKTp0Wprh/JCZILsJZpJrF3UafpMuhSmHuO/isdIW1nqF572b5v+8oq\n\tQAMxT+v9ua+GL/H5R03SRYhFK3ljlUlWTyhaD8sGq8A7LYlXMfQIRh6CM/nWbNhxk2\n\tdpMlNYm8qD0SN2BXAqXngRcP0km97lWmBy8yMC4/r9jTCBHHSdXgaBXzPayukXPvNG\n\tc0J+mUsKDsswKsL5JrLnjakB/7R/uCXLA48BX/2Z6vcCjcZbSD2vpayuV8u6NQ7WIV\n\t4DdzI8vGMvLGW9xXBUG5kwygNLerjHx4Q/BnYrbzzcTFTaKLKa51AbQwjC+l4MG6Wy\n\tMbbmNp50dCnVw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1702292169;\n\tbh=WBo/sNhd+lvgqzO2S5e5PKoSHjIlO1rJf09oStXQDfI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=QE+d6SKEEI9T+/VddYeUXeqfq/hGmhrBgtTQ3Ej03kf4MpRR0S3wDJ6fkDr267HOx\n\ttbYAcT0poRzJnzX9sF7gVcFmFCfgFYLYUCw7L42n+YaIUoTM/a4U9T5prM9kABs64n\n\tD8NZh6OB0oiK6Z69W61VBafNlaFWJd00JjtF5Y/Q=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QE+d6SKE\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 11 Dec 2023 19:56:38 +0900", "Message-Id": "<20231211105638.1787362-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] utils: ipc: Fix deserialization of\n\tmultiple fd parameters", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There was a bug where the code generated for deserialization of function\nparameters would fail if there were multiple file descriptor parameters.\nFix this.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=205\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n utils/ipc/generators/libcamera_templates/proxy_functions.tmpl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\nindex 2be65d432..b5797b149 100644\n--- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n@@ -186,7 +186,7 @@ IPADataSerializer<{{param|name}}>::deserialize(\n {% for param in params|with_fds %}\n {%- if loop.first %}\n \tconst size_t {{param.mojom_name}}FdStart = 0;\n-{%- elif not loop.last %}\n+{%- else %}\n \tconst size_t {{param.mojom_name}}FdStart = {{loop.previtem.mojom_name}}FdStart + {{loop.previtem.mojom_name}}FdsSize;\n {%- endif %}\n {%- endfor %}\n", "prefixes": [ "libcamera-devel" ] }