Patch Detail
Show a patch.
GET /api/patches/19300/?format=api
{ "id": 19300, "url": "https://patchwork.libcamera.org/api/patches/19300/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19300/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231206210524.20974-7-laurent.pinchart@ideasonboard.com>", "date": "2023-12-06T21:05:24", "name": "[libcamera-devel,6/6] test: gstreamer: Remove videoconvert element from pipeline", "commit_ref": "17d8b89deb1feb35ceba2f1310f4eea35fcb1d73", "pull_url": null, "state": "accepted", "archived": false, "hash": "db2b0839883c89bb864af3026bba779d522e145a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19300/mbox/", "series": [ { "id": 4109, "url": "https://patchwork.libcamera.org/api/series/4109/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4109", "date": "2023-12-06T21:05:18", "name": "test: Miscellaneous fixes and improvements for unit tests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4109/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19300/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19300/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A22CBC32BE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Dec 2023 21:05:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3228F62B3E;\n\tWed, 6 Dec 2023 22:05:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 458AC62B32\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Dec 2023 22:05:26 +0100 (CET)", "from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E3FAE45\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Dec 2023 22:04:45 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701896728;\n\tbh=NZkiQNMfUta8JuleftDajQUrje2fpiQJko7TJilAfEI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vgHP6EpCW3/7ACRaYcNarSEAgHJCsb4zs4ukJP0UcK3DFb3w+/4LI/bx6JkmCQa+J\n\tJi1dUKCn/tkIHO/PxbCdBfSoVAnd6jHM+ybjwSFITaZGZerLhfg1xMSiDiWIvvwzRi\n\tVH/WP0rDjXT3UY9oYSKPZxNWA69HnFESszdVOb4dp6+oeCop7vJxmBlYgJKD/wBVbh\n\t1hS7surRYPradOdi5tACndB4QkjCLM4rQfFPiRwGPiLBH52+uwqGlTI6Sl9Fku1KLh\n\tdPgiXhR/6J5pmv1wcwmmnXhpNy07mekbeUJs/T+ggXPGy1cfaLY8Wst16EUp2zfikZ\n\th6rQ7LZqIj6hA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701896685;\n\tbh=NZkiQNMfUta8JuleftDajQUrje2fpiQJko7TJilAfEI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=hESmuzcTwMfsTZ9LjF5JVFO/dfLtuJMnPX1AlK6jDhsJvXawqxjHpptLBSUzoydRL\n\t4OoLYieeHDn0oGr2vRRFg77viujC4dpWn08fKvpQVyfiJohPHq8DHxxCxcN5avQnpq\n\thKkTlLTr1x9cp1W1vvLoLxcAbg57mE40e7AfG7dU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hESmuzcT\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Dec 2023 23:05:24 +0200", "Message-ID": "<20231206210524.20974-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.41.0", "In-Reply-To": "<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>", "References": "<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 6/6] test: gstreamer: Remove videoconvert\n\telement from pipeline", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The GStreamer single stream test uses the following pipeline:\n\n\tlibcamerasrc ! videoconvert ! fakesink\n\nThe videoconvert element isn't useful as the data is thrown away by the\nfakesink anyway. We can shorten the pipeline to\n\n\tlibcamerasrc ! fakesink\n\nto save CPU time and to avoid depending on the gstreamer1.0-plugins-base\npackage to run the unit tests.\n\nThe test could be further simplified by replacing\ngst_parse_bin_from_description_full() with gst_element_factory_make(),\nnow that we only add one element to the bin. The extra cost incurred by\nthe bin only impacts initialization time, and using a bin will make it\neasier to add other elements in the future if needed. Keep the bin, and\nonly drop the videoconvert element.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/gstreamer/gstreamer_single_stream_test.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp\nindex a0dd12cfea84..301e4a935a37 100644\n--- a/test/gstreamer/gstreamer_single_stream_test.cpp\n+++ b/test/gstreamer/gstreamer_single_stream_test.cpp\n@@ -29,7 +29,7 @@ protected:\n \t\tif (status_ != TestPass)\n \t\t\treturn status_;\n \n-\t\tconst gchar *streamDescription = \"videoconvert ! fakesink\";\n+\t\tconst gchar *streamDescription = \"fakesink\";\n \t\tg_autoptr(GError) error0 = NULL;\n \t\tstream0_ = gst_parse_bin_from_description_full(streamDescription, TRUE,\n \t\t\t\t\t\tNULL,\n", "prefixes": [ "libcamera-devel", "6/6" ] }