Patch Detail
Show a patch.
GET /api/patches/19264/?format=api
{ "id": 19264, "url": "https://patchwork.libcamera.org/api/patches/19264/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19264/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231204001013.404720-3-andrey.konovalov@linaro.org>", "date": "2023-12-04T00:10:08", "name": "[libcamera-devel,RFC,2/7] libcamera: internal: Move SharedMemObject class to a common directory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b0d827579a1b32a3fe8b546d266405adc49904ef", "submitter": { "id": 25, "url": "https://patchwork.libcamera.org/api/people/25/?format=api", "name": "Andrey Konovalov", "email": "andrey.konovalov@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19264/mbox/", "series": [ { "id": 4096, "url": "https://patchwork.libcamera.org/api/series/4096/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4096", "date": "2023-12-04T00:10:06", "name": "libcamera: introduce Software ISP and Software IPA", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4096/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19264/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19264/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 083BDC322E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 4 Dec 2023 00:10:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85BDD629D3;\n\tMon, 4 Dec 2023 01:10:44 +0100 (CET)", "from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5F04629D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 4 Dec 2023 01:10:42 +0100 (CET)", "by mail-wr1-x429.google.com with SMTP id\n\tffacd0b85a97d-3316bb1303bso3028563f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 03 Dec 2023 16:10:42 -0800 (PST)", "from Lat-5310.. ([87.116.165.212]) by smtp.gmail.com with ESMTPSA\n\tid\n\tu29-20020adfa19d000000b003332db7d91dsm8835997wru.39.2023.12.03.16.10.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 03 Dec 2023 16:10:42 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701648644;\n\tbh=oRBIY8kOi0gKYV5IPe6DVH6UPAc8qzG43Lgmf4uwB34=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=FHW8UY1Oh+Rn6pOWH323GllOFHCQeI8qllNbkPaEO/stgH8uA/H/ecPTsE2lm8X8l\n\t8QF7bOj2O0zWnEGCsqE5DBP+HY3UmshL+tfksWj018troxXnBdFhnzS9Qg3iqPZIv+\n\tfiADG+CRNbG7y+hm07LMStKVTGLYmqjRPKFR73aSH0wQvDXrHNuvNg4GnPrbrpNznr\n\tlnmmhBFdvXRveONNH8LNQycakRTyjRRUWZJPxQ5xkpmcicx9A+QdiUCofT9yOdM56C\n\t+ClLj8fap9IKzXa87PduS8aa1+ZO14GLSiR3b3bz5VwxwplFdbFwacYti0+DU4ZL92\n\tt8hjjLr3xGHQA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1701648642; x=1702253442;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=pFJAoSA9Nwu/bV7xUFK2GgTlAP4DOK35M5GoMj00EiU=;\n\tb=L6n+ZiknGX4m7jbMUJpO2aY0E4WMl9208MpAP3w+GZrJ9LVudbrZiMWtdM3VYvWzSQ\n\t3+aMXMRhIPMQ5kGEKS6RRzQ9teUSScU1v29lh6i9F5+sRAXYb9aW1EHwdWUisasK968w\n\tB2gBNvMJgueRVIKo0shRCNW77HJBwfk1FdDYEUjSttIv+XSVdUO8sU80lssX6N3Y9wC0\n\tFAkdrICB+iOqHG5Imw6CgK3STCDaDGn5WHIC/+wxLEMA9YmdsmloSGwd++QV7WOUtqxQ\n\tGnlDWTkm3K6gU3OuG3TwnDd/NKOLuxsqynAFZ++f5HqrXfkzpgqZxo3QJPuVq3bqhQvz\n\t02Lg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=linaro.org\n\theader.i=@linaro.org header.b=\"L6n+Zikn\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701648642; x=1702253442;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=pFJAoSA9Nwu/bV7xUFK2GgTlAP4DOK35M5GoMj00EiU=;\n\tb=bfHujq5Rxha3t/J3hDPsudVpWhGhLtJYacohWlhP6gY5Dfs/FIvA4kVGoPBRLVKfAN\n\ta6HNbBjaa9Re2HYaycOLAVcTmdiRWkqsIK/eUc5+M+5plKr3mHIlOratJ35G+YB9sebq\n\tI2tRUG27QkUgjFvo77UTvDBHgbOO82szJZ/5EgUj6M4ieE0aQNs+NYlN/j+6fwSp0ZQe\n\tPEPCCtUgLqlJWUfX3z/GwmZRBwCjMWhBONy4Lq7G1HdBXS4xki2eQiVbozFrF5Ph1rMs\n\t8lcTAejF8l2ztTCcptFkejsT6RqxsWQU5jub97ANArA4W7xr3iRS5VrPBOTKhveAQbuo\n\tOvow==", "X-Gm-Message-State": "AOJu0YwjkMOyQzIy3iJoyReY/4AxOsNjLqouGYp1w6tjZJDdNgk1A9/z\n\tb00EALBUQeWfqKRY7txNAVCHR4rzSm1nHACKG5w=", "X-Google-Smtp-Source": "AGHT+IEFHvqqtebCZhYG5PVXfhYrdKwdoDUW62eNL+1EvUJHrWqNK2j2whHdzDwDd7HNrxSbauvjgQ==", "X-Received": "by 2002:a5d:63cb:0:b0:333:13cf:dd15 with SMTP id\n\tc11-20020a5d63cb000000b0033313cfdd15mr2868893wrw.55.1701648642646; \n\tSun, 03 Dec 2023 16:10:42 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 4 Dec 2023 03:10:08 +0300", "Message-Id": "<20231204001013.404720-3-andrey.konovalov@linaro.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231204001013.404720-1-andrey.konovalov@linaro.org>", "References": "<20231204001013.404720-1-andrey.konovalov@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 2/7] libcamera: internal: Move\n\tSharedMemObject class to a common directory", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Andrey Konovalov via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Andrey Konovalov <andrey.konovalov@linaro.org>", "Cc": "mripard@redhat.com, g.martti@gmail.com, t.langendam@gmail.com,\n\tsrinivas.kandagatla@linaro.org, bryan.odonoghue@linaro.org,\n\tadmin@dennisbonke.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move SharedMemObject class out of RPi namespace and put it into\ninclude/libcamera/internal so that everyone could use it.\n\nSigned-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>\n---\n include/libcamera/internal/meson.build | 1 +\n .../common => include/libcamera/internal}/shared_mem_object.h | 4 ----\n 2 files changed, 1 insertion(+), 4 deletions(-)\n rename {src/libcamera/pipeline/rpi/common => include/libcamera/internal}/shared_mem_object.h (98%)", "diff": "diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex 0f725cfd..b780777c 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -38,6 +38,7 @@ libcamera_internal_headers = files([\n 'process.h',\n 'pub_key.h',\n 'request.h',\n+ 'shared_mem_object.h',\n 'software_isp.h',\n 'source_paths.h',\n 'sysfs.h',\ndiff --git a/src/libcamera/pipeline/rpi/common/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nsimilarity index 98%\nrename from src/libcamera/pipeline/rpi/common/shared_mem_object.h\nrename to include/libcamera/internal/shared_mem_object.h\nindex aa56c220..bfb639ee 100644\n--- a/src/libcamera/pipeline/rpi/common/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -19,8 +19,6 @@\n \n namespace libcamera {\n \n-namespace RPi {\n-\n template<class T>\n class SharedMemObject\n {\n@@ -123,6 +121,4 @@ private:\n \tT *obj_;\n };\n \n-} /* namespace RPi */\n-\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "RFC", "2/7" ] }