Patch Detail
Show a patch.
GET /api/patches/19180/?format=api
{ "id": 19180, "url": "https://patchwork.libcamera.org/api/patches/19180/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19180/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231024080143.16414-1-naush@raspberrypi.com>", "date": "2023-10-24T08:01:43", "name": "[libcamera-devel] pipeline: rpi: Remove unused variable", "commit_ref": "226a1dacb1a3d38200e29ee9a03d09980c3ab928", "pull_url": null, "state": "accepted", "archived": false, "hash": "e1a17dfc6280bb0030d7ef9027c34de0e147a1e2", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19180/mbox/", "series": [ { "id": 4058, "url": "https://patchwork.libcamera.org/api/series/4058/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4058", "date": "2023-10-24T08:01:43", "name": "[libcamera-devel] pipeline: rpi: Remove unused variable", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4058/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19180/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19180/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 155C0BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 Oct 2023 08:01:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DFFC6297F;\n\tTue, 24 Oct 2023 10:01:43 +0200 (CEST)", "from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04D3C61DCC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Oct 2023 10:01:40 +0200 (CEST)", "by mail-wm1-x331.google.com with SMTP id\n\t5b1f17b1804b1-40806e4106dso23820705e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Oct 2023 01:01:40 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tfc11-20020a05600c524b00b004064cd71aa8sm11463559wmb.34.2023.10.24.01.01.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 24 Oct 2023 01:01:39 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698134503;\n\tbh=LutvE5O77kZ53zBrEtHnfD9idTWbCL0oCHdF7kZoNyQ=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=JdSN59wvrr4P/+dco9WyaxZi65VCe3aZPR8xGHiIGB5XqxIxzox5XRd1dvhI0iZE1\n\tY7GYy3tu4HavGyKL5cyeKCTw8u0yis0shkEYQqdBXv7klCvr3CuHazG1F67yBgVeKf\n\tWuNHoYdFHJX3nUdLx1kIevd4Y3VLGOlaEr8VfJNHxp4zYU+4w+XP7e0dEXEH4MepW0\n\t0qFrQ6UOxVYJ+BJJbJbZO4hsNOp8/ecIOldy7fFfmkN0IeIB8Iix7bKpPTzQSvW1Xs\n\taCDIPnRykByL3bExP3P5OEBf4Dq1M2MtUcIIhavXe/ftozOytK0KzkVJ6AGRLsXB4E\n\t++/dERDQPND8Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1698134500; x=1698739300;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=vvZMQp5pGKEMDCeYbiTLgpJ77eD92iY+ss8JBauT+98=;\n\tb=KzQBA7lrxxBQRxoyQ9S026AZbz6GleVp3C80bnEal5GdVL5mx5I0+wZiFr+WsEsSYW\n\t3ZOusVKd2E6mxuTwAFLs/Zm9cpaQoJDNrMhd0CqhbQlkLENyGqccUD1iNdFYN83cAoLW\n\tvvwe2/xJ77BE68/C5LioDSrFtUS7dj3dk7h4jqbyM0a0sf173cYi4Tn5YvurHOzjQt2k\n\ttbGuo7BNkLjm1WwShko/D4OFx1LpIpLO30jCdDPdB/HePDXf7/La6n9o1rVmhX3S/UDM\n\tNeSX3rgpaYW7OBGuRL0HuZQhjJNGS3BOHPEVMa1QEVKg+jO+3/20uf+wA2x0fsXBZStd\n\tVs9A==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"KzQBA7lr\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1698134500; x=1698739300;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=vvZMQp5pGKEMDCeYbiTLgpJ77eD92iY+ss8JBauT+98=;\n\tb=DY8AcJdbBZnJVcT4c8l3aUZl4fbMZXgdb08VUdlVB0QoWZGHqPDdkzu5ULGSeh7w7l\n\tx3y+kBKvZ3314xbpzxNhipl8zLt/kVarryWV+qk3gz0aqe8QixRhzKYLSJKG5ggH8Q8o\n\t2xabwkbIbI1eAhSaBw9Lk0lvCZiq0qRxDApnweAxH8yLggk7L8Vz/qmaNr3kK8ZMiPek\n\ta+AA+n53pCj6jXIjHNK3SbcQ69fgfo93BIaCuowTYJBB0FJGYYeZBWxnu2xyZVhgz5OZ\n\tKlP4DldhzRnb3K9G9dOh3V2brc1xDULXwWUEU90qq14CAFq9Buw30dDPWBtllptMybx3\n\t0GlA==", "X-Gm-Message-State": "AOJu0YyqUWmKGQXkbOTtTjVgSk4cQPzTs/BJ4J7yELrM8bOXBBRKryHr\n\t2cJ8sQ6eUxqqSu3gubhGoIUu0ODyVQ8X4HuONe6ztw==", "X-Google-Smtp-Source": "AGHT+IGnZRbag5uQGOkOinfKYIbBPU9k5O/RTjKvw8HcDjAnT89mV4zQlh7D8dZ+LlxmjZwNDIUZ8A==", "X-Received": "by 2002:a05:600c:b4d:b0:408:33ba:569a with SMTP id\n\tk13-20020a05600c0b4d00b0040833ba569amr14979042wmr.8.1698134500118; \n\tTue, 24 Oct 2023 01:01:40 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 24 Oct 2023 09:01:43 +0100", "Message-Id": "<20231024080143.16414-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] pipeline: rpi: Remove unused variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The entityControls variable is unused, remove it.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 7c88b87e0608..e683bd5bb612 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -1214,7 +1214,6 @@ int CameraData::loadIPA(ipa::RPi::InitResult *result)\n \n int CameraData::configureIPA(const CameraConfiguration *config, ipa::RPi::ConfigResult *result)\n {\n-\tstd::map<unsigned int, ControlInfoMap> entityControls;\n \tipa::RPi::ConfigParams params;\n \tint ret;\n \n", "prefixes": [ "libcamera-devel" ] }