Patch Detail
Show a patch.
GET /api/patches/1918/?format=api
{ "id": 1918, "url": "https://patchwork.libcamera.org/api/patches/1918/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1918/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190904125427.13943-4-jacopo@jmondi.org>", "date": "2019-09-04T12:54:23", "name": "[libcamera-devel,v4,3/7] android: camera_device: Remove tags from request template", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "57965b5cd056535d38e23d66d326d32af7978472", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1918/mbox/", "series": [ { "id": 479, "url": "https://patchwork.libcamera.org/api/series/479/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=479", "date": "2019-09-04T12:54:20", "name": "android: Rework metadata tags", "version": 3, "mbox": "https://patchwork.libcamera.org/series/479/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1918/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1918/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FBA761927\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Sep 2019 14:53:06 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id DF16224000C;\n\tWed, 4 Sep 2019 12:53:04 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo@jmondi.org>, kamesan@google.com, jcliang@google.com,\n\tshik@google.com, wtlee@google.com", "Date": "Wed, 4 Sep 2019 14:54:23 +0200", "Message-Id": "<20190904125427.13943-4-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20190904125427.13943-1-jacopo@jmondi.org>", "References": "<20190904125427.13943-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 3/7] android: camera_device: Remove\n\ttags from request template", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 04 Sep 2019 12:53:06 -0000" }, "content": "Remove metadata tags wrongly added to the request template constructed\nby the libcamera HAL.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 97 -----------------------------------\n 1 file changed, 97 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex dee60e3d2931..bd69198ec482 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -557,39 +557,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \t\treturn nullptr;\n \t}\n \n-\t/* Set to 0 the number of 'processed and stalling' streams (ie JPEG). */\n-\tint32_t maxOutStream[] = { 0, 2, 0 };\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n-\t\t\tmaxOutStream, 3);\n-\tMETADATA_ASSERT(ret);\n-\n-\tuint8_t maxPipelineDepth = 5;\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n-\t\t\t&maxPipelineDepth, 1);\n-\tMETADATA_ASSERT(ret);\n-\n-\tint32_t inputStreams = 0;\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n-\t\t\t&inputStreams, 1);\n-\tMETADATA_ASSERT(ret);\n-\n-\tint32_t partialResultCount = 1;\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n-\t\t\t&partialResultCount, 1);\n-\tMETADATA_ASSERT(ret);\n-\n-\tuint8_t availableCapabilities[] = {\n-\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n-\t};\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n-\t\t\tavailableCapabilities, 1);\n-\tMETADATA_ASSERT(ret);\n-\n \tuint8_t aeMode = ANDROID_CONTROL_AE_MODE_ON;\n \tret = add_camera_metadata_entry(requestTemplate_,\n \t\t\tANDROID_CONTROL_AE_MODE,\n@@ -632,12 +599,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \t\t\t&awbLock, 1);\n \tMETADATA_ASSERT(ret);\n \n-\tuint8_t awbLockAvailable = ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE;\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n-\t\t\t&awbLockAvailable, 1);\n-\tMETADATA_ASSERT(ret);\n-\n \tuint8_t flashMode = ANDROID_FLASH_MODE_OFF;\n \tret = add_camera_metadata_entry(requestTemplate_,\n \t\t\tANDROID_FLASH_MODE,\n@@ -655,64 +616,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \t\t\t&captureIntent, 1);\n \tMETADATA_ASSERT(ret);\n \n-\t/*\n-\t * This is quite hard to list at the moment wihtout knowing what\n-\t * we could control.\n-\t *\n-\t * For now, just list in the available Request keys and in the available\n-\t * result keys the control and reporting of the AE algorithm.\n-\t */\n-\tstd::vector<int32_t> availableRequestKeys = {\n-\t\tANDROID_CONTROL_AE_MODE,\n-\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n-\t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n-\t\tANDROID_CONTROL_AE_LOCK,\n-\t\tANDROID_CONTROL_AF_TRIGGER,\n-\t\tANDROID_CONTROL_AWB_MODE,\n-\t\tANDROID_CONTROL_AWB_LOCK,\n-\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n-\t\tANDROID_CONTROL_CAPTURE_INTENT,\n-\t\tANDROID_FLASH_MODE,\n-\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n-\t};\n-\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_REQUEST_AVAILABLE_REQUEST_KEYS,\n-\t\t\tavailableRequestKeys.data(),\n-\t\t\tavailableRequestKeys.size());\n-\tMETADATA_ASSERT(ret);\n-\n-\tstd::vector<int32_t> availableResultKeys = {\n-\t\tANDROID_CONTROL_AE_MODE,\n-\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n-\t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n-\t\tANDROID_CONTROL_AE_LOCK,\n-\t\tANDROID_CONTROL_AF_TRIGGER,\n-\t\tANDROID_CONTROL_AWB_MODE,\n-\t\tANDROID_CONTROL_AWB_LOCK,\n-\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n-\t\tANDROID_CONTROL_CAPTURE_INTENT,\n-\t\tANDROID_FLASH_MODE,\n-\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n-\t};\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_REQUEST_AVAILABLE_RESULT_KEYS,\n-\t\t\tavailableResultKeys.data(),\n-\t\t\tavailableResultKeys.size());\n-\tMETADATA_ASSERT(ret);\n-\n-\t/*\n-\t * \\todo The available characteristics are be the tags reported\n-\t * as part of the static metadata reported at hal_get_camera_info()\n-\t * time. As of now, report an empty list.\n-\t */\n-\tstd::vector<int32_t> availableCharacteristicsKeys = {};\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n-\t\t\tavailableCharacteristicsKeys.data(),\n-\t\t\tavailableCharacteristicsKeys.size());\n-\tMETADATA_ASSERT(ret);\n-\n \treturn requestTemplate_;\n }\n \n", "prefixes": [ "libcamera-devel", "v4", "3/7" ] }