Patch Detail
Show a patch.
GET /api/patches/19159/?format=api
{ "id": 19159, "url": "https://patchwork.libcamera.org/api/patches/19159/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19159/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231019140133.32090-12-jacopo.mondi@ideasonboard.com>", "date": "2023-10-19T14:01:32", "name": "[libcamera-devel,v6,11/12] apps: cam: Add option to set stream orientation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f4d7a3db247a2dd61f8d934c657e6ea84c125b73", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19159/mbox/", "series": [ { "id": 4053, "url": "https://patchwork.libcamera.org/api/series/4053/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4053", "date": "2023-10-19T14:01:21", "name": "libcamera: Replace CameraConfiguration::transform", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4053/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19159/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19159/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 774DBC32BA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Oct 2023 14:02:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 437C062992;\n\tThu, 19 Oct 2023 16:02:02 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4430B62992\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Oct 2023 16:01:54 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 308F61211;\n\tThu, 19 Oct 2023 16:01:46 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697724122;\n\tbh=Bc1cx3+5KkrNkgSxu51mTmO/e8HEdedyOAAJ9VgfzTM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=E240sUaNA6zWt3ek2KSDUdCux7VZXyBrwS7wbVheX/pcb0jbUagDsYLAPaXZ2lN1P\n\tpgxE2uh+h2ILJUsZN+n04bcsRkb7nYOqjOY5uF2Ih0n6vDAYAW5EUESdg7sNBmpaVP\n\tvpInLIT66+IEkxNSN6UDA/GZZb9BbIMHZRJhN4qoMvzXWM6IOV8h95X1pKTXGd/uVY\n\tfsBAoCmBKpDMgcHWV8zuKutAcuZ7nazQmvQkUAk4hgO/zwt2AWz/QBj7VZ6q4eJ9wE\n\tMkAluzWmM3ekpCidsDEygtT411hs5VBh3hIJUOtNVrHViAwHCOyuAQBqa+lQJuObKT\n\t4HxrHQuiRlNFg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697724106;\n\tbh=Bc1cx3+5KkrNkgSxu51mTmO/e8HEdedyOAAJ9VgfzTM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rxqeuSLPgygtplafKhMKBlSQYqqp5M1DF2rs1zbFDF9S89OtdInXzT/Sup48Q3jn1\n\tg727eOHamhndky6V5ff02b/GPkvPGNJC17KR9yq2iuXhjBnhPk2FQvipUQQpZpXyTW\n\tGvPadV2rjl9j0rI4HZiby5vhhTFKlG/11A4YKunc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rxqeuSLP\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 19 Oct 2023 16:01:32 +0200", "Message-ID": "<20231019140133.32090-12-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "References": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 11/12] apps: cam: Add option to set\n\tstream orientation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a '--orientation|-o' option to the cam test application to set\nan orientation to the image stream.\n\nSupported values are the ones obtained by applying flips to the camera\nsensor:\n- rot0: no rotation\n- rot180: rotate 180 degrees\n- flip: vertical flip\n- mirror: horizontal flip\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/apps/cam/camera_session.cpp | 18 ++++++++++++++++++\n src/apps/cam/main.cpp | 5 +++++\n src/apps/cam/main.h | 1 +\n 3 files changed, 24 insertions(+)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 066e397b5f47..8447f932dfc7 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -65,6 +65,24 @@ CameraSession::CameraSession(CameraManager *cm,\n \t\treturn;\n \t}\n \n+\tif (options_.isSet(OptOrientation)) {\n+\t\tstd::string orientOpt = options_[OptOrientation].toString();\n+\t\tstatic const std::map<std::string, libcamera::Orientation> orientations{\n+\t\t\t{ \"rot0\", libcamera::Orientation::Rotate0 },\n+\t\t\t{ \"rot180\", libcamera::Orientation::Rotate180 },\n+\t\t\t{ \"mirror\", libcamera::Orientation::Rotate0Mirror },\n+\t\t\t{ \"flip\", libcamera::Orientation::Rotate180Mirror },\n+\t\t};\n+\n+\t\tauto orientation = orientations.find(orientOpt);\n+\t\tif (orientation == orientations.end()) {\n+\t\t\tstd::cerr << \"Invalid orientation \" << orientOpt << std::endl;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tconfig->orientation = orientation->second;\n+\t}\n+\n \t/* Apply configuration if explicitly requested. */\n \tif (StreamKeyValueParser::updateConfiguration(config.get(),\n \t\t\t\t\t\t options_[OptStream])) {\ndiff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\nindex 5d8a57bc14e5..179cc3769b03 100644\n--- a/src/apps/cam/main.cpp\n+++ b/src/apps/cam/main.cpp\n@@ -133,6 +133,11 @@ int CamApp::parseOptions(int argc, char *argv[])\n \t\t\t \"Capture until interrupted by user or until <count> frames captured\",\n \t\t\t \"capture\", ArgumentOptional, \"count\", false,\n \t\t\t OptCamera);\n+\n+\tparser.addOption(OptOrientation, OptionString,\n+\t\t\t \"Desired image orientation (rot0, rot180, mirror, flip)\",\n+\t\t\t \"orientation\", ArgumentRequired, \"orientation\", false,\n+\t\t\t OptCamera);\n #ifdef HAVE_KMS\n \tparser.addOption(OptDisplay, OptionString,\n \t\t\t \"Display viewfinder through DRM/KMS on specified connector\",\ndiff --git a/src/apps/cam/main.h b/src/apps/cam/main.h\nindex 526aecece3f3..4aa959b32e13 100644\n--- a/src/apps/cam/main.h\n+++ b/src/apps/cam/main.h\n@@ -17,6 +17,7 @@ enum {\n \tOptList = 'l',\n \tOptListProperties = 'p',\n \tOptMonitor = 'm',\n+\tOptOrientation = 'o',\n \tOptSDL = 'S',\n \tOptStream = 's',\n \tOptListControls = 256,\n", "prefixes": [ "libcamera-devel", "v6", "11/12" ] }