Patch Detail
Show a patch.
GET /api/patches/19130/?format=api
{ "id": 19130, "url": "https://patchwork.libcamera.org/api/patches/19130/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19130/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231013074841.16972-7-naush@raspberrypi.com>", "date": "2023-10-13T07:48:27", "name": "[libcamera-devel,v2,06/20] ipa: rpi: Add try_lock() to RPiController::Metadata", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7b058e8c633d2b5ed7e250bbbcda009f83603810", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19130/mbox/", "series": [ { "id": 4049, "url": "https://patchwork.libcamera.org/api/series/4049/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4049", "date": "2023-10-13T07:48:21", "name": "Raspberry Pi: Preliminary PiSP support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4049/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19130/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19130/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD28FC32BA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Oct 2023 07:48:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C0E462997;\n\tFri, 13 Oct 2023 09:48:56 +0200 (CEST)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD66562987\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Oct 2023 09:48:51 +0200 (CEST)", "by mail-wm1-x32f.google.com with SMTP id\n\t5b1f17b1804b1-4056ce55e7eso18579535e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Oct 2023 00:48:51 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm16-20020a7bca50000000b003fee6e170f9sm1791890wml.45.2023.10.13.00.48.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Oct 2023 00:48:50 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697183336;\n\tbh=vyNP6GL/NvQu1qtuus8Vql2nWEyyu0RXUAt+aNcr38w=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zcPKuR49wNU1f0IC5L6ztP7j7c+bPfTX20cD2OcfUaKY5eiuGuWDF7OHfpKwTx1MZ\n\tZIjrzRA1Sb3L93XT/CD4CEsl1VKjojAjGLUM8QdF3A4NvmNaro7Pr055m9xRdGuohT\n\tPitlsQM0WxooWVL0W0BQJmek1BhkDMi7/XLE34EVMwOZViGLCQIsQWdZSXrD2KxIYb\n\telXJpq6MxGg9GLZKqT+pM/BBloUbzb8hWAuN35VSITXjsuNQVVN6oP77ftn9AYYsAd\n\tlG21C0GD6SoOhM8lKY8+Tzc6wwqjsG+/I4DJ96u5bIbT+DdRNgPf7H09q3coTmSLjM\n\t/7uKQ7euPRSyQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1697183331; x=1697788131;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=kw7H4NyscZJrAD6u85gBoZ7kQ4HlC5GeOqW4krYVWeM=;\n\tb=i4I5Y/KwLeugpxDX/m5LGTt6hM6kE3SVingFLuG30ZaPpzleNiBR+gc+S5PrCA1nXz\n\tnc5RACbeoIqajGPCK93o9WV5iWRtFO1OkNQzFEktN3f6aWGP2YhqR03FQDCH8H/4eMRS\n\t28/x+tCs2R1llEa+W5XJwpI3r9p973vtWjIWy7vYydDDIvk8jrNbRP8LAMB87bUiA/jY\n\t1iW031TBSFub1vlfalBiyevym7/8cKO7iHiWz6e693tIdwhiOj3BEAQYcc9lGOHlVoHg\n\thBUq8iHtwKsyglgTjFazW32r5GPsxxLdgLDBqkeEU9cOMdPzc21MvTcushH7WmTLO1wf\n\tYgUA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"i4I5Y/Kw\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1697183331; x=1697788131;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=kw7H4NyscZJrAD6u85gBoZ7kQ4HlC5GeOqW4krYVWeM=;\n\tb=JWRrQvuoq4NsmYvXl2tfnCAhJkZvm+Py/s5eXR6MiBGwIBGW99GW3ZFkjZiL6UFxjB\n\tI0T0m3x4yXZ3nxLY85ok8aSOjBzvq3usdFbtr+7aQAfpMz9KPHVPTevcQFkWicl5vTnC\n\t8pWFbKr547AE8Q3RApwq/EKhfQMrgMCjscdhIoYwECW1gzmNZ0V1ZoQ5q8OK0Mxja2yg\n\tJMkfg0CdKQz0HV17NSeXoaVNSFoLxfxQsAoV78xqnvtCDEENbas++c6Ku8uXfmWcypU2\n\td3iLUXYnGwtu+xrVyAEGqwMSnSebzUBunGKoxjPU1iKKe59od5o5XFuKuFQGqKFeArkM\n\tS7Sw==", "X-Gm-Message-State": "AOJu0Yz6D4MIx95Az7rQXdF3YuVfzUSe8y6kChQULh6mQuZtXBYoQhyB\n\tFTABFRjQGJMrKuNKCIOd3rGLYaIuhlSpe/nDiKx6aA==", "X-Google-Smtp-Source": "AGHT+IGKuGXqdULmnz4qn8uHTL289Nu7moCWC3Q0RsU8NoCy3DhPDQxXZomfivId94qAFCEt/E0xOQ==", "X-Received": "by 2002:a7b:cbd4:0:b0:3fb:b3aa:1c8a with SMTP id\n\tn20-20020a7bcbd4000000b003fbb3aa1c8amr23615576wmi.16.1697183331056; \n\tFri, 13 Oct 2023 00:48:51 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 13 Oct 2023 08:48:27 +0100", "Message-Id": "<20231013074841.16972-7-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231013074841.16972-1-naush@raspberrypi.com>", "References": "<20231013074841.16972-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 06/20] ipa: rpi: Add try_lock() to\n\tRPiController::Metadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add the missing try_lock() member function to RPiController::Metadata.\nThis will allow RPiController::Metadata to be used as a template\nparameter in std::scoped_lock.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/rpi/controller/metadata.h | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/ipa/rpi/controller/metadata.h b/src/ipa/rpi/controller/metadata.h\nindex bf8a2393457a..a232dcb12456 100644\n--- a/src/ipa/rpi/controller/metadata.h\n+++ b/src/ipa/rpi/controller/metadata.h\n@@ -116,6 +116,7 @@ public:\n \t * e.g. std::lock_guard<RPiController::Metadata> lock(metadata)\n \t */\n \tvoid lock() LIBCAMERA_TSA_ACQUIRE() { mutex_.lock(); }\n+\tauto try_lock() LIBCAMERA_TSA_ACQUIRE() { return mutex_.try_lock(); }\n \tvoid unlock() LIBCAMERA_TSA_RELEASE() { mutex_.unlock(); }\n \n private:\n", "prefixes": [ "libcamera-devel", "v2", "06/20" ] }