Patch Detail
Show a patch.
GET /api/patches/19110/?format=api
{ "id": 19110, "url": "https://patchwork.libcamera.org/api/patches/19110/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19110/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231006132000.23504-9-naush@raspberrypi.com>", "date": "2023-10-06T13:19:48", "name": "[libcamera-devel,08/20] ipa: rpi: Add PiSP definitions to the Controller hardware description", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c8d83bababd090a70368fe420b13d3297c0d7e60", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19110/mbox/", "series": [ { "id": 4047, "url": "https://patchwork.libcamera.org/api/series/4047/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4047", "date": "2023-10-06T13:19:40", "name": "Raspberry Pi: Preliminary PiSP support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4047/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19110/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19110/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E093C3273\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Oct 2023 13:20:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20BD562964;\n\tFri, 6 Oct 2023 15:20:08 +0200 (CEST)", "from mail-wr1-x430.google.com (mail-wr1-x430.google.com\n\t[IPv6:2a00:1450:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04F0A62964\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Oct 2023 15:20:07 +0200 (CEST)", "by mail-wr1-x430.google.com with SMTP id\n\tffacd0b85a97d-3296b87aa13so396958f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 06 Oct 2023 06:20:07 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm8-20020a056000180800b00321773bb933sm1639478wrh.77.2023.10.06.06.20.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Oct 2023 06:20:04 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696598408;\n\tbh=j/SW7gNoxKpiRffDpQ3V6c90rH0Ejl1dJ8x3bHYT7p4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=puBGKZeAJpPAtCI7hPKHvzrQhZ0fLVzD9hIR93m6twcf+oX0gFY5iPTvYFiAh1jQF\n\txyDLUDqb7lTX7KbSKJeNWG9e8VxJ5KiyUCNyM2P/+mcMWJqlZ6Ztsf5Iw9yaf9CY1W\n\tKEJMokFxIHzlvIOeM2Tjoy9KjaPwQwXSslIQvC8sIVJVkbpbjAyoA+zYaudVsEgFfB\n\to7WafKss7hGhHfEP4tpRksFxSLEdvP+3jCjASBSZ4Ux3r2pI39zn+SyREwOHJcqbw1\n\tWrW8lIuVYiO/Km155zvf10a5HUrxFxw/xHHcsjiDUuOEYUhX68rQpv3XvhiSv+zJVv\n\tjGkGCvaUMKr4A==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1696598406; x=1697203206;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=AkNVdholsXPriKWLuKJtW86dK6QQTBncTOQiC4z4Br8=;\n\tb=C/isIsbdiy/hoOd2E/oDVr88GX6Y2nZe3gGj4UkmAp2pPw2khf/vgy9F8WTXPQl8R2\n\tGA23m0M60jag+ZnPPHK53wDJYbpPKh1ZCn47sTjco8ghktNljKJuTpt7WSm3Z9hqInjw\n\t2ZyiCTELFFzEGd78Y2/pN7lKxBQ5DWbCUc6hKNGkG5RInUCga2llag9C8AYa/d2JXYlO\n\tNJGhF4drc3qBqljpQMhN/J95yLV058O++LNSWnkSCIGMlX7+DfJLBPCbkYQZDL/hZjcw\n\tLqhhagtXapikzra7A8l3RfR9xP3khwY0+ObKH80CIRKr4QEaUop1wqcn3hZvn+ZiHHj3\n\tdTUg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"C/isIsbd\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1696598406; x=1697203206;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=AkNVdholsXPriKWLuKJtW86dK6QQTBncTOQiC4z4Br8=;\n\tb=qBAl1jy5jeWJlR2ohsXmG2iu/Po5TKwOO28iXX89/CtAe57hrrMAoHDZ8ODEXdjGnZ\n\t9EbP2jN8LyJdgM7RaqgNC1ZW1i6FMaMOkWGyKM69B/LJT1+EjQOInYt1Tw0XpOHZh65t\n\tsQ4TuGNaPJEGoXe5o1/1QlgxevE3InbMZir0dByp2f3jGV0/kbNIsQuUd5vXmQXpcy1d\n\teF1U28JGSAAeHvPqc56Ubhr/yUZ26bQLmylI0mBeloyqNJVKe5sUDC27xCE0l6NUv6O8\n\tF1x7uLfFOMjB1wPwy+634TsD0xa3LbVxQZE8r73Sb4YYxeYwGSFeON4yLTUs2mJjmkmp\n\t+UZQ==", "X-Gm-Message-State": "AOJu0YzVlVHviPVIBFhrKByGCGKdMb5m1U7qizE7JunqFfjC0H0rfNGW\n\t29T0y1AIPW+IQ2+W9VvZELvPJ0jN9oZaNdctiHtQXg==", "X-Google-Smtp-Source": "AGHT+IH4JjXZge2bjG9GrChSLmLSraioo0o2LzX7iYH4INRMntlW8Z72CClC8b0v2zWySJBahWCQQg==", "X-Received": "by 2002:adf:e6cd:0:b0:31f:a4fa:130a with SMTP id\n\ty13-20020adfe6cd000000b0031fa4fa130amr7469923wrm.14.1696598405459; \n\tFri, 06 Oct 2023 06:20:05 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 6 Oct 2023 14:19:48 +0100", "Message-Id": "<20231006132000.23504-9-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231006132000.23504-1-naush@raspberrypi.com>", "References": "<20231006132000.23504-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 08/20] ipa: rpi: Add PiSP definitions to\n\tthe Controller hardware description", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an entry to Controller::HardwareConfig describing the PiSP hardware\nfor the IPA and controller algorithms to use.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/rpi/controller/controller.cpp | 15 +++++++++++++++\n src/ipa/rpi/controller/controller.h | 1 +\n 2 files changed, 16 insertions(+)", "diff": "diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\nindex 4b6f82b41916..e62becd87e85 100644\n--- a/src/ipa/rpi/controller/controller.cpp\n+++ b/src/ipa/rpi/controller/controller.cpp\n@@ -31,6 +31,7 @@ static const std::map<std::string, Controller::HardwareConfig> HardwareConfigMap\n \t\t\t.agcRegions = { 15 , 1 },\n \t\t\t.agcZoneWeights = { 15 , 1 },\n \t\t\t.awbRegions = { 16, 12 },\n+\t\t\t.cacRegions = { 0, 0 },\n \t\t\t.focusRegions = { 4, 3 },\n \t\t\t.numHistogramBins = 128,\n \t\t\t.numGammaPoints = 33,\n@@ -38,6 +39,20 @@ static const std::map<std::string, Controller::HardwareConfig> HardwareConfigMap\n \t\t\t.statsInline = false,\n \t\t}\n \t},\n+\t{\n+\t\t\"pisp\",\n+\t\t{\n+\t\t\t.agcRegions = { 0, 0 },\n+\t\t\t.agcZoneWeights = { 15, 15 },\n+\t\t\t.awbRegions = { 32, 32 },\n+\t\t\t.cacRegions = { 8, 8 },\n+\t\t\t.focusRegions = { 8, 8 },\n+\t\t\t.numHistogramBins = 1024,\n+\t\t\t.numGammaPoints = 64,\n+\t\t\t.pipelineWidth = 16,\n+\t\t\t.statsInline = true,\n+\t\t}\n+\t},\n };\n \n Controller::Controller()\ndiff --git a/src/ipa/rpi/controller/controller.h b/src/ipa/rpi/controller/controller.h\nindex a8bc61880ab4..6e5f595284fd 100644\n--- a/src/ipa/rpi/controller/controller.h\n+++ b/src/ipa/rpi/controller/controller.h\n@@ -41,6 +41,7 @@ public:\n \t\tlibcamera::Size agcRegions;\n \t\tlibcamera::Size agcZoneWeights;\n \t\tlibcamera::Size awbRegions;\n+\t\tlibcamera::Size cacRegions;\n \t\tlibcamera::Size focusRegions;\n \t\tunsigned int numHistogramBins;\n \t\tunsigned int numGammaPoints;\n", "prefixes": [ "libcamera-devel", "08/20" ] }