Patch Detail
Show a patch.
GET /api/patches/19085/?format=api
{ "id": 19085, "url": "https://patchwork.libcamera.org/api/patches/19085/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19085/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230925092136.51550-2-david.plowman@raspberrypi.com>", "date": "2023-09-25T09:21:36", "name": "[libcamera-devel,v2,1/1] libcamera: controls: Add controls for HDR", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e723e05e3525186db14d1b4203a0b31808fc203f", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19085/mbox/", "series": [ { "id": 4036, "url": "https://patchwork.libcamera.org/api/series/4036/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4036", "date": "2023-09-25T09:21:35", "name": "HDR controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4036/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19085/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19085/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04963BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Sep 2023 09:21:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A96646293F;\n\tMon, 25 Sep 2023 11:21:45 +0200 (CEST)", "from mail-lf1-x131.google.com (mail-lf1-x131.google.com\n\t[IPv6:2a00:1450:4864:20::131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DDCD862945\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Sep 2023 11:21:42 +0200 (CEST)", "by mail-lf1-x131.google.com with SMTP id\n\t2adb3069b0e04-50437c618b4so7144068e87.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Sep 2023 02:21:42 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:2bce:64d6:1a5c:49a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tl18-20020a1c7912000000b003fef3180e7asm14651548wme.44.2023.09.25.02.21.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 25 Sep 2023 02:21:40 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695633705;\n\tbh=VL73W2oQ37NUNAEjqx9cQSiJlWVGq0Y7zjmr6HbMAiE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=q4DGblNtSo1JTIoXGPZTgafk+oZY06YwiC2raombSXIxd2zY70AobzLp2TlDJxcD+\n\t/rJILJLYIDcfefK86BqCJX2RkwT6jEyBRGfkZLIEvz5dp7KIBmwQfvsNh5wIac/zD5\n\tRUE5ma0tgtlsJE8GZiScJYJAM6+DF5FzCojYFmcjYQGDK8qXM2BFiayoraqpAsUL3+\n\txbU0Y0BH6mqgVKWnp3aNtVFyMnfjNlAulKvQHt1h7/8DmPK0JTTn59knO75gr/sszq\n\tWvoBmWQT/0mOFC1vYvbpekJBHIkbgmTmUg4l+BXD+siyKS/U2bSFKmK7FzcNT3RGuZ\n\tJWviN0z8fuscw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695633702; x=1696238502;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=cS9l2AyKJkv9WOOti0SkZyAzlvZOmRvqSqmY++wsf1Y=;\n\tb=IUtTNoxl/6zPLR/zCg8TwkXD2+ljSmbiEhNvTYma55NYCTD/wi/2wUwHrnvgPTvkEL\n\tmipu16klke1v37Be2NxLCIFLMiwq6XqObNKgIDvIosm0RJuUT49QeOA7USCkHdaoY17x\n\tPO2rCec7DgTGG233tQZnpNVooK/OZCXtLMMnTDKSkH14bBEN1k0NGEh8pippNjVA/yKS\n\t7GvvSYED+8g9LbchLeduQF2J49HdO/z0iV1K6sv3czrDfxr4TaxWV8uUeZOzAxbr0Oq/\n\tolczaBPc1HGYbyvrBq+SMKe5BORVAtywGMgK61twPZLEGL8bYOB1qCMkQjwRsiDEnG6i\n\tyjMg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"IUtTNoxl\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695633702; x=1696238502;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=cS9l2AyKJkv9WOOti0SkZyAzlvZOmRvqSqmY++wsf1Y=;\n\tb=DhEhzQWAVrKCJcOP34vYyhDrkIZXtHch7YqHq8P1DdPp+5d619UDcVgehOwP2RVEGK\n\tX80Af/JdO55dp2tmvZJfFsVjfx2GGRzsJEwQ02U35zbtEAp4QVz7JuzYtvbLOKqHc13s\n\tfjgpsAW6oEFShwdoW4BrWV2AH7DM/1ZKMK9n8Oh3aSRAhlb1cNM3XhWxqflrP0ksOSRS\n\tridKCqgp0jSmmrndhejTK9OLri5OVFnmFv+KU9OoljEIoaLoL9bnI5dszf+qwtyEkYUp\n\t1d6iRewGJzHZuVMWsBzbxVYra5lUeWRTF4tXTkyyRkUiPqAZ40k1tMobitPDlcLKs6D9\n\t8Qmg==", "X-Gm-Message-State": "AOJu0YxPzYFgY8EabFQUMlgQ/f1ybbZ1sYf9M1vSOdF00qNGcAjnb7Ua\n\tYayq0BKQ4dx2H/DmYgqcBg+EIS7Cwkg6DiNevT8=", "X-Google-Smtp-Source": "AGHT+IGmDDgstOH6p+xX9oUDkIBbTXbiUJRdTLFrcaxjT7jtsfSM0r0sdNZBIDdxaDEaTOGeAr/pnQ==", "X-Received": "by 2002:a05:6512:104c:b0:502:9fce:b6e0 with SMTP id\n\tc12-20020a056512104c00b005029fceb6e0mr6273853lfb.28.1695633701649; \n\tMon, 25 Sep 2023 02:21:41 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 25 Sep 2023 10:21:36 +0100", "Message-Id": "<20230925092136.51550-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230925092136.51550-1-david.plowman@raspberrypi.com>", "References": "<20230925092136.51550-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/1] libcamera: controls: Add controls\n\tfor HDR", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "David Plowman <david.plowman@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We add an HdrMode control (to enable and disable HDR processing)\nand an HdrChannel, which indicates what kind of HDR frame (short, long\nor otherwise) has just arrived.\n\nCurrently the HdrMode supports the following values:\n\n* Off - no HDR processing at all.\n* MultiExposure - frames at multiple different exposures are combined\n to create HDR images.\n* SingleExposure - multiple frames all at the same exposure are\n combined to create HDR images.\n* Night - multiple frames will be combined to create \"night mode\"\n images.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 55 ++++++++++++++++++++++++++++++++++\n 1 file changed, 55 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex f2e542f4..0b4e2462 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -774,6 +774,61 @@ controls:\n Continuous AF is paused. No further state changes or lens movements\n will occur until the AfPauseResume control is sent.\n \n+ - HdrMode:\n+ type: int32_t\n+ description: |\n+ Control to set the mode to be used for High Dynamic Range (HDR)\n+ imaging.\n+\n+ enum:\n+ - name: HdrModeOff\n+ value: 0\n+ description: |\n+ HDR is not enabled.\n+ - name: HdrModeMultiExposure\n+ value: 1\n+ description: |\n+ Multiple exposures will be used to create HDR images.\n+ - name: HdrModeSingleExposure\n+ value: 2\n+ description: |\n+ Multiple frames all at a single exposure will be used to create HDR\n+ images.\n+ - name: HdrModeNight\n+ value: 3\n+ description: |\n+ Multiple frames will be combined to produce \"night mode\" images.\n+\n+ - HdrChannel:\n+ type: int32_t\n+ description: |\n+ This value is reported back to the application so that it can discover\n+ whether this capture corresponds to the short or long exposure image (or\n+ any other image used by the HDR procedure).\n+\n+ enum:\n+ - name: HdrChannelNone\n+ value: 0\n+ description: |\n+ This image does not correspond to any of the captures used to create\n+ an HDR image.\n+ - name: HdrChannelShort\n+ value: 1\n+ description: |\n+ This is a short exposure image.\n+ - name: HdrChannelMedium\n+ value: 2\n+ description: |\n+ This is a medium exposure image.\n+ - name: HdrChannelLong\n+ value: 3\n+ description: |\n+ This is a long exposure image.\n+ - name: HdrChannel Night\n+ value: 4\n+ description: |\n+ This frame has been used to produce a \"night mode\" image.\n+\n # ----------------------------------------------------------------------------\n # Draft controls section\n \n", "prefixes": [ "libcamera-devel", "v2", "1/1" ] }