Patch Detail
Show a patch.
GET /api/patches/19075/?format=api
{ "id": 19075, "url": "https://patchwork.libcamera.org/api/patches/19075/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19075/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230921165550.50956-12-jacopo.mondi@ideasonboard.com>", "date": "2023-09-21T16:55:48", "name": "[libcamera-devel,v5,11/13] libcamera: rpi: Change default stream formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "98ecc9dcde37c7d92217032c9d0a39f8c3f88e7c", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19075/mbox/", "series": [ { "id": 4034, "url": "https://patchwork.libcamera.org/api/series/4034/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4034", "date": "2023-09-21T16:55:37", "name": "libcamera: Introduce SensorConfiguration", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4034/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19075/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19075/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 545FCC326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Sep 2023 16:56:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E96B262951;\n\tThu, 21 Sep 2023 18:56:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E048C62944\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Sep 2023 18:56:05 +0200 (CEST)", "from uno.lan (93-46-82-201.ip106.fastwebnet.it [93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53E831257;\n\tThu, 21 Sep 2023 18:54:28 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695315374;\n\tbh=+ORVoFtWp9TDl0RMo01WYqmvHdIpoxAqgffn9ObCinY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=M3RONvqQutRhc8ZOdJ89DmsDgjewbcO4RowUh3vq66ba2EEovwQDfg6pOduEbUPbR\n\tDQaykHmsE6pWRFNIfb6oWk1UyRj8A7+vEcXob/GKFe/rl6Z/xBGQHQcxgGS1b3qDK/\n\tog3q5JhSGzJGjYjSzTaNIuutnnYQa9bF1K8oJddZJAw3ahL4abCEZQzgzEThf1+TNi\n\tLuNV9OPnOL4CqU4RO7nXEX3hpzknlx6PU2pCoNTDHe6yRmtIpD2Zfvzt9UhOuzyGXC\n\tN/jkTO4JvRasRcxOlwRV5ou2syFoglKYrX3dBzU3FwOwZ+iQC5kKaxjPctcGAxugSF\n\tMU0+INVxpk2rw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695315268;\n\tbh=+ORVoFtWp9TDl0RMo01WYqmvHdIpoxAqgffn9ObCinY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rWLxlt/2Lwg++7GfsEYZ9DlF4P8vyWd+7t/x2w7Se5z8K7WWyk5A0qC0Ir97JBPQe\n\tEX/jRpZu9mnj2+BHpc7x5lNOGhVkya7nqGdc5pQH6uwZKATIkzhGBbrkFGnXl+rXGI\n\t+yCKArWATFv9299mAVGWbJ/XM0iRrQTlQo7HTxfk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rWLxlt/2\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Sep 2023 18:55:48 +0200", "Message-ID": "<20230921165550.50956-12-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>", "References": "<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change default\n\tstream formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Naushir Patuck <naush@raspberrypi.com>\n\nSwitch to XRGB8888 as a default Viewfinder role output format, and\nYUV420 as a default output format for everything else.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex c560e48c12fb..f8e8e13dc837 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -268,7 +268,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \n \t\tif (fmts.find(out.dev->toV4L2PixelFormat(cfgPixFmt)) == fmts.end()) {\n \t\t\t/* If we cannot find a native format, use a default one. */\n-\t\t\tcfgPixFmt = formats::NV12;\n+\t\t\tcfgPixFmt = formats::YUV420;\n \t\t\tstatus = Adjusted;\n \t\t}\n \n@@ -431,7 +431,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole\n \n \t\tcase StreamRole::StillCapture:\n \t\t\tfmts = data->ispFormats();\n-\t\t\tpixelFormat = formats::NV12;\n+\t\t\tpixelFormat = formats::YUV420;\n \t\t\t/*\n \t\t\t * Still image codecs usually expect the sYCC color space.\n \t\t\t * Even RGB codecs will be fine as the RGB we get with the\n@@ -465,7 +465,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole\n \n \t\tcase StreamRole::Viewfinder:\n \t\t\tfmts = data->ispFormats();\n-\t\t\tpixelFormat = formats::ARGB8888;\n+\t\t\tpixelFormat = formats::XRGB8888;\n \t\t\tcolorSpace = ColorSpace::Sycc;\n \t\t\tsize = { 800, 600 };\n \t\t\tbufferCount = 4;\n", "prefixes": [ "libcamera-devel", "v5", "11/13" ] }