Patch Detail
Show a patch.
GET /api/patches/19069/?format=api
{ "id": 19069, "url": "https://patchwork.libcamera.org/api/patches/19069/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19069/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230921165550.50956-6-jacopo.mondi@ideasonboard.com>", "date": "2023-09-21T16:55:42", "name": "[libcamera-devel,v5,05/13] libcamera: rpi: Allow platformValidate() to adjust format strides", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1047eb03c5e678d3f33aaa767dff89fa5b8a6e06", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19069/mbox/", "series": [ { "id": 4034, "url": "https://patchwork.libcamera.org/api/series/4034/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4034", "date": "2023-09-21T16:55:37", "name": "libcamera: Introduce SensorConfiguration", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4034/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19069/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19069/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83AA4BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Sep 2023 16:56:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3BD26294B;\n\tThu, 21 Sep 2023 18:56:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C27FC62949\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Sep 2023 18:56:03 +0200 (CEST)", "from uno.lan (93-46-82-201.ip106.fastwebnet.it [93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 384FB1102;\n\tThu, 21 Sep 2023 18:54:26 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695315368;\n\tbh=okpaM9IVcdE0ATLSllywNITjoe6yEZ6SVs+WCpQmepE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JqlOPQJvIeVNHc42iP62eIi5Dq3u1HwrzgcJQB8ZZPl2HUWh1/PBzBqQta33hhZZu\n\tMiqAQcbAL0QoZePERR1i/nDvHk8psI+nrBl6sBO4qmfQNo5zfn9npV6XNuKLJ4vPye\n\tuLCY6AqRbwchSXDdja53VJeQwVVfJfFAUfk3bJHCFwGapYsxbxJmt2erIqzhHi7TFX\n\tqN3H9HabkliwRXfsdCk1i1KwgoQo8zSWjyS3avpvi5HUpQGFDEuu7sMO6+AGEDeo9w\n\tpPQkMygSrytY/4nQ9sdM7mXq9mBBbGtyniUzcy/ajmJ1/x4P/kxEJMtaNDjqqp/wuy\n\tY9k0s/lLD+axw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695315266;\n\tbh=okpaM9IVcdE0ATLSllywNITjoe6yEZ6SVs+WCpQmepE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uhBzdXUIEi0N7f3QWFfIHqy1AnRE0bolP3fv4f+vG5cCgplq0gyG5EQmYsplv0n6v\n\tuOcur21SXd1dQvOcA02NaIA0+KvKjsKs21LfH93O8Vq4oju0uz6yG3r6FgCge4TR9C\n\tIZwyvk4KlHdtqWLUrc8fM59rWyixpBntTI4Gx9k4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uhBzdXUI\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Sep 2023 18:55:42 +0200", "Message-ID": "<20230921165550.50956-6-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>", "References": "<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 05/13] libcamera: rpi: Allow\n\tplatformValidate() to adjust format strides", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Naushir Patuck <naush@raspberrypi.com>\n\nPropagate any changes to the format stride done by platformValidate().\nThe stride value may be adjusted for performace reasons.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex c02ceb65cae8..502cdff0051b 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -309,6 +309,17 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \t\tV4L2DeviceFormat format;\n \t\tformat.fourcc = out.dev->toV4L2PixelFormat(cfg.pixelFormat);\n \t\tformat.size = cfg.size;\n+\n+\t\t/*\n+\t\t * platformValidate may have worked out the correct stride so we\n+\t\t * must pass it in. This also needs the planesCount to be set\n+\t\t * correctly or the stride will be ignored.\n+\t\t */\n+\t\tconst PixelFormat &pixFormat = format.fourcc.toPixelFormat();\n+\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixFormat);\n+\t\tformat.planesCount = info.numPlanes();\n+\t\tformat.planes[0].bpl = cfg.stride;\n+\n \t\t/* We want to send the associated YCbCr info through to the driver. */\n \t\tformat.colorSpace = yuvColorSpace_;\n \n", "prefixes": [ "libcamera-devel", "v5", "05/13" ] }