Patch Detail
Show a patch.
GET /api/patches/19049/?format=api
{ "id": 19049, "url": "https://patchwork.libcamera.org/api/patches/19049/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19049/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230916121930.29490-12-jacopo.mondi@ideasonboard.com>", "date": "2023-09-16T12:19:29", "name": "[libcamera-devel,v4,11/12] libcamera: rpi: Change default stream formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "98ecc9dcde37c7d92217032c9d0a39f8c3f88e7c", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19049/mbox/", "series": [ { "id": 4027, "url": "https://patchwork.libcamera.org/api/series/4027/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4027", "date": "2023-09-16T12:19:18", "name": "libcamera: Introduce SensorConfiguration", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4027/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19049/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19049/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55E86C32B2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 16 Sep 2023 12:19:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0196662921;\n\tSat, 16 Sep 2023 14:19:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17EF36291C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 16 Sep 2023 14:19:42 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E6C1C1812;\n\tSat, 16 Sep 2023 14:18:07 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694866791;\n\tbh=14pKWXs3hK4uBwqI3dUv64hTKoGiK05/80YGxK+toS8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=q/8C1srEMMQs+8I0dIdSP9DwSZ/Bpo6WNqoTpSAL/0C/gdxkwWYlTYMHv4jIGURnf\n\t9jPhPn5TmcFDKuK/R0y+D0+oKF8L8UwZahBmVgc4sMLiefY/t3tHy1JqPvJ1BUwhGR\n\txTgQ+4D6P924maZJYuPEAzssUEIdMY+tINGxlsabExL006spx8UEZtUoO2qAy0BBm/\n\tVnNzmPRifYEjj8eTZftVvIAN9jbg+rHPKjx9zXP94CP38etpukD+bIwHz9o2XTAHdj\n\tMjg+WpKTvRXvwM0bSguAqCFoWobxgB/d10oM9PM61FJ3dG1TiP9NHsCIzAKDvQvK6X\n\ts+sFtqori+8xw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1694866688;\n\tbh=14pKWXs3hK4uBwqI3dUv64hTKoGiK05/80YGxK+toS8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vMl0cfgH7eSfYOA6l9jwgW230nz6nOdgaGW7l4e9IZfh4iPYNPRQDlk3g7QUFAWpS\n\tZoAvdxhEDaFfP4e8jwqAQvCLlqb9/iLIiPvQrQ9JAh5EKlb+5d4sKAcEKDxt82/sWg\n\t5hYNhxeXHCOSt0hL+kZG2ItCz0lDC/Q229nFQE9M=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vMl0cfgH\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 16 Sep 2023 14:19:29 +0200", "Message-ID": "<20230916121930.29490-12-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20230916121930.29490-1-jacopo.mondi@ideasonboard.com>", "References": "<20230916121930.29490-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 11/12] libcamera: rpi: Change default\n\tstream formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Naushir Patuck <naush@raspberrypi.com>\n\nSwitch to XRGB8888 as a default Viewfinder role output format, and\nYUV420 as a default output format for everything else.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 9e4411f22902..c69e076aac71 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -264,7 +264,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \n \t\tif (fmts.find(out.dev->toV4L2PixelFormat(cfgPixFmt)) == fmts.end()) {\n \t\t\t/* If we cannot find a native format, use a default one. */\n-\t\t\tcfgPixFmt = formats::NV12;\n+\t\t\tcfgPixFmt = formats::YUV420;\n \t\t\tstatus = Adjusted;\n \t\t}\n \n@@ -427,7 +427,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole\n \n \t\tcase StreamRole::StillCapture:\n \t\t\tfmts = data->ispFormats();\n-\t\t\tpixelFormat = formats::NV12;\n+\t\t\tpixelFormat = formats::YUV420;\n \t\t\t/*\n \t\t\t * Still image codecs usually expect the sYCC color space.\n \t\t\t * Even RGB codecs will be fine as the RGB we get with the\n@@ -461,7 +461,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole\n \n \t\tcase StreamRole::Viewfinder:\n \t\t\tfmts = data->ispFormats();\n-\t\t\tpixelFormat = formats::ARGB8888;\n+\t\t\tpixelFormat = formats::XRGB8888;\n \t\t\tcolorSpace = ColorSpace::Sycc;\n \t\t\tsize = { 800, 600 };\n \t\t\tbufferCount = 4;\n", "prefixes": [ "libcamera-devel", "v4", "11/12" ] }