Patch Detail
Show a patch.
GET /api/patches/19031/?format=api
{ "id": 19031, "url": "https://patchwork.libcamera.org/api/patches/19031/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19031/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230915130650.35691-12-jacopo.mondi@ideasonboard.com>", "date": "2023-09-15T13:06:49", "name": "[libcamera-devel,v3,11/12] libcamera: rpi: Change default stream formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "98ecc9dcde37c7d92217032c9d0a39f8c3f88e7c", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19031/mbox/", "series": [ { "id": 4025, "url": "https://patchwork.libcamera.org/api/series/4025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4025", "date": "2023-09-15T13:06:38", "name": "libcamera: Introduce SensorConfiguration", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19031/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19031/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F4C7C32B3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Sep 2023 13:07:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DCA7162939;\n\tFri, 15 Sep 2023 15:07:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FA1562925\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Sep 2023 15:07:12 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2704E12AE;\n\tFri, 15 Sep 2023 15:05:39 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694783241;\n\tbh=HdX7fPUe7yjplSewSAS8Lj7uy5T/cMNB0e+BsE0aDiM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QHNTVxVXhPwskDgFo3GgXTE7T9W8QmetON1dMqxIMgE2/QBsfBtOl8fbR8MZaalWI\n\teJdB7CyUfuhB719+3BJrjK6B6ja4nbDYLwujwz3PjaJKc+o7ZC67adX8yAWB1bqq2C\n\tbSlEG5wjoMtyq+jbE/HUYW/kqkZnfNCRLN8BtiAKk/qvXQ26rsSOQVkaat4/e156l3\n\tW8nSmyGqgog2ZkSM6aU8FPkXOko7buve9HIYf83yjAIlwpFEdKF3l13z2+XUKYp2kj\n\tIc56BAuSIva2YJM+gZW5+aIkoiGhA5TEjCQC89rIGS6V9iXJHe44GvoSjihUgCbxx/\n\tr0gjrLfwAbb9g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1694783139;\n\tbh=HdX7fPUe7yjplSewSAS8Lj7uy5T/cMNB0e+BsE0aDiM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gPfiVsNW4xPEUD2kHTt+i6aUPykkUQrMOyJcK6TCnNrSDiwXQjyQxvBHKysM8JuAH\n\t2OfCE+ah0j4ZOOOT0BWhhH3u4gVzGAD+maWl+EZzH+38KbFfd5mLTtp4ZCNsX56g7B\n\tkZ4TM4HAMMktArkLcswn3URN0B7yM//JUNWxcHvA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gPfiVsNW\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 15 Sep 2023 15:06:49 +0200", "Message-ID": "<20230915130650.35691-12-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20230915130650.35691-1-jacopo.mondi@ideasonboard.com>", "References": "<20230915130650.35691-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 11/12] libcamera: rpi: Change default\n\tstream formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Naushir Patuck <naush@raspberrypi.com>\n\nSwitch to XRGB8888 as a default Viewfinder role output format, and\nYUV420 as a default output format for everything else.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex d83811801460..0de91123ee50 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -264,7 +264,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \n \t\tif (fmts.find(out.dev->toV4L2PixelFormat(cfgPixFmt)) == fmts.end()) {\n \t\t\t/* If we cannot find a native format, use a default one. */\n-\t\t\tcfgPixFmt = formats::NV12;\n+\t\t\tcfgPixFmt = formats::YUV420;\n \t\t\tstatus = Adjusted;\n \t\t}\n \n@@ -427,7 +427,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole\n \n \t\tcase StreamRole::StillCapture:\n \t\t\tfmts = data->ispFormats();\n-\t\t\tpixelFormat = formats::NV12;\n+\t\t\tpixelFormat = formats::YUV420;\n \t\t\t/*\n \t\t\t * Still image codecs usually expect the sYCC color space.\n \t\t\t * Even RGB codecs will be fine as the RGB we get with the\n@@ -461,7 +461,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole\n \n \t\tcase StreamRole::Viewfinder:\n \t\t\tfmts = data->ispFormats();\n-\t\t\tpixelFormat = formats::ARGB8888;\n+\t\t\tpixelFormat = formats::XRGB8888;\n \t\t\tcolorSpace = ColorSpace::Sycc;\n \t\t\tsize = { 800, 600 };\n \t\t\tbufferCount = 4;\n", "prefixes": [ "libcamera-devel", "v3", "11/12" ] }