Patch Detail
Show a patch.
GET /api/patches/18972/?format=api
{ "id": 18972, "url": "https://patchwork.libcamera.org/api/patches/18972/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18972/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230901150215.11585-10-jacopo.mondi@ideasonboard.com>", "date": "2023-09-01T15:02:12", "name": "[libcamera-devel,v5,09/12] py: libcamera: Define and use Orientation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7e3592d0df11b9986c7cd1afe6bc64408635ec98", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18972/mbox/", "series": [ { "id": 4010, "url": "https://patchwork.libcamera.org/api/series/4010/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4010", "date": "2023-09-01T15:02:03", "name": "libcamera: Replace CameraConfiguration::transform", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4010/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18972/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18972/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AE5CC32B4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 1 Sep 2023 15:02:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AADE9628F9;\n\tFri, 1 Sep 2023 17:02:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2773A628F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Sep 2023 17:02:54 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 03A911AE1;\n\tFri, 1 Sep 2023 17:01:29 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1693580577;\n\tbh=N1DjEyiYLvi/RGVTAM7jwnHuU/GWNXYULPoZ5atYN40=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=W9TWlqYiMdkFwmoJbA1W7e09rCVZXaLP8z3ibKMzBHx00km8Sw5VdarB02HLMWmQ+\n\tRLZjx4P1hANfn7fHwe7J98Usy+E3xyFHgW4q191k9IJf4+YYSy6PV2R2LVv6zb/Nrq\n\tNT+jv5qxc5bqNcGfVXi9mTvuhbbDkqwRhmROpYgWrfhxPByMCOGYjfebqvqbztXn7X\n\tglQxWzSSwoMVxih4q2Z6UZCLJwSToGVQNpey6e+vbyETIJWFEhaIhlUCtR497TvBhT\n\t9eCvLqX17C9Rn4R+fHKNZjVHuPHWQE8elIRIR/WdQYaEY760M1yHzRnwSvY4Q/deyf\n\tJ91rQ0dVqKcyg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1693580490;\n\tbh=N1DjEyiYLvi/RGVTAM7jwnHuU/GWNXYULPoZ5atYN40=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KwaNOReg0LD7x7yuvhhy1Wi2SspNTr7d+YYNBafLPhR+iGOBuu2qD2MUDdLd1RK4O\n\t9UuO8ZD/dl6dgTYWkr/vrHWKn/jg5XyCSvLYML5/tydWL5DZVy/9EdO6nyKz10FHMP\n\tcS45xYDvvEMZ256MwjYHXMueNfhoPhuQXKf4+iZA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KwaNOReg\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Sep 2023 17:02:12 +0200", "Message-Id": "<20230901150215.11585-10-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20230901150215.11585-1-jacopo.mondi@ideasonboard.com>", "References": "<20230901150215.11585-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 09/12] py: libcamera: Define and use\n\tOrientation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Define an enumeration type for Orientation and expose the\nCameraConfiguration::orientation property in place of\nCameraConfiguration::transform.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/py/libcamera/py_enums.cpp | 10 ++++++++++\n src/py/libcamera/py_main.cpp | 2 +-\n 2 files changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/py/libcamera/py_enums.cpp b/src/py/libcamera/py_enums.cpp\nindex 803c4e7ee362..3cf381e2eb84 100644\n--- a/src/py/libcamera/py_enums.cpp\n+++ b/src/py/libcamera/py_enums.cpp\n@@ -31,4 +31,14 @@ void init_py_enums(py::module &m)\n \t\t.value(\"String\", ControlType::ControlTypeString)\n \t\t.value(\"Rectangle\", ControlType::ControlTypeRectangle)\n \t\t.value(\"Size\", ControlType::ControlTypeSize);\n+\n+\tpy::enum_<Orientation>(m, \"Orientation\")\n+\t\t.value(\"Rotate0\", Orientation::rotate0)\n+\t\t.value(\"Rotate0Flip\", Orientation::rotate0Flip)\n+\t\t.value(\"Rotate180\", Orientation::rotate180)\n+\t\t.value(\"Rotate180Flip\", Orientation::rotate180Flip)\n+\t\t.value(\"Rotate90Flip\", Orientation::rotate90Flip)\n+\t\t.value(\"Rotate270\", Orientation::rotate270)\n+\t\t.value(\"Rotate270Flip\", Orientation::rotate270Flip)\n+\t\t.value(\"Rotate90\", Orientation::rotate90);\n }\ndiff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 01fb15a9391c..63371dce38b3 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -293,7 +293,7 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t py::return_value_policy::reference_internal)\n \t\t.def_property_readonly(\"size\", &CameraConfiguration::size)\n \t\t.def_property_readonly(\"empty\", &CameraConfiguration::empty)\n-\t\t.def_readwrite(\"transform\", &CameraConfiguration::transform);\n+\t\t.def_readwrite(\"orientation\", &CameraConfiguration::orientation);\n \n \tpyCameraConfigurationStatus\n \t\t.value(\"Valid\", CameraConfiguration::Valid)\n", "prefixes": [ "libcamera-devel", "v5", "09/12" ] }