Patch Detail
Show a patch.
GET /api/patches/18934/?format=api
{ "id": 18934, "url": "https://patchwork.libcamera.org/api/patches/18934/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18934/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230808125228.29043-8-jacopo.mondi@ideasonboard.com>", "date": "2023-08-08T12:52:26", "name": "[libcamera-devel,RFC,7/9] libcamera: device_enumerator: Search for USB devices", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6063dc6bc09a887b26d3cf6b0ce9f0ee0579e820", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18934/mbox/", "series": [ { "id": 4002, "url": "https://patchwork.libcamera.org/api/series/4002/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4002", "date": "2023-08-08T12:52:19", "name": "libcamera: Generalize device match and support USB devices", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4002/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18934/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18934/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A72C2C32B1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 8 Aug 2023 12:52:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D68E8627F1;\n\tTue, 8 Aug 2023 14:52:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C920627EE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 8 Aug 2023 14:52:50 +0200 (CEST)", "from uno.localdomain (mob-5-90-60-22.net.vodafone.it [5.90.60.22])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0B308625; \n\tTue, 8 Aug 2023 14:51:42 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1691499178;\n\tbh=poC0tU/raVEL68/bMsRJ6XkKvmnAQXlmX95+AFg0C6o=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OrLME9fcSON9KmURyDyh3W1sZlWLq7SZ5LshOGiZcfujwUa0m0TYKmis9bzs++I9L\n\tesHiYwmuMHKhcY26ntdyRgotYO9BgKl+4ow113A7PM8fnNL0lrQ/pejx/6tzFhmPTA\n\tFUPg0FJ9jOI92UOniPhNG8aPLqb19HW8YvH4HoUlPTDzoDpBvP5DnS5dLz4y6XywyD\n\tgDSkPbybMgxUQdBt0IprdiSvnV3ffuUpdrdzTo0f4mSl+YQtFxGyIjvh+aUUgrwB0w\n\tOnO/VfxWBiqh1DEOA6VKbhwsKoA73GNEIdROU4rqgDr8+QmiifibH44ML0l5af8xce\n\tVpnZrVrmdPZSw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1691499103;\n\tbh=poC0tU/raVEL68/bMsRJ6XkKvmnAQXlmX95+AFg0C6o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=R+YarRLb2KZ7mJXlNlwvM6AWS0VOHQl7YD+151uUYmRjNtI6f1B3fenMvkACGTXub\n\twNBhaGYl9tAlUJpZkaB3+FC7esLfJDDiqg7qRrYsvanv5hfGKE5VhYcLnb6Cdvjuou\n\t5U7L8TSSbPPRo3By+txoISlzR2iGUbYiSVfRFZ4Q=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R+YarRLb\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org, Sophie Friedrich <dev@flowerpot.me>", "Date": "Tue, 8 Aug 2023 14:52:26 +0200", "Message-Id": "<20230808125228.29043-8-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20230808125228.29043-1-jacopo.mondi@ideasonboard.com>", "References": "<20230808125228.29043-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC 7/9] libcamera: device_enumerator: Search\n\tfor USB devices", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for searching a USBDevice by providing a USBDeviceMatch\nto the device enumerator.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/internal/device_enumerator.h | 1 +\n src/libcamera/device_enumerator.cpp | 14 ++++++++++++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h\nindex 1d6dbcb104b8..f4ee349906f2 100644\n--- a/include/libcamera/internal/device_enumerator.h\n+++ b/include/libcamera/internal/device_enumerator.h\n@@ -31,6 +31,7 @@ public:\n \tvirtual int enumerate() = 0;\n \n \tstd::shared_ptr<MediaDevice> search(const MediaDeviceMatch &dm);\n+\tstd::shared_ptr<USBDevice> search(const USBDeviceMatch &dm);\n \n \tSignal<> devicesAdded;\n \ndiff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 1fde7367cfa8..0d983032e2c6 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -271,4 +271,18 @@ std::shared_ptr<MediaDevice> DeviceEnumerator::search(const MediaDeviceMatch &dm\n \treturn nullptr;\n }\n \n+std::shared_ptr<USBDevice> DeviceEnumerator::search(const USBDeviceMatch &dm)\n+{\n+\tfor (std::shared_ptr<USBDevice> &usb : usbDevices_) {\n+\t\tif (dm.match(usb.get())) {\n+\t\t\tLOG(DeviceEnumerator, Debug)\n+\t\t\t\t<< \"Successful match for USB device \"\n+\t\t\t\t<< usb->vid() << \"-\" << usb->pid();\n+\t\t\treturn usb;\n+\t\t}\n+\t}\n+\n+\treturn nullptr;\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "RFC", "7/9" ] }