Patch Detail
Show a patch.
GET /api/patches/1893/?format=api
{ "id": 1893, "url": "https://patchwork.libcamera.org/api/patches/1893/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1893/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190829232653.13214-7-niklas.soderlund@ragnatech.se>", "date": "2019-08-29T23:26:45", "name": "[libcamera-devel,v2,06/14] libcamera: controls: Add AeEnable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e6e3b05a66d87a56614d28a783c039ec1a41be47", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1893/mbox/", "series": [ { "id": 475, "url": "https://patchwork.libcamera.org/api/series/475/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=475", "date": "2019-08-29T23:26:40", "name": "libcamera: ipa: Add basic IPA support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/475/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1893/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1893/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4749361924\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2019 01:27:33 +0200 (CEST)", "from bismarck.berto.se (unknown [79.202.45.17])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 9041ad38-cab4-11e9-837a-0050569116f7;\n\tFri, 30 Aug 2019 01:27:27 +0200 (CEST)" ], "X-Halon-ID": "9041ad38-cab4-11e9-837a-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Aug 2019 01:26:45 +0200", "Message-Id": "<20190829232653.13214-7-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.22.1", "In-Reply-To": "<20190829232653.13214-1-niklas.soderlund@ragnatech.se>", "References": "<20190829232653.13214-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 06/14] libcamera: controls: Add AeEnable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 29 Aug 2019 23:27:33 -0000" }, "content": "Add a control to turn Auto Exposure on or off.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/control_ids.h | 1 +\n src/libcamera/controls.cpp | 15 +++++++++++++--\n 2 files changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\nindex 75b6a2d5cafeca72..8cd44e571f705ac5 100644\n--- a/include/libcamera/control_ids.h\n+++ b/include/libcamera/control_ids.h\n@@ -13,6 +13,7 @@\n namespace libcamera {\n \n enum ControlId {\n+\tAeEnable,\n \tAwbEnable,\n \tBrightness,\n \tContrast,\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 727fdbd9450d2f40..35861e27401d5241 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -186,6 +186,13 @@ std::string ControlValue::toString() const\n * \\brief Numerical control ID\n */\n \n+/**\n+ * \\var AeEnable\n+ * ControlType: Bool\n+ *\n+ * Enables or disables the AE. See also \\a libcamera::ControlId::ManualExposure.\n+ */\n+\n /**\n * \\var AwbEnable\n * ControlType: Bool\n@@ -218,14 +225,18 @@ std::string ControlValue::toString() const\n * \\var ManualExposure\n * ControlType: Integer\n *\n- * Specify a fixed exposure time in milli-seconds\n+ * Specify a fixed exposure time in milli-seconds.\n+ *\n+ * This control is only considered if AeEnable is not enabled.\n */\n \n /**\n * \\var ManualGain\n * ControlType: Integer\n *\n- * Specify a fixed gain parameter\n+ * Specify a fixed gain parameter.\n+ *\n+ * This control is only considered if AeEnable is not enabled.\n */\n \n /**\n", "prefixes": [ "libcamera-devel", "v2", "06/14" ] }