Patch Detail
Show a patch.
GET /api/patches/18902/?format=api
{ "id": 18902, "url": "https://patchwork.libcamera.org/api/patches/18902/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18902/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230728161517.15399-1-laurent.pinchart@ideasonboard.com>", "date": "2023-07-28T16:15:17", "name": "[libcamera-devel] meson: Correctly locate libc++", "commit_ref": "eed6a079d2f989bdbc24ff1d3f8fc4360fc577b0", "pull_url": null, "state": "accepted", "archived": false, "hash": "2683c4b5be90655f2168e9611581073d19275c73", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18902/mbox/", "series": [ { "id": 3994, "url": "https://patchwork.libcamera.org/api/series/3994/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3994", "date": "2023-07-28T16:15:17", "name": "[libcamera-devel] meson: Correctly locate libc++", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3994/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18902/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18902/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8111BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jul 2023 16:15:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 23321627EB;\n\tFri, 28 Jul 2023 18:15:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88D36627E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jul 2023 18:15:13 +0200 (CEST)", "from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1FC27F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jul 2023 18:14:12 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690560915;\n\tbh=Sp0qECWmVh/ZuUTtS2SgQej0LisPOPM5J+JTN1l605Y=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=FM5L9fzXJw0Jal84mbAg0Xu3j1fxpv2Ax3Yh0yFVNO8txbK3L75p3dn+RQHRR/oAX\n\twE0fYy//nkrkGo8VPb0Q51Xu6LW8Nknm/o8htR6CNYRGN03tOxVvhFYxzDkxCENoQm\n\t17uSFxn8QbvDVq079ON4HdT0NGNOmKTp5/JPzM6sZ3I7BS+RbYi8LgOHJDpw2czaZ0\n\t+DCMjeJ4EGhvmS7atZztVsFyE+hFafXDJ7TpIhkwctVfpgj2MYsAlYQrpcn17C+8DH\n\t6xgFQivNSDsMQvgHOv3rIZMWiWx+oygMDgFtwFD63hKPoTC15QcAYKkyWVizWKCOz3\n\tg8Oqufph8iyxA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690560852;\n\tbh=Sp0qECWmVh/ZuUTtS2SgQej0LisPOPM5J+JTN1l605Y=;\n\th=From:To:Subject:Date:From;\n\tb=Zgbd4BRfNMvHTiwP6i6I5rwHgke7r6YN3dUrURvN/gtQ4g0vnHFXBoOExznQIAEkH\n\t9/KNPvSIKHBYU8PHZaxnPuTBk/t0qkZyF1IGkXbNGzBvAIbmxKU1gcwIBQXtad0qNn\n\t7q41FFeBWkhywiMRL9D9hpUecFFUJ9NcE+nLItnc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Zgbd4BRf\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 28 Jul 2023 19:15:17 +0300", "Message-ID": "<20230728161517.15399-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.41.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] meson: Correctly locate libc++", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The meson find_library() function takes a library name without the \"lib\"\nprefix. Its usage to find lic++ is thus not correct, and meson warns\nabout it:\n\nWARNING: find_library('libc++') starting in \"lib\" only works by accident and is not portable\n\nFix it by dropping the \"lib\" prefix.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 031e1eda08f0..7959b5386eee 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -109,7 +109,7 @@ if cc.get_id() == 'clang'\n \n # Use libc++ by default if available instead of libstdc++ when compiling\n # with clang.\n- if cc.find_library('libc++', required : false).found()\n+ if cc.find_library('c++', required : false).found()\n cpp_arguments += [\n '-stdlib=libc++',\n ]\n", "prefixes": [ "libcamera-devel" ] }