Patch Detail
Show a patch.
GET /api/patches/18890/?format=api
{ "id": 18890, "url": "https://patchwork.libcamera.org/api/patches/18890/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18890/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230725125641.1557350-2-kieran.bingham@ideasonboard.com>", "date": "2023-07-25T12:56:40", "name": "[libcamera-devel,1/2] py: gen-py-controls: Remove SceneFlicker workaround", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6e8e1ec5e71486a0e43e1b8208423464e76e3e3a", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18890/mbox/", "series": [ { "id": 3987, "url": "https://patchwork.libcamera.org/api/series/3987/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3987", "date": "2023-07-25T12:56:39", "name": "libcamera: pipeline: AeFlickerMode support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3987/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18890/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18890/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EA09C324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Jul 2023 12:56:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 191AE628C6;\n\tTue, 25 Jul 2023 14:56:50 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F6B361E29\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jul 2023 14:56:47 +0200 (CEST)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 967ABA06;\n\tTue, 25 Jul 2023 14:55:48 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690289810;\n\tbh=MHr/q2/XPNp28koWGsMujRqxQLVldKxL7/9CX6gIJIs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oPb0CgTdJDw9RVJY/UF4WLXGkKDm16DnjRrn4NQgLafddMlHNzwyTcbKD2XNGST+3\n\tun/sYQQy84vBw/yb2ld/iVmAKXm2D3HYuO1GwWTN/ILBEETPkR8yfBcHtUrOJ35cl7\n\t0+GOiLBw6lBCQ8E84MvRhvx/lKKwc4rjp+1C4s2EjvI7ihG/tmjhrjoZlsLZnyH6PD\n\toeWLgVuAilCsVZ/7/r+5GJ9Km3Wpx1cPKN5xSr5QmdpoEmOgn4hTzqz0VyzfPVlTni\n\t+iCzTaCh4WE0+p4umfEs2Cowx2TmlHqGrSYK5Jdqvv6H4yDpYcZ1t9T9FjTCkBlAG1\n\t6kX4MbSyGRD2w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690289748;\n\tbh=MHr/q2/XPNp28koWGsMujRqxQLVldKxL7/9CX6gIJIs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RgihpP8jIbTikn6nR2dCkdUez69l64RwLkaeEQnpQm836VWyumzPMFA1Cjm4lB6rz\n\tKp/q/70CMyw8cXV1iGjnYtT+OEjzDi72cWUayRU+Wet56TueUSZkRJtYT932G0NK2j\n\tfegNGHpHTzBzpk2Ggg6XRNZEi4rm/4BXREC0SboY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RgihpP8j\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 25 Jul 2023 13:56:40 +0100", "Message-Id": "<20230725125641.1557350-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230725125641.1557350-1-kieran.bingham@ideasonboard.com>", "References": "<20230725125641.1557350-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] py: gen-py-controls: Remove\n\tSceneFlicker workaround", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The python bindings layer has to parse the libcamera controls to ensure\nthat they are converted to suitable names for the python layer.\n\nPart of this strips out common prefixes from control names, however the\nSceneFlicker control would end up using an illegal name if processed in\nthe same way as the other controls.\n\nThe SceneFlicker control has now been removed as part of the\nintroduction of the AeFlickerMode and AeFlickerPeriod controls.\n\nRemove the workaround in the python layer.\n\nFixes: 6fdbf3f38c31 (\"libcamera: controls: Add controls for AEC/AGC flicker avoidance\")\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/py/libcamera/gen-py-controls.py | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/src/py/libcamera/gen-py-controls.py b/src/py/libcamera/gen-py-controls.py\nindex 99f3bbcf5b80..9948c41e42b1 100755\n--- a/src/py/libcamera/gen-py-controls.py\n+++ b/src/py/libcamera/gen-py-controls.py\n@@ -48,9 +48,6 @@ def generate_py(controls, mode):\n # Adjustments for controls\n if name == 'LensShadingMapMode':\n prefix = 'LensShadingMapMode'\n- elif name == 'SceneFlicker':\n- # If we strip the prefix, we would get '50Hz', which is illegal name\n- prefix = ''\n else:\n prefix = find_common_prefix([e['name'] for e in enum])\n else:\n", "prefixes": [ "libcamera-devel", "1/2" ] }