Patch Detail
Show a patch.
GET /api/patches/18885/?format=api
{ "id": 18885, "url": "https://patchwork.libcamera.org/api/patches/18885/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18885/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230725085540.24863-4-naush@raspberrypi.com>", "date": "2023-07-25T08:55:39", "name": "[libcamera-devel,v2,3/4] pipeline: rpi: Rename RPi::Stream::setExternalBuffer()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9583b7d57180a979c043622686a0e72ac32c22c6", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18885/mbox/", "series": [ { "id": 3984, "url": "https://patchwork.libcamera.org/api/series/3984/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3984", "date": "2023-07-25T08:55:36", "name": "Raspberry Pi: External buffer handling", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3984/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18885/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18885/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E4A8BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Jul 2023 08:56:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 679B7628C7;\n\tTue, 25 Jul 2023 10:56:14 +0200 (CEST)", "from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10200628C2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jul 2023 10:56:09 +0200 (CEST)", "by mail-wr1-x42e.google.com with SMTP id\n\tffacd0b85a97d-3172144c084so4870565f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jul 2023 01:56:09 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tl7-20020adfe587000000b0030c4d8930b1sm1951225wrm.91.2023.07.25.01.56.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 25 Jul 2023 01:56:09 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690275374;\n\tbh=1fnLpr1wa84MpD0IMDou9Rq/4rFrHRBJBNExdpYPyao=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oC4S3EG4NWUWjxGysTO38suIJzlF11jtLboTw8DqAyHspFydfBB1A/gA7uemZKo/I\n\tWLY2adtjnwmvnNCN7RiHfji2WjcRIKlvd7nfnGK3JKwtsEqPLBfb3yp2vdT/vVZYhO\n\tuWjD/O+I+slBnKG92/M6rqT9JJub0+DMC8zL94sBnco9fgyQIVqeXKVZu3iirmk+v7\n\tdQjWnjVE5N4SoK21b1GfPQ4n+9qgsA4QoA5hsJafXCH/k2IZL2T1AVl3h9frm6RnAw\n\tjM+QfXbvPNttQOqAEJl2Qr3nszs4HMsDImQbnO4VHNMotx4N8qkfYxWsszFkWDaLSo\n\tCBCdu6Kv35A5w==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1690275369; x=1690880169;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=afYDoMhDTlrP7nKJ5B2hFBGcqavnrUzYmRNnMdv926w=;\n\tb=gUWOVwa7qw4z1QrPq49CcZj/cKqYKq3pUFCPJzzXP8aeVyffDs08RlC67iDJI4stgA\n\tDSGcQXR/8pDsy37Jm2u+Aujx1ER2EsRLu2TIzG7bwbTBFitb4p1xM74FMudg+FTYAKA1\n\tjIbpdWdbFiEE4FxhUc4DW1LxIeMCIgY25SaIPjSbEVV/+OSqEwlSttcKPcarW2o1VBNn\n\tlhPUOexTtv8kvfESLl2riA98GVcOuwN97BUAu1x32fzRoxmJ18m+9UUM2m6ffYu/TfJO\n\ttO3L/65uJkYxOWOckDL21bGBWvOB6jcgEh0Wq4e6dkEYJp74xP0buL6NeXPHWKvOsVdW\n\t9Rgw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"gUWOVwa7\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1690275369; x=1690880169;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=afYDoMhDTlrP7nKJ5B2hFBGcqavnrUzYmRNnMdv926w=;\n\tb=NIK/rGesX7ajygQVmsd3ikgBmY33QFe0MIXnRDcVodrFDkt3AayqvMi3UcbDkLepY6\n\twZlusvbzjPAXAIpegmKAMhZ/z28UQhwExcNvHcLPiNWTSivFLVYpn1oAtuQJbGxRtpji\n\tERjW1RpiaWs3vTCgcRGVvcQZWEVjLwHiwMkOxLJkStvsJfloGymZKcGoomsWpmGGwLEa\n\tAGZ6SA6p+PJKh12XtrXaMhVmkmn4keqXiQcmrbMssbe757i255+DByHFKiAjItsSQ3NB\n\tb2qXq/NFLZxDpu3wajJ1PIuh/VR3HxjrrsPvXqw82cV4FgzST6rPalgoX1I3rxESoiFD\n\tfZiA==", "X-Gm-Message-State": "ABy/qLbdcOEDLqKIb4dvbAcvJjTuRtH+NsHL9acXY/qX4w8mvAmMhM0o\n\tKtI0XhiwxXhopasVtj2kzQSkzGTNk/vcRp1gGEgWDA==", "X-Google-Smtp-Source": "APBJJlHR5VouFhGzZU7N0gSuABr7Gyth/eOiwHVSvNqmih/oLr4OtcOTT2YqoDllTkcqTS5lzvfwmw==", "X-Received": "by 2002:adf:de0b:0:b0:317:6edb:6138 with SMTP id\n\tb11-20020adfde0b000000b003176edb6138mr591310wrm.62.1690275369492; \n\tTue, 25 Jul 2023 01:56:09 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 25 Jul 2023 09:55:39 +0100", "Message-Id": "<20230725085540.24863-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230725085540.24863-1-naush@raspberrypi.com>", "References": "<20230725085540.24863-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/4] pipeline: rpi: Rename\n\tRPi::Stream::setExternalBuffer()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since we don't distinguish between externally and internally allocated\ndma bufs, rename this function to setExportedBuffer() to clearer on its\nfunction.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 +-\n src/libcamera/pipeline/rpi/common/rpi_stream.cpp | 2 +-\n src/libcamera/pipeline/rpi/common/rpi_stream.h | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex f244edc68a85..fc0c0ec3c53c 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -764,7 +764,7 @@ int PipelineHandlerBase::queueRequestDevice(Camera *camera, Request *request)\n \t\t\t * outside the v4l2 device. Store it in the stream buffer list\n \t\t\t * so we can track it.\n \t\t\t */\n-\t\t\tstream->setExternalBuffer(buffer);\n+\t\t\tstream->setExportedBuffer(buffer);\n \t\t}\n \n \t\t/*\ndiff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\nindex 74b5abf447c7..e1858c731f57 100644\n--- a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n@@ -76,7 +76,7 @@ unsigned int Stream::getBufferId(FrameBuffer *buffer) const\n \treturn it->first;\n }\n \n-void Stream::setExternalBuffer(FrameBuffer *buffer)\n+void Stream::setExportedBuffer(FrameBuffer *buffer)\n {\n \tbufferMap_.emplace(id_.get(), buffer);\n }\ndiff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.h b/src/libcamera/pipeline/rpi/common/rpi_stream.h\nindex ca591f99cc45..d1289c4679b9 100644\n--- a/src/libcamera/pipeline/rpi/common/rpi_stream.h\n+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.h\n@@ -76,7 +76,7 @@ public:\n \tconst BufferMap &getBuffers() const;\n \tunsigned int getBufferId(FrameBuffer *buffer) const;\n \n-\tvoid setExternalBuffer(FrameBuffer *buffer);\n+\tvoid setExportedBuffer(FrameBuffer *buffer);\n \n \tint prepareBuffers(unsigned int count);\n \tint queueBuffer(FrameBuffer *buffer);\n", "prefixes": [ "libcamera-devel", "v2", "3/4" ] }