Patch Detail
Show a patch.
GET /api/patches/18848/?format=api
{ "id": 18848, "url": "https://patchwork.libcamera.org/api/patches/18848/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18848/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230718105210.83558-8-jacopo.mondi@ideasonboard.com>", "date": "2023-07-18T10:52:07", "name": "[libcamera-devel,v3,07/10] libcamera: transform: Add operations with Orientation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b48e062701793c893d2cf2330849c851e00d1353", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18848/mbox/", "series": [ { "id": 3976, "url": "https://patchwork.libcamera.org/api/series/3976/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3976", "date": "2023-07-18T10:52:00", "name": "libcamera: Replace CameraConfiguration::transform", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3976/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18848/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18848/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82AB4C32AB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 18 Jul 2023 10:52:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44D61628D9;\n\tTue, 18 Jul 2023 12:52:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89BCD61E2B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Jul 2023 12:52:27 +0200 (CEST)", "from uno.localdomain (mob-5-90-54-150.net.vodafone.it\n\t[5.90.54.150])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4DB98D0;\n\tTue, 18 Jul 2023 12:51:33 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689677551;\n\tbh=yqDVuGpaamdkaEB2dVC3yi1+f1QsnW54T2hpQtgCfXo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JZ4APllopNXW5zCm5HQ1xTxYi8VqjaAIXX5hjBDJmmM9tudQanE6q365y7hxlFfUf\n\tyosE7jX+YiBQiCDzwpb4ErBvLTZ3y/QOlRIIR1gB4xTdC6mp6JckGi7K0rvqVFIFAb\n\tW2AGd/BQUoc041a2gpKmgTDI1NcWioyh/TrnHjvqS0OibcGNP/ganKp2mZDM2kJrS9\n\thSqWO5AiguC9mrvr+Ct448Rc4BKy3QaTNTRzRb3HLJqUTSfXB+uZdX7pJb8ADM+/WX\n\t/UlkGNaq9QSU/VAXiYIBx4JvD/AAOanyhmP4lrKTIGSe9U5DOGdUhhPmIgVbk6D1jt\n\tkjos4YxLwnCkw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689677494;\n\tbh=yqDVuGpaamdkaEB2dVC3yi1+f1QsnW54T2hpQtgCfXo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WZgXf4rIaZwFcfr4xcmLH3nw9LlAKTcuECm144G1LgLPY16zSsHTn8AqhB6YnKT5K\n\tNLNGr7q2gPtOkU5fv0aqJqsa+MkqMFj4AJPvlijGK93Mr4Go+jEcW67+mryGsWkelr\n\tWbZ5/HmFeLQ73giIGHPlRHHJ7ToJg88oV7a2svcY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WZgXf4rI\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 18 Jul 2023 12:52:07 +0200", "Message-Id": "<20230718105210.83558-8-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20230718105210.83558-1-jacopo.mondi@ideasonboard.com>", "References": "<20230718105210.83558-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 07/10] libcamera: transform: Add\n\toperations with Orientation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add two operations that allows to combine Transform with Orientation.\n\n- Transform operator/(Orientation1, Orientation2)\n allows to easily get back the Transform that needs to be applied to\n Orientation2 to get Orientation1\n\n- Orientation operator*(Orientation1, Transform)\n allows to apply a Transform to an Orientation and obtain the\n combination of the two\n\nThese two operations allow applications to use Transforms to\nmanipulate the Orientation inside the CameraConfiguration, if they\nwish.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/transform.h | 3 +++\n src/libcamera/transform.cpp | 37 +++++++++++++++++++++++++++++++++++\n 2 files changed, 40 insertions(+)", "diff": "diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\nindex 14f1db0e8572..847a1f94713c 100644\n--- a/include/libcamera/transform.h\n+++ b/include/libcamera/transform.h\n@@ -74,6 +74,9 @@ Transform transformFromRotation(int angle, bool *success = nullptr);\n Transform transformFromOrientation(const Orientation &orientation);\n Orientation transformToOrientation(const Transform &transform);\n \n+Transform operator/(const Orientation &o1, const Orientation &o2);\n+Orientation operator*(const Orientation &o1, const Transform &t);\n+\n const char *transformToString(Transform t);\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/transform.cpp b/src/libcamera/transform.cpp\nindex d192d63d9290..80cd804ca530 100644\n--- a/src/libcamera/transform.cpp\n+++ b/src/libcamera/transform.cpp\n@@ -362,6 +362,43 @@ Orientation transformToOrientation(const Transform &transform)\n \treturn Orientation::rotate0;\n }\n \n+/**\n+ * \\brief Return the Transform that applied to \\a o2 gives \\a o1\n+ * \\param o1 The Orientation to obtain\n+ * \\param o2 The base Orientation\n+ *\n+ * This operation can be used to easily compute the Transform to apply to a\n+ * base orientation \\a o2 to get the desired orientation \\a o1.\n+ *\n+ * The CameraSensor class uses this function to compute what Transform to apply\n+ * to a camera with mounting rotation \\a o2 (the base) to obtain the user\n+ * requested orientation \\a o1.\n+ *\n+ * \\return A Transform that applied to \\a o2 gives \\a o1\n+ */\n+Transform operator/(const Orientation &o1, const Orientation &o2)\n+{\n+\tTransform t1 = transformFromOrientation(o1);\n+\tTransform t2 = transformFromOrientation(o2);\n+\n+\treturn -t2 * t1;\n+}\n+\n+/**\n+ * \\brief Apply the Transform \\a t on the base orientation \\a o\n+ * \\param o The base orientation\n+ * \\param t The transform to apply on \\a o\n+ * \\return The Orientation resulting from applying \\a t on \\a o\n+ */\n+Orientation operator*(const Orientation &o, const Transform &t)\n+{\n+\t/*\n+\t * Apply a Transform corresponding to the base orientation first and\n+\t * then apply \\a t to it.\n+\t */\n+\treturn transformToOrientation(transformFromOrientation(o) * t);\n+}\n+\n /**\n * \\brief Return a character string describing the transform\n * \\param[in] t The transform to be described.\n", "prefixes": [ "libcamera-devel", "v3", "07/10" ] }