Patch Detail
Show a patch.
GET /api/patches/18810/?format=api
{ "id": 18810, "url": "https://patchwork.libcamera.org/api/patches/18810/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18810/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230711145513.714742-1-kieran.bingham@ideasonboard.com>", "date": "2023-07-11T14:55:13", "name": "[libcamera-devel,v2] README: Add unit tests instructions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0513ff2a0ab8af12b6908f58a4092aff0d97cdd8", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18810/mbox/", "series": [ { "id": 3967, "url": "https://patchwork.libcamera.org/api/series/3967/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3967", "date": "2023-07-11T14:55:13", "name": "[libcamera-devel,v2] README: Add unit tests instructions", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3967/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18810/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18810/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34935BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 11 Jul 2023 14:55:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BA97628C0;\n\tTue, 11 Jul 2023 16:55:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2500E60570\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Jul 2023 16:55:17 +0200 (CEST)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E38ECDFB;\n\tTue, 11 Jul 2023 16:54:27 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689087318;\n\tbh=XXNI4cG4adUNigCekmhKb56OgZBJ8wJwP/Tovk+qPTA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=amhgaCp4GyLxjAi7oPrWDYiviSh9vvAi3dnnb3J2xI+eqhNHV6lBiAaIaUnDPR0Y8\n\tCwVFEIURzW1FP3Sg4hPk9WFD2Ip3ui/LiWcsLMCv4Rh7P7qEz+vZI/wh4K8RptK0gV\n\t8g1StVJxunMcJySB1SLqQ6qfC3Y7u17KNhoonw36f4srMg61HimTV9LpCZmpY2BxWA\n\t/G8jm9zP5Shp3xw98GCxHdG8C90BVeoM7SFrWoLhfZ00gy1Qqn2QHdgGT7eVSYDX3d\n\tlpF1+rNKkn+y84zD/nazXf8RovZfhOodLg9/6vI/5A+CsLpAg/iAvSLVG3V+Sqekjw\n\tTNgQZ2CPrlIpA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689087268;\n\tbh=XXNI4cG4adUNigCekmhKb56OgZBJ8wJwP/Tovk+qPTA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=GKQQXQ7FulljTEzIQDJU/e5Ab2iHwU34BGKIc5OnouD8ihZtWFOjGr4Edg5IsRMMW\n\trprMZoUGDdlbPDymfCLFle6ZvXK1jRrK3l9Wu+ifOZFIELB/NmQ18NaF4CFSmHzoCp\n\tl3ih3ZIWe7hnFmJs4Hed5RXcIWkYqJxoNd30BSe4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GKQQXQ7F\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 11 Jul 2023 15:55:13 +0100", "Message-Id": "<20230711145513.714742-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] README: Add unit tests instructions", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Cc": "William Salmon <pointswaves@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The unit tests require kernel modules to be loaded to support the\nvirtual test cameras. Add notes to the readme to highlight that it can\nbe done, and what kernel configurations are required.\n\nSuggested-by: William Salmon <pointswaves@gmail.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nv2:\n - Reword small fixes from Laurent\n - Move to contributing.rst\n\n Documentation/contributing.rst | 41 ++++++++++++++++++++++++++++++++++\n 1 file changed, 41 insertions(+)", "diff": "diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\nindex 2f0b4921f7e6..27c77558a6e6 100644\n--- a/Documentation/contributing.rst\n+++ b/Documentation/contributing.rst\n@@ -59,6 +59,47 @@ uses `Doxygen`_. Please make sure to document all code during development.\n .. _Sphinx: https://www.sphinx-doc.org\n .. _Doxygen: https://www.doxygen.nl\n \n+Running the unit tests\n+----------------------\n+\n+When submitting patches, it is recommended to run the unit tests. The unit\n+tests rely on kernel drivers which produce virtual devices. These can be either\n+built into the kernel, or provided as modules (=y or =m):\n+\n+.. code::\n+\n+ CONFIG_MEDIA_TEST_SUPPORT=y\n+ CONFIG_V4L_TEST_DRIVERS=y\n+\n+ CONFIG_VIDEO_VIM2M=m\n+ CONFIG_VIDEO_VIMC=m\n+ CONFIG_VIDEO_VIVID=m\n+\n+If the kernel provides the test drivers as modules, they need to be loaded\n+before running the tests:\n+\n+.. code::\n+\n+ sudo modprobe vimc\n+ sudo modprobe vivid\n+ sudo modprobe vim2m\n+\n+Make sure your build configuration has tests enabled by running the following\n+in the build directory:\n+\n+.. code::\n+\n+ meson configure -Dtest=true\n+\n+Enabling 'test=true' will implicitly add the VIMC test pipeline handler to the\n+build configuration.\n+\n+Then the tests can be run with:\n+\n+.. code::\n+\n+ ninja -C build test\n+\n Submitting Patches\n ------------------\n \n", "prefixes": [ "libcamera-devel", "v2" ] }