Patch Detail
Show a patch.
GET /api/patches/18804/?format=api
{ "id": 18804, "url": "https://patchwork.libcamera.org/api/patches/18804/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18804/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230710173146.4287-1-kieran.bingham@ideasonboard.com>", "date": "2023-07-10T17:31:46", "name": "[libcamera-devel] DNI: utils: checkstyle.py: Initialise trailers", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "2f75ff0e9fef7ce5568e857cbf2915c9915c3d36", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18804/mbox/", "series": [ { "id": 3965, "url": "https://patchwork.libcamera.org/api/series/3965/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3965", "date": "2023-07-10T17:31:46", "name": "[libcamera-devel] DNI: utils: checkstyle.py: Initialise trailers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3965/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18804/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18804/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68695BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 Jul 2023 17:31:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D5FF628BF;\n\tMon, 10 Jul 2023 19:31:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D421760384\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jul 2023 19:31:55 +0200 (CEST)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 65307BEB;\n\tMon, 10 Jul 2023 19:31:07 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689010317;\n\tbh=3oro3YuTbBTosOH3fRf95lpmTr9W6BmKT18BkGWN9JY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wZawVaQNx5a6BbvK3JJUmlJorCsdmvXGAGZdgPu99Fvv34vBJilnxWiyeMGa3usOu\n\tOFdlvQm7vSMEYhSbeMqX5VNn0y6QLo4iQ/FHHEE6cT/4E/AuDWHO8BD58lKzOudZzD\n\tzrGuzZp1BxCp5p8OrEIcLV0IDhVZRktNq5QvgqwrH7KDFPpS2ecBMx/n0soramIf+8\n\t6VwNuvsHHGJV2PUgkJl71vgOYsPPTJj3+HZqFlP+rC5pvkaBVwA3d6VMfGN2HIA+0W\n\t10BRvqaNWZZPrrgCO8F1OlEfZvsTtDHXj8Ur31fEIOERy8ePSREFnUhQe0jy6NsWua\n\t+aQ40lJDJqPJw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689010267;\n\tbh=3oro3YuTbBTosOH3fRf95lpmTr9W6BmKT18BkGWN9JY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=K1wGNP9HyiBCm+jqzA+l4h3s41knuxN8pyjyw379hG4QpJ7ZQPzr5JFmW4PKB/VAv\n\tjgIiwesoYi5NeDhMcfbW5SD+ASMuLFL3HyvcJFE3akr0tb0kamKYRScDbY8l/Kap9W\n\tlO5Vzn7R7UGG/H3bQTJZ38o6yxmFbjM63ydQ28Bc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"K1wGNP9H\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 10 Jul 2023 18:31:46 +0100", "Message-Id": "<20230710173146.4287-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230612224751.4437-5-laurent.pinchart@ideasonboard.com>", "References": "<20230612224751.4437-5-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] DNI: utils: checkstyle.py: Initialise\n\ttrailers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The commit trailers are checked as part of processing the commit message\nwith the newly introduced TrailersChecker.\n\nThis relies on the trailers property being correctly exposed by the\nCommit object, and is implemented for the base Commit.\n\nEnsure it's initialised for all Commits.\n\nThis is a temporary solution, as it doesn't solve for Amended commits.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nHi Naush,\n\nThis will solve your issue in the short term - but I'm trying to make a\nproper fix that will also still do the trailer checks for Amended\ncommits, but not Staged commits.\n\n utils/checkstyle.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 8242314c1bb5..18a68d2cf33c 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -206,6 +206,7 @@ class CommitFile:\n class Commit:\n def __init__(self, commit):\n self.commit = commit\n+ self._trailers = []\n self._parse()\n \n def _parse(self):\n@@ -217,7 +218,6 @@ class Commit:\n \n self._title = lines[0]\n \n- self._trailers = []\n for index in range(1, len(lines)):\n line = lines[index]\n if not line:\n", "prefixes": [ "libcamera-devel" ] }