Patch Detail
Show a patch.
GET /api/patches/18778/?format=api
{ "id": 18778, "url": "https://patchwork.libcamera.org/api/patches/18778/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18778/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230704142435.3490823-2-kieran.bingham@ideasonboard.com>", "date": "2023-07-04T14:24:33", "name": "[libcamera-devel,v3,1/3] include: base: Do not install private headers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "19ea49f69773f2dbdeed3cde523a30d7629d5798", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18778/mbox/", "series": [ { "id": 3948, "url": "https://patchwork.libcamera.org/api/series/3948/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3948", "date": "2023-07-04T14:24:32", "name": "Use x.y soname versioning", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3948/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18778/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18778/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CDA0FC3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Jul 2023 14:24:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13215628C2;\n\tTue, 4 Jul 2023 16:24:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65AB761E38\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Jul 2023 16:24:39 +0200 (CEST)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18E2CD4A;\n\tTue, 4 Jul 2023 16:23:55 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688480682;\n\tbh=IOCD5at5KE0ydGLs8malvDjF3J5Qoq8u8JJmnuRtMQM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=XVFTq+n+HiUzM2Ab6HTHSooHdS/uIliqz6+XwfVBhwNsOFkFR+g4KvLWCJowhlHbg\n\tpW2UPOjnh7JmNox+2/CMs1S5UnXLIrxTc8sL1OgjKeIxRpCL/jlUJJ5Hl6z/igjTIR\n\tO/tyo1UNHUD/lVFoFLG3cwnR+jER2S7xb3urp0bQLRYEBuLy5pYKd1YdgJpu+S5/i4\n\t5tEpNQRWkTVnBrKpb4SzzlyFRYFkQkBMX9Vp07Ydg4Aqf7O48GxRh+mSoYTzi0a2TA\n\tvRR/DmJou3Ym8+0VWoJst0wd58gotbdRnUqeL8fFh3hsiE4Jbx3Kd7OyV1lM/EER3R\n\tbyQ18aGwf8K1A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688480635;\n\tbh=IOCD5at5KE0ydGLs8malvDjF3J5Qoq8u8JJmnuRtMQM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MQ9jOz7nWOqJ4RzWoq1bM4ZTbcrOp9Iom1flfCEnJ4erAOMjnClnYe/sklgGL3ftr\n\tuK237LPgb6nue8xFp+SsNObedffihtYoCi6qrialcpuZgt/pfBodChxAGSz8CzbYkq\n\trBzDX33rrjOnsS7p81BM0vRAH1GIhDwlmd3CBNoc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MQ9jOz7n\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 4 Jul 2023 15:24:33 +0100", "Message-Id": "<20230704142435.3490823-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230704142435.3490823-1-kieran.bingham@ideasonboard.com>", "References": "<20230704142435.3490823-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/3] include: base: Do not install\n\tprivate headers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Split the public and private headers from the base library and stop installing\nprivate headers as part of the install process.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/base/meson.build | 28 ++++++++++++++++++----------\n 1 file changed, 18 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\nindex 4410aba8181a..ee91bd1e0071 100644\n--- a/include/libcamera/base/meson.build\n+++ b/include/libcamera/base/meson.build\n@@ -2,31 +2,39 @@\n \n libcamera_base_include_dir = libcamera_include_dir / 'base'\n \n-libcamera_base_headers = files([\n- 'backtrace.h',\n+libcamera_base_public_headers = files([\n 'bound_method.h',\n 'class.h',\n 'compiler.h',\n+ 'flags.h',\n+ 'object.h',\n+ 'shared_fd.h',\n+ 'signal.h',\n+ 'span.h',\n+ 'thread_annotations.h',\n+ 'unique_fd.h',\n+])\n+\n+libcamera_base_private_headers = files([\n+ 'backtrace.h',\n 'event_dispatcher.h',\n 'event_dispatcher_poll.h',\n 'event_notifier.h',\n 'file.h',\n- 'flags.h',\n 'log.h',\n 'message.h',\n 'mutex.h',\n- 'object.h',\n 'private.h',\n 'semaphore.h',\n- 'shared_fd.h',\n- 'signal.h',\n- 'span.h',\n 'thread.h',\n- 'thread_annotations.h',\n 'timer.h',\n- 'unique_fd.h',\n 'utils.h',\n ])\n \n-install_headers(libcamera_base_headers,\n+libcamera_base_headers = [\n+ libcamera_base_public_headers,\n+ libcamera_base_private_headers,\n+]\n+\n+install_headers(libcamera_base_public_headers,\n subdir: libcamera_base_include_dir)\n", "prefixes": [ "libcamera-devel", "v3", "1/3" ] }