Patch Detail
Show a patch.
GET /api/patches/18772/?format=api
{ "id": 18772, "url": "https://patchwork.libcamera.org/api/patches/18772/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18772/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230630120303.33023-4-umang.jain@ideasonboard.com>", "date": "2023-06-30T12:03:01", "name": "[libcamera-devel,RFC,3/5] ipa: rpi: cam_helper_imx708: Only pass embedded buffer in parseEmbeddedData()", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "1daa041d679cd111d19e3d2e98682fa33259de49", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18772/mbox/", "series": [ { "id": 3945, "url": "https://patchwork.libcamera.org/api/series/3945/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3945", "date": "2023-06-30T12:02:58", "name": "ipa: rpi: CamHelper improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3945/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18772/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18772/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18451C32AA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Jun 2023 12:03:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82407628CC;\n\tFri, 30 Jun 2023 14:03:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 503DC628C1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Jun 2023 14:03:09 +0200 (CEST)", "from umang.jainideasonboard.com.praguecc.cz (unknown\n\t[193.85.242.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD54931FA;\n\tFri, 30 Jun 2023 14:02:27 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688126593;\n\tbh=kt9qEOgLDzU0HrWp4M2ICglT7zLFIrNI6z7PVRwL/64=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=MRiBE9LG0EjEKzKgj2RsznCoLkFX0Ht9SYwQP7Q+ocK0aKu0NdmJehFL3NLscQ0I9\n\tqg3PbiAr3hqsropyk4Rb6A2LITqPRPClX1ObA4Gc+MYuUVfIZm+Wt+n3DcUDpY9nXt\n\tTJa9T0XEDetvaj+bgCfFNS3tM3wJ4shShHvFSz8Vh8BMesXkNaQQeSFbmhG4VvWzMt\n\tQGdusc+3PnZyN4l64kFE3ZBASIWxqyD/DhA3eWMstBc8gBUfZxastf5SiX7MF6vEzx\n\tf2fdCsXj0D9DjjjjPG+resffdm94ojc7JoyRWrW0aTPCVElzMsKO2H3UPTZSANIZnI\n\tNSq6QKrEKQvGw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688126548;\n\tbh=kt9qEOgLDzU0HrWp4M2ICglT7zLFIrNI6z7PVRwL/64=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NXXiKEOv601tP9ADy+oGDnuaVBFRyYG5NaFdYQ4Ks0df80B0dXEvXxxYY52nOsZVY\n\tUtXhloRthDtHLJpp0iAB72K3Yg7bjS2OJ08sJQg/DF62zkKbOEwT5UJ7W+zXBmsJ4x\n\t7jQIUYej3sKcAp9+5tVS7U4KZLZazf4vJEqGgIRQ=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NXXiKEOv\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Jun 2023 14:03:01 +0200", "Message-Id": "<20230630120303.33023-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230630120303.33023-1-umang.jain@ideasonboard.com>", "References": "<20230630120303.33023-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 3/5] ipa: rpi: cam_helper_imx708: Only\n\tpass embedded buffer in parseEmbeddedData()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Only the embedded data section should be passed while parsing the\nembedded data through parseEmbeddedData().\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\nindex d0382d63..6c3b54ed 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n@@ -40,6 +40,8 @@ constexpr std::initializer_list<uint32_t> registerList =\n \t{ expHiReg, expLoReg, gainHiReg, gainLoReg, lineLengthHiReg,\n \t lineLengthLoReg, frameLengthHiReg, frameLengthLoReg, temperatureReg };\n \n+/* No. of lines of embedded data on IMX708. */\n+constexpr uint32_t embeddedDataLinesImx708 = 2;\n /* PDAF data is expect to occupy the third scanline of embedded data. */\n constexpr uint32_t pdafLineOffsetImx708 = 2;\n \n@@ -109,10 +111,13 @@ void CamHelperImx708::prepare(libcamera::Span<const uint8_t> buffer, Metadata &m\n \t\treturn;\n \t}\n \n-\tparseEmbeddedData(buffer, metadata);\n+\tsize_t bytesPerLine = (mode_.width * mode_.bitdepth) >> 3;\n+\n+\tlibcamera::Span<const uint8_t> embeddedData{ buffer.data(),\n+\t\t\t\t\t\t embeddedDataLinesImx708 * bytesPerLine };\n+\tparseEmbeddedData(embeddedData, metadata);\n \n \t/* Parse sensor-specific PDAF data. */\n-\tsize_t bytesPerLine = (mode_.width * mode_.bitdepth) >> 3;\n \tsize_t pdafDataOffset = pdafLineOffsetImx708 * bytesPerLine;\n \n \tif (buffer.size() > pdafDataOffset) {\n", "prefixes": [ "libcamera-devel", "RFC", "3/5" ] }