Patch Detail
Show a patch.
GET /api/patches/18736/?format=api
{ "id": 18736, "url": "https://patchwork.libcamera.org/api/patches/18736/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18736/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230614162222.20943-1-robert.mader@collabora.com>", "date": "2023-06-14T16:21:53", "name": "[libcamera-devel] gstreamer: src: Send image-orientation tag", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "182d2385a18e3caf07feb88cdcfed278f0e5e6dd", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18736/mbox/", "series": [ { "id": 3924, "url": "https://patchwork.libcamera.org/api/series/3924/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3924", "date": "2023-06-14T16:21:53", "name": "[libcamera-devel] gstreamer: src: Send image-orientation tag", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3924/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18736/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18736/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09BACBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Jun 2023 16:22:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42BB361E4D;\n\tWed, 14 Jun 2023 18:22:53 +0200 (CEST)", "from madras.collabora.co.uk (madras.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54C0161E4A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Jun 2023 18:22:51 +0200 (CEST)", "from thinkpad-t460p.fritz.box (unknown\n\t[IPv6:2001:4090:a243:8015:93c:83c3:533:d433])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: rmader)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id D633F6606F52;\n\tWed, 14 Jun 2023 17:22:50 +0100 (BST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686759773;\n\tbh=EvgLNcsfi1kumBXgx++fm7GpEvviOWhaMyY/etDgtiE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=3kQ7lW8P3bg+o+wSlzxzgZ6sme3mrLTRxIfgTtoi0hEvMZJgUK+YMG/HlZa215gHb\n\tgVWF6GMFzTWIeJkcPnf+Ea5cm6syhFVZRffbsU5mZ3ciWyuea15maQnBX24Y/mQPtZ\n\tMSNjh9wBeWo4d8cdPEqT+Pg36L9k7bpzhW5EY/S24MNKUNvLJW+/4fjrdf5PB79Ete\n\t19E/q7DH8V6sI5mGMwj1VrWh5JLPmnKqaEhb8SLUofz0OJLSO6FWlQVFMQ0rQ12V9G\n\t3W5WmzMNJdyO9c3jROJAwy+xi9Ca++/BGs9af1rwj7sT/8ttjFZ9W0b/zFmr33qKbq\n\tHOujsHhvCi59g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1686759771;\n\tbh=EvgLNcsfi1kumBXgx++fm7GpEvviOWhaMyY/etDgtiE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=SSvSBxd8JeYKCTl57Q79ssoMTSRQRnhfKY9S6I4WXfSFIfJFwUCWM4e0Eh9JLNpOn\n\tqIDyrs35jFtRSR6WQmDhITZiqGmaEDQEu9PfDyzKvgWNc5ENJ2sc0CX5aMXclss9gz\n\t2hd5AVay0jyFzJpSltquG0C1Wrl+T7ZLTLlhlqSBtXMEwyIbO0qc4QIyri+zPk1IRz\n\tHRtCg8tfcRhaK/6wN+Tac4w/gZ7dq9KiW/tEGyDaTO/3mxN7lfAcDDSrKg8w+YzPOQ\n\t7VLxAaMVNYq8R4hWpzNiRXKb/iWgTorPVpbE3nC9z8A8J3txUTYalFK9KHJAUwxtdn\n\tq7rBK6ytE7tfw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"SSvSBxd8\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 14 Jun 2023 18:21:53 +0200", "Message-ID": "<20230614162222.20943-1-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.41.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] gstreamer: src: Send image-orientation tag", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Robert Mader via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Robert Mader <robert.mader@collabora.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Matching the validated Transform of the configuration, if the transform\nis not the Identity. As we currently always request a configuration with\n`Identity` transform, this can be the case if camera has a rotation\nproperty (90/180/270 degree) and the sensor can't do rotation in\nquestion. Sending the orientation-tag allows downstream elements to\ncompensate accordingly.\n\nThis matches current pipewiresrc behavior and can be tested with e.g.:\ngst-launch-1.0 libcamerasrc ! videoconvert ! videoflip video-direction=auto ! gtksink\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 24 ++++++++++++++++++++++++\n src/gstreamer/gstlibcamera-utils.h | 3 +++\n src/gstreamer/gstlibcamerasrc.cpp | 11 +++++++++++\n 3 files changed, 38 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 750ec351..3bfbc354 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -553,3 +553,27 @@ gst_libcamera_get_camera_manager(int &ret)\n \n \treturn cm;\n }\n+\n+const char *\n+gst_libcamera_transform_to_tag_string(libcamera::Transform transform)\n+{\n+\tswitch (transform) {\n+\tcase Transform::Rot90:\n+\t\treturn \"rotate-90\";\n+\tcase Transform::Rot180:\n+\t\treturn \"rotate-180\";\n+\tcase Transform::Rot270:\n+\t\treturn \"rotate-270\";\n+\tcase Transform::HFlip:\n+\t\treturn \"flip-rotate-0\";\n+\tcase Transform::VFlip:\n+\t\treturn \"flip-rotate-180\";\n+\tcase Transform::Transpose:\n+\t\treturn \"flip-rotate-270\";\n+\tcase Transform::Rot180Transpose:\n+\t\treturn \"flip-rotate-90\";\n+\tcase Transform::Identity:\n+\tdefault:\n+\t\treturn \"rotate-0\";\n+\t}\n+}\ndiff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex fd304a8b..499533c4 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -11,6 +11,7 @@\n #include <libcamera/camera_manager.h>\n #include <libcamera/controls.h>\n #include <libcamera/stream.h>\n+#include <libcamera/transform.h>\n \n #include <gst/gst.h>\n #include <gst/video/video.h>\n@@ -30,6 +31,8 @@ gboolean gst_task_resume(GstTask *task);\n #endif\n std::shared_ptr<libcamera::CameraManager> gst_libcamera_get_camera_manager(int &ret);\n \n+const char *gst_libcamera_transform_to_tag_string(libcamera::Transform transform);\n+\n /**\n * \\class GLibLocker\n * \\brief A simple scoped mutex locker for GMutex\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex a10cbd4f..b41f52d7 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -461,6 +461,7 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \tGLibRecLocker lock(&self->stream_lock);\n \tGstLibcameraSrcState *state = self->state;\n \tGstFlowReturn flow_ret = GST_FLOW_OK;\n+\tconst char *transform_tag;\n \tgint ret;\n \n \tg_autoptr(GstStructure) element_caps = gst_structure_new_empty(\"caps\");\n@@ -519,6 +520,16 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \t\tgoto done;\n \t}\n \n+\ttransform_tag = gst_libcamera_transform_to_tag_string(state->config_->transform);\n+\tfor (gsize i = 0; i < state->srcpads_.size(); i++) {\n+\t\tGstPad *srcpad = state->srcpads_[i];\n+\t\tGstEvent *tag_event;\n+\n+\t\ttag_event = gst_event_new_tag(gst_tag_list_new(GST_TAG_IMAGE_ORIENTATION,\n+\t\t\t\t\t\t\t transform_tag, NULL));\n+\t\tgst_pad_push_event(srcpad, tag_event);\n+\t}\n+\n \tret = state->cam_->configure(state->config_.get());\n \tif (ret) {\n \t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n", "prefixes": [ "libcamera-devel" ] }