Patch Detail
Show a patch.
GET /api/patches/18725/?format=api
{ "id": 18725, "url": "https://patchwork.libcamera.org/api/patches/18725/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18725/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230612153934.5618-1-hdegoede@redhat.com>", "date": "2023-06-12T15:39:34", "name": "[libcamera-devel] utils: ipu3-capture.sh: Fix the script to work with recent media-ctl versions", "commit_ref": "c49958d0b456619c32a04d074f592cc1665a24b5", "pull_url": null, "state": "accepted", "archived": false, "hash": "502dbb8ca07b9427fd34a057e8354e50d4a3372b", "submitter": { "id": 102, "url": "https://patchwork.libcamera.org/api/people/102/?format=api", "name": "Hans de Goede", "email": "hdegoede@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18725/mbox/", "series": [ { "id": 3919, "url": "https://patchwork.libcamera.org/api/series/3919/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3919", "date": "2023-06-12T15:39:34", "name": "[libcamera-devel] utils: ipu3-capture.sh: Fix the script to work with recent media-ctl versions", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3919/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18725/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18725/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9EFAC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Jun 2023 15:39:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4466F61E4B;\n\tMon, 12 Jun 2023 17:39:42 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9BE261E4A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Jun 2023 17:39:40 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n\t[66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-626-dkDrDbZxNuuauO5KSIiK4Q-1; Mon, 12 Jun 2023 11:39:36 -0400", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48BF83823A03;\n\tMon, 12 Jun 2023 15:39:36 +0000 (UTC)", "from shalem.redhat.com (unknown [10.39.192.252])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A13BCC1604C;\n\tMon, 12 Jun 2023 15:39:35 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686584382;\n\tbh=m7vIRErT+TuQg3kCoah3Cz6fr8Ghx8pMtKscafzTPrY=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=MDQLYSS+mF+siVIlKJB1YQxHpYzbzeEJlzV6LgxdUXvgyt3c7tFAkR15f3GiZQ5gb\n\tPNqoMC3LCQfMSVv4A6ctXkE8tS4EIp0I/NlMFEhTDIzDmEU+MCF5GjkcbmHTBgx3xT\n\til4rK/cdvETaxewGW6YTo7enRRjt6gUUuFE2Ky/DwOXoihQXp5IRFtto7S/zpp4ONR\n\tpo5GbZZCmcoyf0Abh9FSeFDWzxPeUQRZBgv4RtELr8MXk09bhjowpv0xR2cyV1hEXP\n\t2yp+Bi2uisQIu/5Pf0sA0Qe0+LhPdZUn1Nu5g0fj1Acp7g1HNk2dj33X+0GR2djfhB\n\txdZlFIuZHRtEQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1686584379;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=gvVeaQq+qdPoJbG5swfGaWLwP/ixixeO6QBdjrUztNQ=;\n\tb=iXS8OErLTCtwK3RB46pWYm2EEcgJpQPfZO33UNRqg4RnmX3nizRsbRXxOLTp63+gIU4CvH\n\tYtxLtjjEOr5RSnyc3RyBLY4K9E8JF59XZK9AA/sejh+AVhehJ23Hl0vrf57DtPtj0z3OKP\n\tQ5Kpc4+9LcAuKua7rQ1DZ/xJeDg8e98=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"iXS8OErL\"; \n\tdkim-atps=neutral", "X-MC-Unique": "dkDrDbZxNuuauO5KSIiK4Q-1", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 12 Jun 2023 17:39:34 +0200", "Message-Id": "<20230612153934.5618-1-hdegoede@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.8", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "Subject": "[libcamera-devel] [PATCH] utils: ipu3-capture.sh: Fix the script to\n\twork with recent media-ctl versions", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Hans de Goede via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Hans de Goede <hdegoede@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Recent media-ctl versions include the framerate in the fmt property output:\n\n- entity 37: ov5693 4-0036 (1 pad, 1 link)\n type V4L2 subdev subtype Sensor flags 0\n device node name /dev/v4l-subdev6\n\tpad0: Source\n\t\t[fmt:SBGGR10_1X10/2592x1944@1/30\n\t\t crop.bounds:(16,6)/2592x1944\n\t\t crop:(16,6)/2592x1944]\n\t\t-> \"ipu3-csi2 1\":0 [ENABLED]\n\nThis resulted in $sensor_size getting set to: \"2592x1944@1 30\", which\ncauses the script to fail.\n\nFix this by:\n\n1. Replacing the gsub() to remove the '/' between e.g. SBGGR10_1X10\nand 2592x1944 with a sub() so that only that first '/' gets replaced\n(resulting in a $sensor_size of \"2592x1944@1/30\" instead).\n\n2. Adding a new sub() to remove the @1/30 suffix.\n\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\n---\n utils/ipu3/ipu3-capture.sh | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/utils/ipu3/ipu3-capture.sh b/utils/ipu3/ipu3-capture.sh\nindex ba6147b4..9294d025 100755\n--- a/utils/ipu3/ipu3-capture.sh\n+++ b/utils/ipu3/ipu3-capture.sh\n@@ -63,7 +63,8 @@ parse_pipeline() {\n \t\tif (sensor) {\n \t\t\tgsub(\\\".*fmt:\\\", \\\"\\\");\n \t\t\tgsub(\\\"[] ].*\\\", \\\"\\\");\n-\t\t\tgsub(\\\"/\\\", \\\" \\\");\n+\t\t\tsub(\\\"/\\\", \\\" \\\");\n+\t\t\tsub(\\\"@[0-9]+/[0-9]+\\\", \\\"\\\");\n \t\t\tformat=\\$0;\n \t\t}\n \t}\n", "prefixes": [ "libcamera-devel" ] }