Patch Detail
Show a patch.
GET /api/patches/1872/?format=api
{ "id": 1872, "url": "https://patchwork.libcamera.org/api/patches/1872/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1872/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190828011710.32128-8-niklas.soderlund@ragnatech.se>", "date": "2019-08-28T01:17:04", "name": "[libcamera-devel,07/13] libcamera: request: Add RequestData", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d7358c6619601eb781184b8e1d08ff1c779a3826", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1872/mbox/", "series": [ { "id": 470, "url": "https://patchwork.libcamera.org/api/series/470/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=470", "date": "2019-08-28T01:16:57", "name": "libcamera: ipa: Add basic IPA support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/470/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1872/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1872/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D73460E38\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Aug 2019 03:17:46 +0200 (CEST)", "from bismarck.berto.se (unknown [95.195.154.80])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 9a8a90d7-c931-11e9-bdc3-005056917a89;\n\tWed, 28 Aug 2019 03:17:30 +0200 (CEST)" ], "X-Halon-ID": "9a8a90d7-c931-11e9-bdc3-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 28 Aug 2019 03:17:04 +0200", "Message-Id": "<20190828011710.32128-8-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.22.1", "In-Reply-To": "<20190828011710.32128-1-niklas.soderlund@ragnatech.se>", "References": "<20190828011710.32128-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 07/13] libcamera: request: Add RequestData", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 28 Aug 2019 01:17:46 -0000" }, "content": "Add a RequestData pointer to the Request class, this is intended to be\nused by pipeline handlers while handling the request and is invalid\noutside the pipeline handler context.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/request.h | 5 +++++\n src/libcamera/request.cpp | 10 +++++++++-\n 2 files changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 9edf1cedc054014f..570924c5ef5e2425 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -21,6 +21,9 @@ class Buffer;\n class Camera;\n class Stream;\n \n+class RequestData\n+{\n+};\n \n class Request\n {\n@@ -46,6 +49,8 @@ public:\n \n \tbool hasPendingBuffers() const { return !pending_.empty(); }\n \n+\tRequestData *data;\n+\n private:\n \tfriend class Camera;\n \tfriend class PipelineHandler;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex ee2158fc7a9cf0b9..4d7bf177534267ac 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -55,7 +55,7 @@ LOG_DEFINE_CATEGORY(Request)\n *\n */\n Request::Request(Camera *camera, uint64_t cookie)\n-\t: camera_(camera), controls_(camera), cookie_(cookie),\n+\t: data(nullptr), camera_(camera), controls_(camera), cookie_(cookie),\n \t status_(RequestPending), cancelled_(false)\n {\n }\n@@ -178,6 +178,14 @@ Buffer *Request::findBuffer(Stream *stream) const\n * otherwise\n */\n \n+/**\n+ * \\var Request::data\n+ * \\brief Pipeline handler specific data\n+ *\n+ * Pipeline handlers may associate private data with with an request that\n+ * is valid for the requests liftime inside the pipeline handler.\n+ */\n+\n /**\n * \\brief Validate the request and prepare it for the completion handler\n *\n", "prefixes": [ "libcamera-devel", "07/13" ] }