Patch Detail
Show a patch.
GET /api/patches/18719/?format=api
{ "id": 18719, "url": "https://patchwork.libcamera.org/api/patches/18719/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18719/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230607114807.18897-1-naush@raspberrypi.com>", "date": "2023-06-07T11:48:07", "name": "[libcamera-devel] ipa: rpi: tunings: Add missing short and long exposure profiles", "commit_ref": "c6ff999053cef89813d6b2f4601b9ec5d2590167", "pull_url": null, "state": "accepted", "archived": false, "hash": "74f4c8ab4630c2c42824671a37e44db20dc914bd", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18719/mbox/", "series": [ { "id": 3913, "url": "https://patchwork.libcamera.org/api/series/3913/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3913", "date": "2023-06-07T11:48:07", "name": "[libcamera-devel] ipa: rpi: tunings: Add missing short and long exposure profiles", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3913/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18719/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18719/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05690C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Jun 2023 11:48:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D32E62890;\n\tWed, 7 Jun 2023 13:48:20 +0200 (CEST)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D880062890\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Jun 2023 13:48:18 +0200 (CEST)", "by mail-wr1-x436.google.com with SMTP id\n\tffacd0b85a97d-30b023b0068so413161f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 Jun 2023 04:48:18 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\th14-20020a5d504e000000b00300aee6c9cesm15380708wrt.20.2023.06.07.04.48.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Jun 2023 04:48:17 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686138500;\n\tbh=moh4VklmNygkmTBF9QB0vLTqrgiK2725Ix3uVxU/kWM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=H9iSI8XMFqHn/jQNjikn8IoFSIHuIFDu8WVY0GUtAqdNhVtRRK5jJbT1BkUj8dLSM\n\tP4JFflCvfg+sR9ItVp6LEu/uRg6hwGXDFS+J+Knd/lLp7nto/yj5mxSXDGvfG0Qwvs\n\t43aPCbY0SulI1N/9K6ssZ7Os9qB5mzGifdDkj/SP5tdTscFeQeazkJVExIP88D7m+D\n\tLD+1beMzDn/fktharrBwLR+Mb5kIzojAntcRy3ZqiI+pz+y8/WulJDYWCAvpQpDrpu\n\tmlk+M2DFF6yfOVjoHTjqYHP07eZh2yAGedWFXgur/zeed6IMAWVkwQfzCwExHX7afJ\n\tuphV3nEcAh6AQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1686138498; x=1688730498;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=l3juDog/JTXn5rxzV7uSuxm+rfHRiF4KhWtJDyuIB6g=;\n\tb=fvCoxD+XB4dnGb9mzREPt2KtjP/VsbUbghFY8phE5p4N6JZnSX1RqS+c6+i3q49644\n\tQ2xLP66amQ3D9kW4tbXh2ovFVn5qzbMNadKj0qqNvkD2l4SvG2d+EsJA7g/U3Wx6C7hm\n\t3NlKQBuD+pKd5PhfGuIW6yTT9yYDAgDWtIw6nTytpGfNMogUkbpZDqXFEzEJrH+J34YQ\n\tsRrZPjTrWZDUPbN9oGo5GJ48IYso7A9CncIwJ9IU3XzzAXFVaGrnLCOczD3XvpVarBPr\n\tn0S88uXPpL4f0/BaBOzPV5siThTksnAYrbL6T0RRfiJ8EBZq2z2EmkmLtQunALCSi07B\n\t9Rgg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"fvCoxD+X\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1686138498; x=1688730498;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=l3juDog/JTXn5rxzV7uSuxm+rfHRiF4KhWtJDyuIB6g=;\n\tb=H7C64HXrMSSjVYT1vHgvq5Pk4vbxVbVIDieRXKrZY54JiTECyPP85QxL9o2R51gp3S\n\tfnKCvSjweezbRB42RT3UmaT9RGuITiFi2r8KM6OwdyjuJIYCbWJCqtiPeYoRfORaUkQn\n\tapsCO7k1oTj4+Ecv+kaLpprxbjaPmAIuMsY35YjgEf5Jv3DigIML/5Gv4wQOO7bZez5v\n\tml/6fjFK+oh+x072KKLTL586hXsdi3zfKQLlCOvCPYyY15PuR1y8Sr4rpJlrQbbWrIBQ\n\tEJZsWkd+oz3d3PQQmBQECf778ID4aV/msGDblHv46QaIq6MYJOBG37ddn+oaIwfYnq3c\n\teiIw==", "X-Gm-Message-State": "AC+VfDyEZaPyYIJ4CRwJfMc+x7E38N1S+VxlrUwBqrtcWP4nNxuAf10V\n\ttNVGp2veqgW5C3gNumqrRLndo9y44nndLK/6nfgEYg==", "X-Google-Smtp-Source": "ACHHUZ4PLES+QVqL55DpnCaV4J2ufKGsrSy7Q/W7XUOX5+wtMUvtB430UXijgiOT7IquK1i0Im1BGA==", "X-Received": "by 2002:adf:deca:0:b0:307:7d1a:20fd with SMTP id\n\ti10-20020adfdeca000000b003077d1a20fdmr3732176wrn.12.1686138498208; \n\tWed, 07 Jun 2023 04:48:18 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 7 Jun 2023 12:48:07 +0100", "Message-Id": "<20230607114807.18897-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230607100054.4576-2-naush@raspberrypi.com>", "References": "<20230607100054.4576-2-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: rpi: tunings: Add missing short and\n\tlong exposure profiles", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Some sensor tuning files were missing the short and/or long exposure\nmode profiles. Add the missing items to the relevant files.\n\nAs a drive-by, rename the \"sport\" exposure profile to \"short\" for the\nIMX290 tuning.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/rpi/vc4/data/imx290.json | 7 ++++++-\n src/ipa/rpi/vc4/data/imx296.json | 5 +++++\n src/ipa/rpi/vc4/data/imx296_mono.json | 5 +++++\n src/ipa/rpi/vc4/data/imx378.json | 5 +++++\n src/ipa/rpi/vc4/data/imx519.json | 5 +++++\n src/ipa/rpi/vc4/data/imx708.json | 5 +++++\n src/ipa/rpi/vc4/data/imx708_noir.json | 5 +++++\n src/ipa/rpi/vc4/data/imx708_wide.json | 5 +++++\n src/ipa/rpi/vc4/data/imx708_wide_noir.json | 5 +++++\n src/ipa/rpi/vc4/data/ov9281_mono.json | 10 ++++++++++\n src/ipa/rpi/vc4/data/se327m12.json | 5 +++++\n src/ipa/rpi/vc4/data/uncalibrated.json | 10 ++++++++++\n 12 files changed, 71 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rpi/vc4/data/imx290.json b/src/ipa/rpi/vc4/data/imx290.json\nindex ace68d0ebf1c..8a7cadba38a2 100644\n--- a/src/ipa/rpi/vc4/data/imx290.json\n+++ b/src/ipa/rpi/vc4/data/imx290.json\n@@ -70,10 +70,15 @@\n \"shutter\": [ 10, 30000, 60000 ],\n \"gain\": [ 1.0, 2.0, 8.0 ]\n },\n- \"sport\":\n+ \"short\":\n {\n \"shutter\": [ 10, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx296.json b/src/ipa/rpi/vc4/data/imx296.json\nindex ae8722c46a85..9330d0a9c81f 100644\n--- a/src/ipa/rpi/vc4/data/imx296.json\n+++ b/src/ipa/rpi/vc4/data/imx296.json\n@@ -157,6 +157,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 30000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 8.0, 16.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json\nindex db020550d70e..955af43cccff 100644\n--- a/src/ipa/rpi/vc4/data/imx296_mono.json\n+++ b/src/ipa/rpi/vc4/data/imx296_mono.json\n@@ -60,6 +60,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx378.json b/src/ipa/rpi/vc4/data/imx378.json\nindex 8b4ed22504b5..f7b68011b634 100644\n--- a/src/ipa/rpi/vc4/data/imx378.json\n+++ b/src/ipa/rpi/vc4/data/imx378.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx519.json b/src/ipa/rpi/vc4/data/imx519.json\nindex 8ccfd3a631ff..1b0a77476aab 100644\n--- a/src/ipa/rpi/vc4/data/imx519.json\n+++ b/src/ipa/rpi/vc4/data/imx519.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx708.json b/src/ipa/rpi/vc4/data/imx708.json\nindex b9830a3bf692..6b26d0a19609 100644\n--- a/src/ipa/rpi/vc4/data/imx708.json\n+++ b/src/ipa/rpi/vc4/data/imx708.json\n@@ -165,6 +165,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx708_noir.json b/src/ipa/rpi/vc4/data/imx708_noir.json\nindex 075f70355cec..8d498153833b 100644\n--- a/src/ipa/rpi/vc4/data/imx708_noir.json\n+++ b/src/ipa/rpi/vc4/data/imx708_noir.json\n@@ -165,6 +165,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx708_wide.json b/src/ipa/rpi/vc4/data/imx708_wide.json\nindex b772efee3b96..14bc918e7823 100644\n--- a/src/ipa/rpi/vc4/data/imx708_wide.json\n+++ b/src/ipa/rpi/vc4/data/imx708_wide.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx708_wide_noir.json b/src/ipa/rpi/vc4/data/imx708_wide_noir.json\nindex c5f6b53dca7a..49442c0f9d81 100644\n--- a/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n+++ b/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/ov9281_mono.json b/src/ipa/rpi/vc4/data/ov9281_mono.json\nindex 37944c63ad92..2b7292ec7e20 100644\n--- a/src/ipa/rpi/vc4/data/ov9281_mono.json\n+++ b/src/ipa/rpi/vc4/data/ov9281_mono.json\n@@ -44,6 +44,16 @@\n {\n \"shutter\": [ 100, 15000, 30000, 60000, 120000 ],\n \"gain\": [ 1.0, 2.0, 3.0, 4.0, 8.0 ]\n+ },\n+ \"short\":\n+ {\n+ \"shutter\": [ 100, 5000, 10000, 20000, 30000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/se327m12.json b/src/ipa/rpi/vc4/data/se327m12.json\nindex ee69caea50c0..8552ed92bce6 100644\n--- a/src/ipa/rpi/vc4/data/se327m12.json\n+++ b/src/ipa/rpi/vc4/data/se327m12.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/uncalibrated.json b/src/ipa/rpi/vc4/data/uncalibrated.json\nindex 13eb3f177302..7654defa6dfe 100644\n--- a/src/ipa/rpi/vc4/data/uncalibrated.json\n+++ b/src/ipa/rpi/vc4/data/uncalibrated.json\n@@ -31,6 +31,16 @@\n {\n \"shutter\": [ 100, 15000, 30000, 60000, 120000 ],\n \"gain\": [ 1.0, 2.0, 3.0, 4.0, 6.0 ]\n+ },\n+ \"short\":\n+ {\n+ \"shutter\": [ 100, 5000, 10000, 20000, 30000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\n", "prefixes": [ "libcamera-devel" ] }