Patch Detail
Show a patch.
GET /api/patches/1868/?format=api
{ "id": 1868, "url": "https://patchwork.libcamera.org/api/patches/1868/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1868/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190828011710.32128-4-niklas.soderlund@ragnatech.se>", "date": "2019-08-28T01:17:00", "name": "[libcamera-devel,03/13] libcamera: pipeline: Add method to prepare buffer for IPA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "db1032349ecb0816830e7395f176836a644479bf", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1868/mbox/", "series": [ { "id": 470, "url": "https://patchwork.libcamera.org/api/series/470/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=470", "date": "2019-08-28T01:16:57", "name": "libcamera: ipa: Add basic IPA support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/470/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1868/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1868/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D53760C42\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Aug 2019 03:17:39 +0200 (CEST)", "from bismarck.berto.se (unknown [95.195.154.80])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 96621487-c931-11e9-bdc3-005056917a89;\n\tWed, 28 Aug 2019 03:17:23 +0200 (CEST)" ], "X-Halon-ID": "96621487-c931-11e9-bdc3-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 28 Aug 2019 03:17:00 +0200", "Message-Id": "<20190828011710.32128-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.22.1", "In-Reply-To": "<20190828011710.32128-1-niklas.soderlund@ragnatech.se>", "References": "<20190828011710.32128-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 03/13] libcamera: pipeline: Add method to\n\tprepare buffer for IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 28 Aug 2019 01:17:39 -0000" }, "content": "The pipeline handlers dealing with buffers outside the request coming\nfrom an application needs to prepare Buffer objects before they can be\nused by other the libcamera functions. For objects coming from the user\nthis is done by the Camera before the Buffers reach the pipeline\nhandler. Add a new method prepareInternalBuffer() to aid with this\npreparation.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/include/pipeline_handler.h | 2 ++\n src/libcamera/pipeline_handler.cpp | 18 ++++++++++++++++++\n 2 files changed, 20 insertions(+)", "diff": "diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex ffc7adb802215313..91d40ef40a465c4e 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -98,6 +98,8 @@ protected:\n \n \tCameraData *cameraData(const Camera *camera);\n \n+\tvoid prepareInternalBuffer(Buffer *buffer, Request *request,\n+\t\t\t\t BufferMemory *mem);\n \tCameraManager *manager_;\n \n private:\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 89b67806597728f9..766fd496306ece9c 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -484,6 +484,24 @@ void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n \tmedia->disconnected.connect(this, &PipelineHandler::mediaDeviceDisconnected);\n }\n \n+/**\n+ * \\brief Prepare buffer for internal usage by a pipeline handler\n+ * \\param[in,out] buffer The buffer to prepare\n+ * \\param[in] request The request to associate the \\a buffer with\n+ * \\param[in] mem The memory to associate the \\a buffer with\n+ *\n+ * Pipeline handlers creating internal buffers to facilitate data flow in the\n+ * pipeline need to prepare the buffers by setting up the buffer object state.\n+ * This function help pipeline handler implementations to perform this\n+ * preparation.\n+ */\n+void PipelineHandler::prepareInternalBuffer(Buffer *buffer, Request *request,\n+\t\t\t\t\t BufferMemory *mem)\n+{\n+\tbuffer->request_ = request;\n+\tbuffer->mem_ = mem;\n+}\n+\n /**\n * \\brief Slot for the MediaDevice disconnected signal\n */\n", "prefixes": [ "libcamera-devel", "03/13" ] }