Patch Detail
Show a patch.
GET /api/patches/18675/?format=api
{ "id": 18675, "url": "https://patchwork.libcamera.org/api/patches/18675/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18675/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230601095630.25443-2-naush@raspberrypi.com>", "date": "2023-06-01T09:56:28", "name": "[libcamera-devel,v1,1/3] libcamera: controls: Define a default lens position behaviour", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b7d5eb9f25c9faf543b9b3e16eeebf1bf0fc4cac", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18675/mbox/", "series": [ { "id": 3898, "url": "https://patchwork.libcamera.org/api/series/3898/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3898", "date": "2023-06-01T09:56:27", "name": "Default lens behaviour", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3898/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18675/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18675/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C18C3C328F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 1 Jun 2023 09:56:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3521C627CD;\n\tThu, 1 Jun 2023 11:56:35 +0200 (CEST)", "from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91E22626FA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 1 Jun 2023 11:56:32 +0200 (CEST)", "by mail-wr1-x433.google.com with SMTP id\n\tffacd0b85a97d-30aa76048fbso592524f8f.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 01 Jun 2023 02:56:32 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\th12-20020a5d6e0c000000b002ca864b807csm9889531wrz.0.2023.06.01.02.56.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 01 Jun 2023 02:56:31 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685613395;\n\tbh=S2puBFGwZ/w5QwcuK3963B+w3Ph36QunnZY4eLDbHlQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vM3SUk8W1TIKXhSbFHb7lrn47h0ESs5lkaF7yEYUdJr7KxmmM/gXIjxPXgy153M/e\n\t7QRXzuJqu84+2smpkDkac+Y9VLbCncfbQRkOBOyySjE6/Qr229M0jGJItu4uoymdw4\n\tApv+/krcHFciGELsuyltNDo1Orno+bCrz2AEqWgqS2b7bBSvT6roVVxd1RRVnPVKzU\n\tB6sPORqJnqrnGZf9EU6lKwR6E9hs9+yLuYPMM/SxiVlzsvhLmvA02ufl0+Y+pRebQU\n\t8CkckR6b4isK0jGuvcZJuplfnP4EgEvuRJUXucnUYp5ETUwwQVfhMTE6zQ180i6SJe\n\twPQ5SQ4Wuxzsw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1685613392; x=1688205392;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=99hTf1x62+87E/VKSOzixF+A/Fl9SJ0Rqk6/PYzjbbA=;\n\tb=jvygl4yvUNayVZsQuWSE8jBU+6bqyFTc3n7gDv3xdEB68BntvrS2Ry45pJgI0FA0TN\n\tfbsyQGb0hgbpAssrAnu8rrRy+uVkTezMXKxp1HOD09L+/ZqYa8PrZHlaaNufVr/K2TRN\n\tsqEwvt6hJ1oVrjCWRgPLRZgfvh4sqdQkUUFKrk4OeHN9X1ZF8KT77AHmN0z1UV4LthAW\n\ti98J7Ql7dLNzdf//zHg7CyJDi7JqgibunYTTM7gCs7An0uxFOdC+d+Df6p+qZVnAsJ0K\n\tH7sx0qMnHpLmYJUShfeoRzD9iRowTVKDQf6/TJly0HcOJaQJ9BDl551efySgfKS8diBm\n\tDyPA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"jvygl4yv\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1685613392; x=1688205392;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=99hTf1x62+87E/VKSOzixF+A/Fl9SJ0Rqk6/PYzjbbA=;\n\tb=jHvBzpobexzPX5j57g2Ezov69R0doZZmZJmqJpjkcz0NxckVRn3wUzKJ+2kEfeJswo\n\to0Fs8HntWcvaew8QEx3+vxGkU1dRmuOwlQOAb04JPaEyGfxRHY8ua7xdKSFx2fjfWLml\n\tLL6EHUNOykfsnHWaXeb+QKm7PYQJC2B/vATfJogHwYLnIZT1bS1MnU8assNZTTunfLv/\n\tbl3vV5EraKrKCnKSe2+/UjRrjsRMEtUyf+hV25qJ0hBzE18EPjJNU9FUwXegwTCcYFz2\n\tOS6+m5N8G0EYfzg9SqJOMVbsExoCMRjy60xKxunWkZKKuxykUqd1hjxc0dfenMPl9GI7\n\tRj4A==", "X-Gm-Message-State": "AC+VfDwGyptBogMMO+pjPtgU3v3hrTLSIbw/oBz0hGxTuiqH0J8diL3U\n\tGqoRZODJ16s5hIO4iNhM+hBe0YSRx7W5bTfjVHqB6g==", "X-Google-Smtp-Source": "ACHHUZ4DtJoMFgMv2atfqzdRKhETnL8VD3A5rCy1iFUWpg8AoU7Rk3JxmlspqEIzP9S2KvoDWjk4uA==", "X-Received": "by 2002:adf:e4c4:0:b0:309:3a1e:fc54 with SMTP id\n\tv4-20020adfe4c4000000b003093a1efc54mr1366679wrm.7.1685613392105; \n\tThu, 01 Jun 2023 02:56:32 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 1 Jun 2023 10:56:28 +0100", "Message-Id": "<20230601095630.25443-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230601095630.25443-1-naush@raspberrypi.com>", "References": "<20230601095630.25443-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Cc": "nick.hollinghurst@raspberrypi.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update the LensPosition control description to explicitly define a\nstartup/default behaviour.\n\nOn startup, the IPA will move the lens to the position given by the\ndefault value of the LensPosition control. Typically this would be the\nhyperfocal position of the lens.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex adea5f90acc5..f6dbfd6c0bf0 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -610,6 +610,11 @@ controls:\n sharp). The minimum will often be zero (meaning infinity), and the\n maximum value defines the closest focus position.\n \n+ On startup, the IPA will move the lens position to the default value of\n+ this control. This can be overridden by the application providing an\n+ alternative value though this control, or setting an appropriate AF mode\n+ with controls::AfMode.\n+\n \\todo Define a property to report the Hyperfocal distance of calibrated\n lenses.\n \n", "prefixes": [ "libcamera-devel", "v1", "1/3" ] }