Patch Detail
Show a patch.
GET /api/patches/18672/?format=api
{ "id": 18672, "url": "https://patchwork.libcamera.org/api/patches/18672/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18672/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230531143946.23571-2-naush@raspberrypi.com>", "date": "2023-05-31T14:39:45", "name": "[libcamera-devel,v1,1/2] pipeline: ipa: rpi: Flag if the sensor is a mono variant", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c1ea6ac733bd73f53a24736d1ab051f5ec94bfc9", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18672/mbox/", "series": [ { "id": 3897, "url": "https://patchwork.libcamera.org/api/series/3897/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3897", "date": "2023-05-31T14:39:44", "name": "Mono sensor improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3897/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18672/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18672/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C80DC32A2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 31 May 2023 14:39:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F93A6278F;\n\tWed, 31 May 2023 16:39:48 +0200 (CEST)", "from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A27F626FA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 31 May 2023 16:39:47 +0200 (CEST)", "by mail-wr1-x42a.google.com with SMTP id\n\tffacd0b85a97d-30aef0499b6so2653482f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 31 May 2023 07:39:47 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tbf3-20020a0560001cc300b00307b5376b2csm6950706wrb.90.2023.05.31.07.39.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 31 May 2023 07:39:46 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685543988;\n\tbh=xIPrrDCNBeF433N6Y5+8Zw/9QHYqun04ahmKZgclQzs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=nd8uT9Ul6ChBFlMacQMtlMNyErUtwIyTOrOcyWeuGB7rxuz6ifk08/ObCA95sdv8z\n\tB9og8QK3St400tMblHmOxrGXDwDlYCBX1HCadnqK76S3S2HlQYmE2XvWQ12xcs95JH\n\tj6YqASFWVnGvG1cAynrQHj2KeFw1xmcMb1TqM9fFy6D4jAlRQ+meVqthEpLAFz4JX7\n\tLAqHYZw5r5Wfru1TEuh+9mNEGZPqnciiRweOzHYShk+6119My/6zp5vUpbjN8cVejN\n\teQQ5EmInLZI88WB8YziiLuBF/83QanIeH5cmrqVDCYmCdg9A+uQrPcJZMvpqMYreaM\n\tpX9W5HYfoNvlw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1685543986; x=1688135986;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=tyXUDVu1LsN3DHz4TMrGFcmEle0ZihpV+mgI1mhlvL0=;\n\tb=mhvI7HpuCNfr7Drn96mVuc/Ul4HzPR9pSB586f85ePLa5gBdtHRXrClr3pEP7NDQ+B\n\t7lx6cjmAg1h/zUNAvRsTFwCF27Sd6qoxzxmCi3ccBkv65BsQUADEfnrLJ7Z26wtTwzKo\n\tYKBgdGbQercv1+YRv2AAAb0IhCNA9L84j6j+WGWotgexOszgEfEi9GmqbqiptVnCVKNg\n\tAP8phXJuGne0bymdPCvd41Cn/GAn4FyuTp65edMsDBVXFOTR8tJTAUQ2QBnmhl3VFmgg\n\tQ7oDpD04ykKKVOEpVtZ5kOTEcyaf4aLYuXiSyDy/XMgdCrMoBy3Y1T/AOM6JY+EDjv2g\n\tNVJA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"mhvI7Hpu\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1685543986; x=1688135986;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=tyXUDVu1LsN3DHz4TMrGFcmEle0ZihpV+mgI1mhlvL0=;\n\tb=KVQETYWodMkrOICUcZrriZir22NR/se9axHY6+9MCi0IiXwGzSrifKPJpp/L727WQ2\n\tbHxd5cbg7EDcl56Lx9CIkGP7sMhh6nsTjodO+wJJiQJOgJ5lQq7vGIlj52EXDSunP3de\n\tzdP1U+I4RsBm4B7ECNHSkTP++j0wfrAU3yvIFylzOTtjvnW6w0BqCw27xO0RKYIRMBRB\n\tcFE9yqbfH+m7rGeMtoV/HcQVq5x2ZH+rdSa29WSlBvMH/BBuiHzc6en4LVHR9DesnTa6\n\tXBhOTVIobs7Rwlszd2cLSo2fs/wP/N/bnoHdho1f832BMf4ej/qmzXx00b9FzQjR8879\n\tCasQ==", "X-Gm-Message-State": "AC+VfDxmh1Z37t2jIue4kh5KFKBfQKj8f0v22NR7fY0j4B1XqBTndKWg\n\tdPicB8MGAXCP3DteE2Ffr1v9EHD/CY/jh6YKrVAYPw==", "X-Google-Smtp-Source": "ACHHUZ7KqKghn1zA3Rte2pC1D0uXxJAut/a7G3RDD/uJ6fWoFdRZcNtUuh/lHycXDZrWsofWrJt1LQ==", "X-Received": "by 2002:a5d:5448:0:b0:30a:93ad:ab9f with SMTP id\n\tw8-20020a5d5448000000b0030a93adab9fmr3778456wrv.11.1685543986743; \n\tWed, 31 May 2023 07:39:46 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 31 May 2023 15:39:45 +0100", "Message-Id": "<20230531143946.23571-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230531143946.23571-1-naush@raspberrypi.com>", "References": "<20230531143946.23571-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 1/2] pipeline: ipa: rpi: Flag if the\n\tsensor is a mono variant", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a flag to the ipa->init() interface to indicate a mono sensor\nvariant. This flag will be used in a future commit to handle controls\nthat are invalid for mono sensors.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n include/libcamera/ipa/raspberrypi.mojom | 1 +\n src/ipa/rpi/common/ipa_base.cpp | 1 +\n src/ipa/rpi/common/ipa_base.h | 1 +\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 4 +++-\n 4 files changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/ipa/raspberrypi.mojom b/include/libcamera/ipa/raspberrypi.mojom\nindex ba786e647ca1..d35289ee6229 100644\n--- a/include/libcamera/ipa/raspberrypi.mojom\n+++ b/include/libcamera/ipa/raspberrypi.mojom\n@@ -21,6 +21,7 @@ struct SensorConfig {\n \n struct InitParams {\n \tbool lensPresent;\n+\tbool monoSensor;\n };\n \n struct InitResult {\ndiff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex db7a0eb3a1ca..150fe433d0df 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -139,6 +139,7 @@ int32_t IpaBase::init(const IPASettings &settings, const InitParams ¶ms, Ini\n \t}\n \n \tlensPresent_ = params.lensPresent;\n+\tmonoSensor_ = params.monoSensor;\n \n \tcontroller_.initialise();\n \ndiff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\nindex 6f9c46bb16b1..39d00760d012 100644\n--- a/src/ipa/rpi/common/ipa_base.h\n+++ b/src/ipa/rpi/common/ipa_base.h\n@@ -87,6 +87,7 @@ private:\n \tstd::map<unsigned int, MappedFrameBuffer> buffers_;\n \n \tbool lensPresent_;\n+\tbool monoSensor_;\n \tControlList libcameraMetadata_;\n \n \tstd::array<RPiController::Metadata, numMetadataContexts> rpiMetadata_;\ndiff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 3bb5ec531e4f..12698056cda1 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -1131,6 +1131,7 @@ int CameraData::loadPipelineConfiguration()\n int CameraData::loadIPA(ipa::RPi::InitResult *result)\n {\n \tipa_ = IPAManager::createIPA<ipa::RPi::IPAProxyRPi>(pipe(), 1, 1);\n+\tbool monoSensor = isMonoSensor(sensor_);\n \n \tif (!ipa_)\n \t\treturn -ENOENT;\n@@ -1143,7 +1144,7 @@ int CameraData::loadIPA(ipa::RPi::InitResult *result)\n \tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RPI_TUNING_FILE\");\n \tif (!configFromEnv || *configFromEnv == '\\0') {\n \t\tstd::string model = sensor_->model();\n-\t\tif (isMonoSensor(sensor_))\n+\t\tif (monoSensor)\n \t\t\tmodel += \"_mono\";\n \t\tconfigurationFile = ipa_->configurationFile(model + \".json\");\n \t} else {\n@@ -1154,6 +1155,7 @@ int CameraData::loadIPA(ipa::RPi::InitResult *result)\n \tipa::RPi::InitParams params;\n \n \tparams.lensPresent = !!sensor_->focusLens();\n+\tparams.monoSensor = monoSensor;\n \tint ret = platformInitIpa(params);\n \tif (ret)\n \t\treturn ret;\n", "prefixes": [ "libcamera-devel", "v1", "1/2" ] }