Patch Detail
Show a patch.
GET /api/patches/18587/?format=api
{ "id": 18587, "url": "https://patchwork.libcamera.org/api/patches/18587/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18587/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230503122035.32026-3-naush@raspberrypi.com>", "date": "2023-05-03T12:20:24", "name": "[libcamera-devel,02/13] libcamera: ipa: Remove character restriction on the IPA name", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0a96c5dacf93718067cbdf53798b30000909012e", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18587/mbox/", "series": [ { "id": 3863, "url": "https://patchwork.libcamera.org/api/series/3863/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3863", "date": "2023-05-03T12:20:22", "name": "Raspberry Pi: Code refactoring", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3863/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18587/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18587/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61E5CC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 3 May 2023 12:20:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59559633BE;\n\tWed, 3 May 2023 14:20:41 +0200 (CEST)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 02313633A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 May 2023 14:20:39 +0200 (CEST)", "by mail-wm1-x336.google.com with SMTP id\n\t5b1f17b1804b1-3f1738d0d4cso31404845e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 03 May 2023 05:20:39 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tf23-20020a7bcd17000000b003ee443bf0c7sm1736785wmj.16.2023.05.03.05.20.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 03 May 2023 05:20:38 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683116441;\n\tbh=SkuNolI9P2nCWUfWWA5jMlqkXgH+/QYppr/4bgET7hQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=oFa5y9at+4UbEGEvk1VrQ6GoABo345f2x1JoctiuS7Q4iR0a1tN8HvF/lswc5z7dQ\n\taXyVc88TlfP2ADogBthURnvpPLjdjJnC/VJoB7+4QlxVFSMrpSb4lWczg1+fBpVOL8\n\th9o51CFaRhQi2+yqlJww0CTMbIV7A1j1xksrzt9Kr3s7Paq+Aq9y82U05CmP3hDRR/\n\tCrBNQ9P9QWahx3sUIBNUulCFNq+EMK/0GYJ2H2eejEIGVtdylQ1bZYT4jb+lqJVovB\n\t7Q0rZ+f4gpeVJspE7UIPE7MJMHQkPeCb0h+3QyYNPB9676iJ+L4u6H+Fr8olSbl02v\n\tnMY4ECbycK6UQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1683116438; x=1685708438;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=AAwiLoEgkTyPRPryFHEiudlGVKZQEgFJz2H6YvPFE5s=;\n\tb=Bd1/nSPA7BrTzAnYQ75o3bih3Y1D9xqs5VKmRqd5AFjS79uMl1VgtdSD/Ma4+OjQ0G\n\tjWXNfoE2GWNxQrsOwH1BHaZV6lN2FKFBGkr+SybUpeBar069iagqqzdxa454zgI5kIzM\n\tuSnkAAdWieVIf662AYsFtoMxB1N8BwbyX7S45/qKzX6HdG8q7pmCbyVimENK2WYrAt6t\n\tdnbZax15hh8sRnJw7UVAT15TCFD8c8i1xMZEoQxMzJaVi06comJwsc7ULsnYlUgF14uO\n\trGtD4JC7rPvrc1LwznC1dVNkrL6pwlmZ7g1B+AP80ceROwZinbQqOavvOVN++JlLfkom\n\tKfiw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Bd1/nSPA\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1683116438; x=1685708438;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=AAwiLoEgkTyPRPryFHEiudlGVKZQEgFJz2H6YvPFE5s=;\n\tb=C63Wy2s83tP0OHkSJhbrDc/r39QcbtX5tShMTpVwEbuKpJp8BEmdOhUYbyarkkwie+\n\tY3x9QL5ACUT9DGJzkTSrtxLafb+HnlFxX8guJRdVNfWT87oMJ/jUZ7iX8x6stUFOgJnM\n\tNtJuN038/Kbfds709kxiVEGAFoHEKzK0PEH0aRavzYQftVnLLyfeQE6LKSzVsj0wc/y3\n\t4rnBFOdu5X98KeifvlrN31rL7GyUrUyYSBf9Pv81I+MgA5HUPk8h2dfACJGqY+MIn3BX\n\tEOCXvWwVYMPhYeYKLQfIlmnWMNLNZZ2tWl5R5lK623tVt5chMkdZ23QDfHgxrmlrBbx3\n\tQZCA==", "X-Gm-Message-State": "AC+VfDzuyJmRWx0M8pUTKli17h8u5NRqIvTPseA5XTDTuLAizFp9WTwu\n\tGOqij2JV0Hov08btbpwzLb1AFL6wp/NWFfUm5p2Reg==", "X-Google-Smtp-Source": "ACHHUZ6s8cC4kyDAs29ioGsmLvmPJntVFCkfwJNYXtkwYGBadIWcWfZBr92Rjgg4ec9j64r0SaUdNQ==", "X-Received": "by 2002:a7b:c047:0:b0:3f1:7a44:317c with SMTP id\n\tu7-20020a7bc047000000b003f17a44317cmr15154183wmc.24.1683116438440; \n\tWed, 03 May 2023 05:20:38 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 3 May 2023 13:20:24 +0100", "Message-Id": "<20230503122035.32026-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230503122035.32026-1-naush@raspberrypi.com>", "References": "<20230503122035.32026-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 02/13] libcamera: ipa: Remove character\n\trestriction on the IPA name", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the restriction on using the '/' character in the IPA name\nstring. This allows more flexibility in IPA directory structures where\ndifferent IPA modules might live in subdirectories under the usual\nsrc/ipa/<platform>/ top level directory.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/ipa_module.cpp | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex c152153c180f..3ca7074b3b58 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -225,9 +225,9 @@ Span<const uint8_t> elfLoadSymbol(Span<const uint8_t> elf, const char *symbol)\n * \\brief The name of the IPA module\n *\n * The name may be used to build file system paths to IPA-specific resources.\n- * It shall only contain printable characters, and may not contain '/', '*',\n- * '?' or '\\'. For IPA modules included in libcamera, it shall match the\n- * directory of the IPA module in the source tree.\n+ * It shall only contain printable characters, and may not contain '*', '?' or\n+ * '\\'. For IPA modules included in libcamera, it shall match the directory of\n+ * the IPA module in the source tree.\n *\n * \\todo Allow user to choose to isolate open source IPAs\n */\n@@ -304,9 +304,8 @@ int IPAModule::loadIPAModuleInfo()\n \tstd::string ipaName = info_.name;\n \tauto iter = std::find_if_not(ipaName.begin(), ipaName.end(),\n \t\t\t\t [](unsigned char c) -> bool {\n-\t\t\t\t\t return isprint(c) && c != '/' &&\n-\t\t\t\t\t\t c != '?' && c != '*' &&\n-\t\t\t\t\t\t c != '\\\\';\n+\t\t\t\t\t return isprint(c) && c != '?' &&\n+\t\t\t\t\t\t c != '*' && c != '\\\\';\n \t\t\t\t });\n \tif (iter != ipaName.end()) {\n \t\tLOG(IPAModule, Error)\n", "prefixes": [ "libcamera-devel", "02/13" ] }