Patch Detail
Show a patch.
GET /api/patches/18570/?format=api
{ "id": 18570, "url": "https://patchwork.libcamera.org/api/patches/18570/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18570/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230427144740.64075-5-jacopo.mondi@ideasonboard.com>", "date": "2023-04-27T14:47:38", "name": "[libcamera-devel,v3,4/6] libcamera: camera_sensor: Add tryFormat()", "commit_ref": "608af3127cd2be4540121cc16ee43b8bc4ac009d", "pull_url": null, "state": "accepted", "archived": false, "hash": "b6934529583457b6c87ba5667f716f206b0b0a30", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18570/mbox/", "series": [ { "id": 3852, "url": "https://patchwork.libcamera.org/api/series/3852/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3852", "date": "2023-04-27T14:47:34", "name": "libcamera: imx8-isi: Remove pixelformat-2-media-bus map", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3852/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18570/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18570/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46018C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Apr 2023 14:48:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 808EC627EF;\n\tThu, 27 Apr 2023 16:48:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4A3A627DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Apr 2023 16:48:00 +0200 (CEST)", "from uno.lan (unknown\n\t[IPv6:2001:b07:5d2e:52c9:1cf0:b3bc:c785:4625])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 798AE802;\n\tThu, 27 Apr 2023 16:47:48 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682606885;\n\tbh=e7YYOFwqw/JxN1vpxtRp7jZYRBWw7rMkfkQiS6aJu/o=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=VKDl+GiCdSfe5sfXNCICL8euUUbqk7gDZY2QC3fCJtA9bfj+W4RROH5NtoHhm3/UO\n\tUa/XrtKMagaSdj0rWXTBQe7T0VSdjc+5Qpxry36E0j7k+SYdcF41ZoC2eB5hb4gk/p\n\tQ8qMrtDTEtI6MR+XNoKyJfOL8jW+/9p9OsE5Jy4YcqSx7F68eTHVRr0gto2CckYO8a\n\tPHGW3zeyKLqvCKsLTh7kKfzgC1OS/WC2/+qDqKSb3vhh3iRVkPJhfW+2eSugLWCrqm\n\tGx8kevFo/KXDyY31M/u5lbyGBNyFZ/OGIdnh6x/AjdJNJnnFqj5sXnogzDv7WDmSp1\n\telAg4mILAabIQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682606868;\n\tbh=e7YYOFwqw/JxN1vpxtRp7jZYRBWw7rMkfkQiS6aJu/o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=r2LTdOQCYWzFPdFm31ebkMHKlMidtxQavz0TtS5jPP1xcU7OuXsl2FuOpDQx0KCsQ\n\tN1ua0Ubs1LTvUn9Ux8vYpai+zGnqsiUInnpKZV/rgPWMWgqJTEOL3iXC0rHhjdqsGP\n\thwPDlgz6+r4tP7TZsFFOUYYETW59FFtv3ojz+O+I=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r2LTdOQC\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 Apr 2023 16:47:38 +0200", "Message-Id": "<20230427144740.64075-5-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.0", "In-Reply-To": "<20230427144740.64075-1-jacopo.mondi@ideasonboard.com>", "References": "<20230427144740.64075-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 4/6] libcamera: camera_sensor: Add\n\ttryFormat()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a function to the CameraSensor class that allows to test a format\nwithout applying it to the subdevice and without modifying any control\nvalue associated with the camera sensor.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/camera_sensor.cpp | 17 +++++++++++++++++\n 2 files changed, 18 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 928c61af7f4e..02c77ab037da 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -56,6 +56,7 @@ public:\n \t\t\t\t const Size &size) const;\n \tint setFormat(V4L2SubdeviceFormat *format,\n \t\t Transform transform = Transform::Identity);\n+\tint tryFormat(V4L2SubdeviceFormat *format) const;\n \n \tconst ControlInfoMap &controls() const;\n \tControlList getControls(const std::vector<uint32_t> &ids);\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex e442b89dacd0..06f315210240 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -795,6 +795,23 @@ int CameraSensor::setFormat(V4L2SubdeviceFormat *format, Transform transform)\n \treturn 0;\n }\n \n+/**\n+ * \\brief Try the sensor output format\n+ * \\param[in] format The desired sensor output format\n+ *\n+ * The ranges of any controls associated with the sensor are not updated.\n+ *\n+ * \\todo Add support for Transform by changing the format's Bayer ordering\n+ * before calling subdev_->setFormat().\n+ *\n+ * \\return 0 on success or a negative error code otherwise\n+ */\n+int CameraSensor::tryFormat(V4L2SubdeviceFormat *format) const\n+{\n+\treturn subdev_->setFormat(pad_, format,\n+\t\t\t\t V4L2Subdevice::Whence::TryFormat);\n+}\n+\n /**\n * \\brief Retrieve the supported V4L2 controls and their information\n *\n", "prefixes": [ "libcamera-devel", "v3", "4/6" ] }