Patch Detail
Show a patch.
GET /api/patches/18544/?format=api
{ "id": 18544, "url": "https://patchwork.libcamera.org/api/patches/18544/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18544/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230423203931.108022-2-umang.jain@ideasonboard.com>", "date": "2023-04-23T20:39:29", "name": "[libcamera-devel,1/3] apps: cam: kms_sink: Do not process requests after stop()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "aae8d1bd9dd9d79d8cae714109ee1f093f77aad5", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18544/mbox/", "series": [ { "id": 3845, "url": "https://patchwork.libcamera.org/api/series/3845/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3845", "date": "2023-04-23T20:39:28", "name": "apps: cam: kms: Introduce requests tracking queue", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3845/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18544/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18544/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12F65C3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Apr 2023 20:39:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3098627D8;\n\tSun, 23 Apr 2023 22:39:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFA85627CF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 23 Apr 2023 22:39:40 +0200 (CEST)", "from umang.jainideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:df01:2ad:735a:b54c:741d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59C199B9;\n\tSun, 23 Apr 2023 22:39:30 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682282385;\n\tbh=O99b22zRRxhn1HqjojfhgRQklC4ldF/F1VRhN1jLGVY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=GiArD9sils8BM5OODMnTKeYzp8sA1NlXOhd0dn17FNHkYxPDVK3NvLJE9oHn5/5oN\n\t8s86QeYERTVBQCr6Hhl3tH7Et9Gz0+f2sXdwPmE/9c/Qh1mXm6i1z3fHSFS7FtJQ2/\n\teda8PY0QO84yrG8PmoDW/cewpXc3jlBf1es/rKbO5c0MjAJlEySpgBmo883kUToOM5\n\t3h0pcDzslkbXShbk0B37wtftDCXvzWwXWbot4iL1LKxjUmsAX46FRPf9gfrakpF08C\n\tvm2d/Y6lW45hbirpBsdE7Z0UmNnDgyGBPmCPXDM7R6AoH7QaOWnxQ2AYpQYANoCeyt\n\tRUuBLltTrOjIQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682282371;\n\tbh=O99b22zRRxhn1HqjojfhgRQklC4ldF/F1VRhN1jLGVY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HaQoJHt7lScIk2DPO8gUDh8npaXd1EG40OK4wddpwdqYTHLdXPgdzwJaiEXyVR85F\n\t4iu4l9i8iq4onyceOe/0YoAYcEL/CNSO4NKMC4rhV6z03gK+DQxIv4kcK489NmZFUP\n\ts2qN9u2n30voEablfJ+DJNdY6ArEtXW65gVgXpSU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HaQoJHt7\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 24 Apr 2023 02:09:29 +0530", "Message-Id": "<20230423203931.108022-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230423203931.108022-1-umang.jain@ideasonboard.com>", "References": "<20230423203931.108022-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] apps: cam: kms_sink: Do not process\n\trequests after stop()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "KMSSink might process completed page flip requests from DRM\nafter stop() has been called. This is not right hence connect the\nDevice::requestCompleted signal on start() and disconnect it on stop().\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/apps/cam/kms_sink.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\nindex 353209cd..a508977d 100644\n--- a/src/apps/cam/kms_sink.cpp\n+++ b/src/apps/cam/kms_sink.cpp\n@@ -63,7 +63,6 @@ KMSSink::KMSSink(const std::string &connectorName)\n \t\treturn;\n \t}\n \n-\tdev_.requestComplete.connect(this, &KMSSink::requestComplete);\n }\n \n void KMSSink::mapBuffer(libcamera::FrameBuffer *buffer)\n@@ -328,11 +327,15 @@ int KMSSink::start()\n \t\treturn ret;\n \t}\n \n+\tdev_.requestComplete.connect(this, &KMSSink::requestComplete);\n+\n \treturn 0;\n }\n \n int KMSSink::stop()\n {\n+\tdev_.requestComplete.disconnect();\n+\n \t/* Display pipeline. */\n \tDRM::AtomicRequest request(&dev_);\n \n", "prefixes": [ "libcamera-devel", "1/3" ] }