Patch Detail
Show a patch.
GET /api/patches/18468/?format=api
{ "id": 18468, "url": "https://patchwork.libcamera.org/api/patches/18468/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18468/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230327093439.24670-5-naush@raspberrypi.com>", "date": "2023-03-27T09:34:39", "name": "[libcamera-devel,v2,4/4] ipa: raspberrypi: Fix default frame durations calculation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3f68e712a24b59643036dde20ce68ed3723c8623", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18468/mbox/", "series": [ { "id": 3818, "url": "https://patchwork.libcamera.org/api/series/3818/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3818", "date": "2023-03-27T09:34:35", "name": "Raspberry Pi: Sensor limits", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3818/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18468/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18468/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1A26C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Mar 2023 09:34:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47E356271E;\n\tMon, 27 Mar 2023 11:34:50 +0200 (CEST)", "from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com\n\t[IPv6:2607:f8b0:4864:20::d2e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5548A62724\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Mar 2023 11:34:46 +0200 (CEST)", "by mail-io1-xd2e.google.com with SMTP id p17so3601603ioj.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Mar 2023 02:34:46 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\td12-20020a056602328c00b0075464a69c10sm7658345ioz.10.2023.03.27.02.34.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 27 Mar 2023 02:34:44 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679909690;\n\tbh=XSUIUUNxfOpTmzrNOaJlxZ9ZFDh4NyWbb8aWkoecDO0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qfIaw05zYK0tA0LOlWkfkN6VsQq1XWVwXIyKo6Wgy0B/jdVo1PGYLr3aDvedTlXO5\n\tbaYVdyKgLlKjQz0/GSMWY3C/siE1Zg+wmkOo8ymu7e/N0R4iBvDJ91ShovXpjSLgzZ\n\t02p0mfg+4MxgTUJvx1IC9OoSi6/KyWE9oIcgm97pDXJjPoBwuvz3+BjZfohxtSVa6N\n\tPvDVH8kEzyaMpGQW1Vyp96VIZNBf6DHjHo0fgujCOy7XhNQ8g8KfJ0cxFlDrKAn2TZ\n\tnXf0bQur3jXh4IurbbCRf1vGt3OugeXg1konkjftAlwhZju1VQlZqBGC7Z5+DF0ISX\n\tqcuYiTC8R3qhA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1679909685;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=p0hVtHHnzZKHAsyUKyPksKTBylxtTOrJ1jmAU6zbBEE=;\n\tb=CUn+q5aQCWiaM2LvBo4a5CHoUrX3FTUbxqilQ1Zt4t5/8/mm8PWkCxOzpgU6nKiJZ+\n\tQVOuAzaMVETQSAdRxVehb4RtZwV+DBNPB85NqePt16yMIYSDt5Esp6eMqmd3pZPKuDub\n\tWoGJEjnILEoUSCdgeG5N5ONl16HEKhOplpYWBb/LfguY0i0b9cKV5LexkZ5pBBrHOQbr\n\t2rblJtvnNbNElptS4dKPhu/SNruYb7E/uBid12lw2A5hl2IfdsWpQnXz6E7a9ZCDymr2\n\tki0/s6+HVBe/CP3sLWKieserF4zZfeNzTONmFQtI0DQn74gFYD0LdF0AJO2BNSTnIc68\n\tzRHQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"CUn+q5aQ\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1679909685;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=p0hVtHHnzZKHAsyUKyPksKTBylxtTOrJ1jmAU6zbBEE=;\n\tb=uclv+rquOUsvvZwZ044aPV4aqKtA/MYPwZgcGMZ8J04dMuFWAToHepMu8/g2A1bQCt\n\trLvY8e+AWzTOHU3P7gaTQaOC2rGe9T3amtCnmJX8I/IBWDH2JEa+KcqHpzp327DY58mK\n\tgTd2Nt70yRfG3A4hivw4U5iyJmXt4XsOOdg6JKPM0V1oz2pEhfyKzAwr+Sg9IAIjTaAP\n\trbZnKK9ZLOqE1xbKUW7aOec2PR1wtH3/VC1lSjJDPQRtSeeNkBdP3pklKtu6AMj4vd/P\n\tX51ORoyVh5TAn9/rebOU4WniWGywbwI8e/Lj8Oo+hg7CJ/bG5tvjd4SVGGr0xsrs6Jg8\n\t3zxA==", "X-Gm-Message-State": "AO0yUKXVuNu+VS8U7o4ZiXRT3WoSR0aZTZYHkU9q0v88AjnYQgcETDlI\n\tDXHG8Mn2DMsAdvEG1LYz50eyLYUnlpPM7Ie81ZVF9g==", "X-Google-Smtp-Source": "AK7set8CimX3INzdlWFcB7p0VJRWZM5wTJ989l/nlPYYCM07nA85xUdyqyx05MJeCUnOr0ha0Hkd/A==", "X-Received": "by 2002:a5e:8c05:0:b0:759:6a8e:96e5 with SMTP id\n\tn5-20020a5e8c05000000b007596a8e96e5mr7057239ioj.17.1679909684982; \n\tMon, 27 Mar 2023 02:34:44 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Mar 2023 10:34:39 +0100", "Message-Id": "<20230327093439.24670-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230327093439.24670-1-naush@raspberrypi.com>", "References": "<20230327093439.24670-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/4] ipa: raspberrypi: Fix default\n\tframe durations calculation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix a bug in the default frame durations calculation where the min/max\nvalues are swapped round. This is a rarely travelled code path, so has\nnot actually caused a reported failure.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex c10e57e07ab0..66a020d022cd 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -1486,8 +1486,8 @@ void IPARPi::applyFrameDurations(Duration minFrameDuration, Duration maxFrameDur\n \t * This will only be applied once AGC recalculations occur.\n \t * The values may be clamped based on the sensor mode capabilities as well.\n \t */\n-\tminFrameDuration_ = minFrameDuration ? minFrameDuration : defaultMaxFrameDuration;\n-\tmaxFrameDuration_ = maxFrameDuration ? maxFrameDuration : defaultMinFrameDuration;\n+\tminFrameDuration_ = minFrameDuration ? minFrameDuration : defaultMinFrameDuration;\n+\tmaxFrameDuration_ = maxFrameDuration ? maxFrameDuration : defaultMaxFrameDuration;\n \tminFrameDuration_ = std::clamp(minFrameDuration_,\n \t\t\t\t mode_.minFrameDuration, mode_.maxFrameDuration);\n \tmaxFrameDuration_ = std::clamp(maxFrameDuration_,\n", "prefixes": [ "libcamera-devel", "v2", "4/4" ] }