Patch Detail
Show a patch.
GET /api/patches/18371/?format=api
{ "id": 18371, "url": "https://patchwork.libcamera.org/api/patches/18371/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18371/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230309142601.70556-11-tomi.valkeinen@ideasonboard.com>", "date": "2023-03-09T14:25:56", "name": "[libcamera-devel,v4,10/15] py: unittests.py: Add weakref helpers and use del", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d1d3f49fc7d825af2ccee97fa99e78bcc11fe18b", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18371/mbox/", "series": [ { "id": 3796, "url": "https://patchwork.libcamera.org/api/series/3796/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3796", "date": "2023-03-09T14:25:46", "name": "py: New python bindings event handling", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3796/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18371/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18371/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82885C32A1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Mar 2023 14:26:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4340362701;\n\tThu, 9 Mar 2023 15:26:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84517626EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Mar 2023 15:26:20 +0100 (CET)", "from desky.lan (91-154-32-225.elisa-laajakaista.fi [91.154.32.225])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 163658B1;\n\tThu, 9 Mar 2023 15:26:20 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678371988;\n\tbh=3wTUx+H1Obw0NPayo4vNEyDPTT+A2Yvuao3QMWAHhyc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=OxKZrk6q1BT0OovsoxzMT0KzC0ljGuPVK0NfyaFJPnbMIsUzon4/UWBKHWTxPhfrF\n\tJrmbcAwfQbJZt2YjNbUJh1LS6sP3wZIjEE0Iw+aT3qUw417857HRIA4JJelT7oH8kz\n\tjUtmC7WHZ97i2swOLlayj5zVobuqYGYk8hCiUSFW2HZGw0pyAltepYmN3DjWoRc5II\n\tjHl5F/NwztUoI/JUk4r0rxBU0tc/YgFM/z6ih21zZM7dh4PONcgpxh2XlYLxINa5+j\n\tTNM/4x33GvgDjQ8LzcmM5dXhzVk73pr+Idr0iT+8fkogZzGCfvoOsgenZYDa4oMClq\n\t+H/qzmLeEYwSg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678371980;\n\tbh=3wTUx+H1Obw0NPayo4vNEyDPTT+A2Yvuao3QMWAHhyc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aOBTipCHf0vohCFEK8GiGU3Sabp6oaCc8qWoc79XHFKlBqFj4OgxoCrY+66OThB5Y\n\t5bx74k8Ks+h0zFzsg6Ed8+EMScKy0Y7/yZizuHQnrLr7dGE/0AIsHAiWozcy/aenPl\n\tpqBgmiEUOf2U3QKgvDuQe/kCMkKvfSRxf/ny/Z9I=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aOBTipCH\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 9 Mar 2023 16:25:56 +0200", "Message-Id": "<20230309142601.70556-11-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>", "References": "<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 10/15] py: unittests.py: Add weakref\n\thelpers and use del", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add helpers to check if a weakref or a list of weakrefs is alive or\ndead.\n\nAlso use 'del' for local variables instead of setting the variable to\nNone. This makes debugging the test easier as the locals will be gone\nfrom locals() dict.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n test/py/unittests.py | 60 ++++++++++++++++++++++++++------------------\n 1 file changed, 36 insertions(+), 24 deletions(-)", "diff": "diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex fab791d1..3bd2d7fd 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -18,6 +18,18 @@ class BaseTestCase(unittest.TestCase):\n def assertZero(self, a, msg=None):\n self.assertEqual(a, 0, msg)\n \n+ def assertIsAlive(self, wr, msg='object not alive'):\n+ self.assertIsNotNone(wr(), msg)\n+\n+ def assertIsDead(self, wr, msg='object not dead'):\n+ self.assertIsNone(wr(), msg)\n+\n+ def assertIsAllAlive(self, wr_list, msg='object not alive'):\n+ self.assertTrue(all([wr() for wr in wr_list]), msg)\n+\n+ def assertIsAllDead(self, wr_list, msg='object not dead'):\n+ self.assertTrue(all([not wr() for wr in wr_list]), msg)\n+\n \n class SimpleTestMethods(BaseTestCase):\n def test_get_ref(self):\n@@ -28,14 +40,14 @@ class SimpleTestMethods(BaseTestCase):\n self.assertIsNotNone(cam)\n wr_cam = weakref.ref(cam)\n \n- cm = None\n+ del cm\n gc.collect()\n- self.assertIsNotNone(wr_cm())\n+ self.assertIsAlive(wr_cm)\n \n- cam = None\n+ del cam\n gc.collect()\n- self.assertIsNone(wr_cm())\n- self.assertIsNone(wr_cam())\n+ self.assertIsDead(wr_cm)\n+ self.assertIsDead(wr_cam)\n \n def test_acquire_release(self):\n cm = libcam.CameraManager.singleton()\n@@ -89,8 +101,8 @@ class CameraTesterBase(BaseTestCase):\n self.cam = None\n self.cm = None\n \n- self.assertIsNone(self.wr_cm())\n- self.assertIsNone(self.wr_cam())\n+ self.assertIsDead(self.wr_cm)\n+ self.assertIsDead(self.wr_cam)\n \n \n class AllocatorTestMethods(CameraTesterBase):\n@@ -110,11 +122,11 @@ class AllocatorTestMethods(CameraTesterBase):\n wr_stream = weakref.ref(stream)\n \n # stream should keep streamconfig and camconfig alive\n- streamconfig = None\n- camconfig = None\n+ del streamconfig\n+ del camconfig\n gc.collect()\n- self.assertIsNotNone(wr_camconfig())\n- self.assertIsNotNone(wr_streamconfig())\n+ self.assertIsAlive(wr_camconfig)\n+ self.assertIsAlive(wr_streamconfig)\n \n allocator = libcam.FrameBufferAllocator(cam)\n num_bufs = allocator.allocate(stream)\n@@ -123,29 +135,29 @@ class AllocatorTestMethods(CameraTesterBase):\n \n buffers = allocator.buffers(stream)\n self.assertIsNotNone(buffers)\n- buffers = None\n+ del buffers\n \n buffer = allocator.buffers(stream)[0]\n self.assertIsNotNone(buffer)\n wr_buffer = weakref.ref(buffer)\n \n- allocator = None\n+ del allocator\n gc.collect()\n- self.assertIsNotNone(wr_buffer())\n- self.assertIsNotNone(wr_allocator())\n- self.assertIsNotNone(wr_stream())\n+ self.assertIsAlive(wr_buffer)\n+ self.assertIsAlive(wr_allocator)\n+ self.assertIsAlive(wr_stream)\n \n- buffer = None\n+ del buffer\n gc.collect()\n- self.assertIsNone(wr_buffer())\n- self.assertIsNone(wr_allocator())\n- self.assertIsNotNone(wr_stream())\n+ self.assertIsDead(wr_buffer)\n+ self.assertIsDead(wr_allocator)\n+ self.assertIsAlive(wr_stream)\n \n- stream = None\n+ del stream\n gc.collect()\n- self.assertIsNone(wr_stream())\n- self.assertIsNone(wr_camconfig())\n- self.assertIsNone(wr_streamconfig())\n+ self.assertIsDead(wr_stream)\n+ self.assertIsDead(wr_camconfig)\n+ self.assertIsDead(wr_streamconfig)\n \n \n class SimpleCaptureMethods(CameraTesterBase):\n", "prefixes": [ "libcamera-devel", "v4", "10/15" ] }