Patch Detail
Show a patch.
GET /api/patches/18368/?format=api
{ "id": 18368, "url": "https://patchwork.libcamera.org/api/patches/18368/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18368/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230309142601.70556-8-tomi.valkeinen@ideasonboard.com>", "date": "2023-03-09T14:25:53", "name": "[libcamera-devel,v4,07/15] py: simple-cam.py: Use new events support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2b0f75182fde505e0cbfbd2d69bd16510e07a91f", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18368/mbox/", "series": [ { "id": 3796, "url": "https://patchwork.libcamera.org/api/series/3796/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3796", "date": "2023-03-09T14:25:46", "name": "py: New python bindings event handling", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3796/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18368/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18368/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8354CC329F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Mar 2023 14:26:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BFE5162702;\n\tThu, 9 Mar 2023 15:26:25 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D24D626E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Mar 2023 15:26:19 +0100 (CET)", "from desky.lan (91-154-32-225.elisa-laajakaista.fi [91.154.32.225])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BEC66886;\n\tThu, 9 Mar 2023 15:26:18 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678371985;\n\tbh=iaRylJ5l1sFUWopCwUojy8cIUA0Y2r4I2IXZHJH+WuA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Q+xrVVB+f+mJBQsCXg15oIwozh7qPMgrtfvx+AmrFrmmfTTUxWMq0Xl5TuWFto1qc\n\tPwGBgf521obcrKK1rcBYM9C+IJQXuVfWxBrh082YUqPxnORmEXCOYiS/EUYZ1vbKax\n\tM1KEv5CkJL4n+PorWTP2teqBnhzqm6tuDxoTRdTkxiPcZpTOt3QM2I4w2EGrOMv24+\n\t5BsQB9InlGgav0xT6XWsFnynFRvgBNuAkALuq+RK3HF0fMhCHwxrUAaRYOHGnntrrY\n\tF2QrNuVirXqHcp/vGOc2KqC7FiwhmJyQd16y/L2cQC3tyIFfP27eT+Ff3MD3CouLCa\n\trSyiSVAwEUhUw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678371979;\n\tbh=iaRylJ5l1sFUWopCwUojy8cIUA0Y2r4I2IXZHJH+WuA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cRcvIR9wgXxifvOH+cisvmqvf37JwsNTjSZp5ySpudmjsxX2A6TYjOCeQsWEmdgVs\n\tDVwMieZLUYnn64QMSIkQZ8ErpzukFycou1NVyXDLELZhTJIRniLdKmMmA7WoOnFEcp\n\t31yie2niS0tC4YcD6jruQyQdzy4aHsms+WYh6lVo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cRcvIR9w\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 9 Mar 2023 16:25:53 +0200", "Message-Id": "<20230309142601.70556-8-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>", "References": "<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 07/15] py: simple-cam.py: Use new\n\tevents support", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update simple-cam.py to the new event model.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/examples/simple-cam.py | 19 ++++++++++---------\n 1 file changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/py/examples/simple-cam.py b/src/py/examples/simple-cam.py\nindex 1cd1019d..2d359cb7 100755\n--- a/src/py/examples/simple-cam.py\n+++ b/src/py/examples/simple-cam.py\n@@ -19,16 +19,17 @@ TIMEOUT_SEC = 3\n \n \n def handle_camera_event(cm):\n- # cm.get_ready_requests() returns the ready requests, which in our case\n- # should almost always return a single Request, but in some cases there\n- # could be multiple or none.\n+ # cm.get_events() returns the ready events, which in our case should\n+ # almost always be a single RequestCompleted event, but in some cases\n+ # there could be multiple ones, other events, or no events at all.\n \n- reqs = cm.get_ready_requests()\n+ for ev in cm.get_events():\n+ # We are only interested in RequestCompleted events\n+ if ev.type != libcam.Event.Type.RequestCompleted:\n+ continue\n \n- # Process the captured frames\n-\n- for req in reqs:\n- process_request(req)\n+ # Process the captured frames\n+ process_request(ev.request)\n \n \n def process_request(request):\n@@ -304,7 +305,7 @@ def main():\n # CameraManager and an event will be raised using eventfd.\n #\n # The list of completed Requests can be retrieved with\n- # CameraManager.get_ready_requests(), which will also clear the list in the\n+ # CameraManager.get_events(), which will also clear the list in the\n # CameraManager.\n #\n # The eventfd can be retrieved from CameraManager.event_fd, and the fd can\n", "prefixes": [ "libcamera-devel", "v4", "07/15" ] }