Patch Detail
Show a patch.
GET /api/patches/18358/?format=api
{ "id": 18358, "url": "https://patchwork.libcamera.org/api/patches/18358/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18358/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230308164028.235638-2-jacopo.mondi@ideasonboard.com>", "date": "2023-03-08T16:40:26", "name": "[libcamera-devel,1/3] libcamera: control_ids: Introduce LensShadingEnable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "10249ea1123f3cd0a10d4849c776b8d97a0c5272", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18358/mbox/", "series": [ { "id": 3795, "url": "https://patchwork.libcamera.org/api/series/3795/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3795", "date": "2023-03-08T16:40:25", "name": "ipa: rkisp1: lsc: Enable/disable LSC", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3795/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18358/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18358/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65159BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Mar 2023 16:40:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3520A626D1;\n\tWed, 8 Mar 2023 17:40:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D33662693\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Mar 2023 17:40:42 +0100 (CET)", "from uno.homenet.telecomitalia.it\n\t(host-79-47-54-87.retail.telecomitalia.it [79.47.54.87])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD127576;\n\tWed, 8 Mar 2023 17:40:41 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678293644;\n\tbh=NblqHh0uIJhLvlMbbYFfNgZZBM/UvnmW/AeEoh9EpBQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=UxJASbGOO/no5rbvRq9xUTHmVjSQ+GYwgwmbMorHxFFcw5tmyNxr8lM4lhr/6cBaI\n\tz/zEyDUcGh9l2r5b52gwAbPlWRjGKlelNFcpRpU1MOiIoVddniG4JZAL+6fx9e8ux+\n\tg79Y0tNVPgamHqg3PnshrIki3i0DNYoFxFxXbiLk6F85nz4pQl6yL49+6zm19tj+ku\n\tDjFyRj+cA9VdtNF6l4XK8qNicSOXKJNqIyTN2L8Ec2vJgM20YihPQhZLPZSV3wIG0O\n\tbSFx6eTpQl0PylfWYN1ZW3ImrHZG+WMPhEjJ5cFVtvsNc5VR/o/ko9+JSbo3Q2XFSN\n\t4Kq6Wdcl1rrGw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678293642;\n\tbh=NblqHh0uIJhLvlMbbYFfNgZZBM/UvnmW/AeEoh9EpBQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jx3en1Wz0ol7yxMyVIXd+9E1OiQyi3VcK09ywR+j7srYvSP86ctbmY3PnuQa45Gpq\n\teqFW+vko5+jfX4gxBu26edsThHgkLp8PQXQjLYcizrppjQkPYJ2VQhhODGJUrWynpm\n\t0cr9hI1eBkXggdapTkm3vkB3o8bmJMhfP51OMMoA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jx3en1Wz\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 8 Mar 2023 17:40:26 +0100", "Message-Id": "<20230308164028.235638-2-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.0", "In-Reply-To": "<20230308164028.235638-1-jacopo.mondi@ideasonboard.com>", "References": "<20230308164028.235638-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: control_ids: Introduce\n\tLensShadingEnable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nIntroduce a control to enable and disable LSC and replace the\ndraft android control. The control is used to report the algorithm\ncurrent state when part of a completed Request metadata.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_capabilities.cpp | 4 ++--\n src/libcamera/control_ids.yaml | 20 ++++++--------------\n 2 files changed, 8 insertions(+), 16 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 1bfeaea4b121..040ad7347773 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1187,10 +1187,10 @@ int CameraCapabilities::initializeStaticMetadata()\n \t{\n \t\tstd::vector<uint8_t> data;\n \t\tdata.reserve(2);\n-\t\tconst auto &infoMap = controlsInfo.find(&controls::draft::LensShadingMapMode);\n+\t\tconst auto &infoMap = controlsInfo.find(&controls::LensShadingEnable);\n \t\tif (infoMap != controlsInfo.end()) {\n \t\t\tfor (const auto &value : infoMap->second.values())\n-\t\t\t\tdata.push_back(value.get<int32_t>());\n+\t\t\t\tdata.push_back(value.get<bool>());\n \t\t} else {\n \t\t\tdata.push_back(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE_OFF);\n \t\t}\ndiff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex adea5f90acc5..9457fb3de7b0 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -694,6 +694,12 @@ controls:\n Continuous AF is paused. No further state changes or lens movements\n will occur until the AfPauseResume control is sent.\n \n+ - LensShadingEnable:\n+ type: bool\n+ description: |\n+ Enable or disable the lens shading algorithm. When reported in the\n+ Request metadata the control reflects the algorithm's current state.\n+\n # ----------------------------------------------------------------------------\n # Draft controls section\n \n@@ -829,20 +835,6 @@ controls:\n row and the start of exposure of the last row. Currently identical to\n ANDROID_SENSOR_ROLLING_SHUTTER_SKEW\n \n- - LensShadingMapMode:\n- type: int32_t\n- draft: true\n- description: |\n- Control to report if the lens shading map is available. Currently\n- identical to ANDROID_STATISTICS_LENS_SHADING_MAP_MODE.\n- enum:\n- - name: LensShadingMapModeOff\n- value: 0\n- description: No lens shading map mode is available.\n- - name: LensShadingMapModeOn\n- value: 1\n- description: The lens shading map mode is available.\n-\n - SceneFlicker:\n type: int32_t\n draft: true\n", "prefixes": [ "libcamera-devel", "1/3" ] }