Patch Detail
Show a patch.
GET /api/patches/18317/?format=api
{ "id": 18317, "url": "https://patchwork.libcamera.org/api/patches/18317/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18317/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230227224910.151337-2-suhrid.subramaniam@mediatek.com>", "date": "2023-02-27T22:49:09", "name": "[libcamera-devel,v2,1/2] libcamera: pipeline: simple: Check converter_", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1e4bf5b2ea41a6efd2330c7e6036a4d095c223c6", "submitter": { "id": 151, "url": "https://patchwork.libcamera.org/api/people/151/?format=api", "name": "Suhrid Subramaniam", "email": "suhridsubramaniam@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18317/mbox/", "series": [ { "id": 3775, "url": "https://patchwork.libcamera.org/api/series/3775/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3775", "date": "2023-02-27T22:49:08", "name": "Check converter_ validity", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3775/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18317/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18317/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1C29BE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Feb 2023 22:50:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97BFD6267E;\n\tMon, 27 Feb 2023 23:50:44 +0100 (CET)", "from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com\n\t[IPv6:2607:f8b0:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79A7662676\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Feb 2023 23:50:42 +0100 (CET)", "by mail-pg1-x52d.google.com with SMTP id s17so4560246pgv.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Feb 2023 14:50:42 -0800 (PST)", "from localhost.localdomain (sfosm0151r356001-v22.wiline.com.\n\t[67.207.106.98]) by smtp.gmail.com with ESMTPSA id\n\t17-20020aa79111000000b005e00086250asm4663117pfh.125.2023.02.27.14.50.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 27 Feb 2023 14:50:40 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677538244;\n\tbh=OvFOgdhytnUxq9sLHEK9OxfYsVRB2KT92yJ8nZXUIQo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CXhxcOfn6Y/BQI9flxxyU8sMYsPLDcqhguAqZ0TaSS/pLV7bm5AtgYJj6Qb/k5hay\n\tDDAfT9zj+ISnBZEs/Aqegxf7C9BJCz0NvOPf/O8s+IczzS6mirF4X0lHR9qY3LrcC+\n\tttejm4F2Au7dFv7c+pu5uhtMkseRyPudqlvtSNJ+rZvoUJCU4IwADnOObcIxpH0IZQ\n\tQw4O8O7TwiVur5BOaJ1UJ6cdTGF6BhwgbwAu2j9ab0NXM+t4Jaagu0DGvxdR0trHgz\n\tOK2E9xbRAi5yLjKIAcN5Fx3jlH7s9bzhYpigqBd0c4H4bFFWYl6HFf8Pr0WBTEXMYj\n\t4M7gr2yr55AmA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20210112; t=1677538241;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=55bXgzJ7lgqJoz6t2+4fIitcYoL4Exh0HE4g/IB3upo=;\n\tb=QnO/00Z1ePSztY6hLd8iGMp7Rcxeib5VN0p8rwsJqDVSx/xXcY06+hQ4sIjCOV3tU5\n\tuaPtCnJwvWk3jg36mSCJfzwH7OO7cPfu5qTLJ3EsFsJBmInqqwT3gvXMLmW4rTqSbgq/\n\t3tyZXgx5s76twCc6RXGXkVj0naqEisfsoM6EwdCTT051hEGotwdSaSLbImwivBapraLy\n\txv+FvV2pfyiU0GqAOwzSLcmMFuf4RRfLYjXZrt++CPLRYNKlJXg1odpMhGShyuAaY3HR\n\t/h0KxLphqgiVkUaJ1ZMP9OlHbqC906EOurgnyU9abkfq4iTCe/XD2+i9yFINQwfUmPQp\n\tmXaQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QnO/00Z1\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1677538241;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=55bXgzJ7lgqJoz6t2+4fIitcYoL4Exh0HE4g/IB3upo=;\n\tb=olq06BMy2TjJT2Ecwpd9IPlqvfJVpc+Bm7Bbgn09Fw57bpGCOMwZGjb3xE/WKhNQQW\n\tJ0Wg0lsZlAAKD9qEclWg0ACf6AczFp8E9zZEf3DnQxp7CIzcSFe6jMIeir/kFoAkQTLX\n\t0lqjQCnUCmhcsUACzCkovyq0nVbY6rbQdyHooZyxt2uZcyqYCfyuPn+f+Yh7aIFZ8ger\n\t7Q36pjDCjd0iXzTYJ8cgInaGjbHqCXbzIIyzNvdWvUVibb0udMpKhD87BZbqbmALdb6M\n\tJ+ZyvOmzHygnNsjK9g8Mh7Y86OnokkMLR9pSviTDE3pz+UxnUlh0++tB+dMIN2zo7+iP\n\tubWw==", "X-Gm-Message-State": "AO0yUKXGztkk9bOScp8GOFKzStSJmPQFmZe7oA/r40t1oh7NEUKS5syS\n\t1LABaBO7dmDpQ+btSRmGvmYz8ddKuXsv4Q==", "X-Google-Smtp-Source": "AK7set+SnyStz1lifNiTX2+mWzfIl/4PTC/trGhkUBiAcMC9UNlLvWGRX1ipzUsF2YwMGSQxqGPB7g==", "X-Received": "by 2002:aa7:85d7:0:b0:5f5:313e:49dd with SMTP id\n\tz23-20020aa785d7000000b005f5313e49ddmr670766pfn.1.1677538240700; \n\tMon, 27 Feb 2023 14:50:40 -0800 (PST)", "X-Google-Original-From": "Suhrid Subramaniam <suhrid.subramaniam@mediatek.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Feb 2023 14:49:09 -0800", "Message-Id": "<20230227224910.151337-2-suhrid.subramaniam@mediatek.com>", "X-Mailer": "git-send-email 2.39.0", "In-Reply-To": "<20230227224910.151337-1-suhrid.subramaniam@mediatek.com>", "References": "<20230227224910.151337-1-suhrid.subramaniam@mediatek.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/2] libcamera: pipeline: simple: Check\n\tconverter_", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Suhrid Subramaniam via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Suhrid Subramaniam <suhridsubramaniam@gmail.com>", "Cc": "Suhrid Subramaniam <suhrid.subramaniam@mediatek.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "- If no converter is found, converter_ becomes a nullptr and\n!converter_->isValid() causes a segmentation fault.\n- Avoid this by checking if converter_ is a nullptr.\n\nSigned-off-by: Suhrid Subramaniam <suhrid.subramaniam@mediatek.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 24ded4db..2423ec10 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -493,7 +493,7 @@ int SimpleCameraData::init()\n \tMediaDevice *converter = pipe->converter();\n \tif (converter) {\n \t\tconverter_ = ConverterFactoryBase::create(converter);\n-\t\tif (!converter_->isValid()) {\n+\t\tif (!converter_) {\n \t\t\tLOG(SimplePipeline, Warning)\n \t\t\t\t<< \"Failed to create converter, disabling format conversion\";\n \t\t\tconverter_.reset();\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }