Patch Detail
Show a patch.
GET /api/patches/18209/?format=api
{ "id": 18209, "url": "https://patchwork.libcamera.org/api/patches/18209/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18209/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230127154322.29019-10-naush@raspberrypi.com>", "date": "2023-01-27T15:43:16", "name": "[libcamera-devel,v6,09/15] libcamera: camera: Validate MandatoryStream in queueRequest()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e3d5d076fb233b3908ebc626a5b79db1031e316a", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18209/mbox/", "series": [ { "id": 3728, "url": "https://patchwork.libcamera.org/api/series/3728/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3728", "date": "2023-01-27T15:43:07", "name": "[libcamera-devel,v6,01/15] libcamera: stream: Add stream hints to StreamConfiguration", "version": 6, "mbox": "https://patchwork.libcamera.org/series/3728/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18209/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18209/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2ABA4C3242\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Jan 2023 15:43:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE4FB625EE;\n\tFri, 27 Jan 2023 16:43:49 +0100 (CET)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42B0B625DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Jan 2023 16:43:41 +0100 (CET)", "by mail-wm1-x329.google.com with SMTP id j17so3774991wms.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Jan 2023 07:43:41 -0800 (PST)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\th18-20020a05600c30d200b003c21ba7d7d6sm4549566wmn.44.2023.01.27.07.43.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 27 Jan 2023 07:43:40 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674834229;\n\tbh=LHFc9oAT7V0oKglt+dmod6zeVMnswHwmpo6gmQVvMlU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=s5O9lYkEWT7MJ9T6MU0lxNg1oHhG9/2P8z+DqesmkLlnf6HnQfZc/e1ACc6woYqVe\n\t+sfPzkk6SwiUG/BBglK5x8EqvDGQLWA+r+l8k7eSfpAqOtMQHGZ50xMk8EzPFMwc2C\n\tw/e2uMfYFKlG+rcs2Cw6rRMwP2IbAd48/O5+3Up4sOyGAnwZsbiSpBRzFlfCtBl0ss\n\tGF/ko7D5+HIyeVPvD+HSh5toi2Z+UUhfZe2Ujbr3sMqRtlvJsjDPfGGMKvCI0gSABX\n\tTKBjS+ngQmqgRMIVlQklQEoS2Kncyp0kEJevp+KWiCyvsb+QZeOLNbWdpbDvFOUAlo\n\tDoAAXGbbUpzJg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=U/rJVWuxNB0Zl6v7nsB+2X3RSr+G8CnS+bjX1/c2Tvo=;\n\tb=YOLrR94LzwutjpenSznjrAr3gJNv4SRhq5W4roa6jMv8wSwZODxzuyep0z7dKPGnJV\n\tfwBteb4Q4xvGqWQ5Ye71SgzPnItpJ+BDA5YIfG4SrLkU7tJnEl3b2w9T+qo1PlyLc4r6\n\tl2nnXQSjww5fkAMgwP4ItHVLzFWf2j6hrQcGehwoZczfatuM3PHu3sltvKDUoJfQ1dNC\n\tu9PI0+LAvhZt8uVqquO7r/HMmciJypkfqwcd8RK2SXQCqvCWcguN/qdSHmnZep1GpI3Y\n\tzaS9DnJ+eIYmbBs7qWzhntx6qPAPq6TYtbBfzySKpwhnm2PYSCHyHWZiGRCEtMNFFrR5\n\tP3og==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"YOLrR94L\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=U/rJVWuxNB0Zl6v7nsB+2X3RSr+G8CnS+bjX1/c2Tvo=;\n\tb=rFydXtBkc4IEkqzcqjdS8cBDMVBxG/9rX+nsxRVcOBDfS3dbvtAKCp+LEaJ6WfRKiN\n\tT4btHUsGemv13OcfD85d+6KQZDW7bgnTQhoRrQ5M2Bl+TRX2EqUDuAegq/95/3EmxOUq\n\tLw+eZbBMI+mhX6fMpGB8HoKbncorPP7DGEhuMZPbHlqNTmVkqZvl7hBQXLGfZYvsDvRr\n\tghKwe1jFLB68BaAPMtTittERsdL9+4aU8b/aa0io0vVilQm2iXgHuiC/jTw7c/LPU47L\n\tzV6YGnc6UWjRmus+vSBFpQiI9UtQjFrMf0+8RIg1hj2wvZYlT58MH/RjMwNt8cb8/zP8\n\tjU8g==", "X-Gm-Message-State": "AO0yUKUZD+CDqoQOVMLJ+fglYkIdcQyInMy+/8B51qgDNykQX31Tsujn\n\tYFrAl5isiIuHRcl7wa9TPXhcFtHL1Zi7XO3zekY=", "X-Google-Smtp-Source": "AK7set8nLi4fhMrRK0oEdaCqIyF7DOEBWdYbiluWeituViYIF/izskLhL49HqvlAyN0O8zqCgGQs9w==", "X-Received": "by 2002:a05:600c:314d:b0:3dc:2039:1710 with SMTP id\n\th13-20020a05600c314d00b003dc20391710mr9820047wmo.20.1674834220780; \n\tFri, 27 Jan 2023 07:43:40 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Jan 2023 15:43:16 +0000", "Message-Id": "<20230127154322.29019-10-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230127154322.29019-1-naush@raspberrypi.com>", "References": "<20230127154322.29019-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 09/15] libcamera: camera: Validate\n\tMandatoryStream in queueRequest()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add some validation in queueRequest() to ensure that a frame buffer is\nprovided in a Request if the MandatoryStream flag has been set in the\nStreamConfiguration for every active stream.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/camera.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 2d947a442bff..b0b0a5cb5bb3 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -1144,6 +1144,18 @@ int Camera::queueRequest(Request *request)\n \t\t}\n \t}\n \n+\tfor (auto const stream : d->activeStreams_) {\n+\t\tconst StreamConfiguration &config = stream->configuration();\n+\t\tFrameBuffer *buffer = request->findBuffer(stream);\n+\n+\t\tif (!buffer && config.hints & StreamConfiguration::Hint::MandatoryStream) {\n+\t\t\tLOG(Camera, Error)\n+\t\t\t\t<< \"No buffer provided for mandatory stream\";\n+\t\t\trequest->_d()->reset();\n+\t\t\treturn -ENOMEM;\n+\t\t}\n+\t}\n+\n \td->pipe_->invokeMethod(&PipelineHandler::queueRequest,\n \t\t\t ConnectionTypeQueued, request);\n \n", "prefixes": [ "libcamera-devel", "v6", "09/15" ] }