Patch Detail
Show a patch.
GET /api/patches/18145/?format=api
{ "id": 18145, "url": "https://patchwork.libcamera.org/api/patches/18145/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18145/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230119084112.20564-7-dse@thaumatec.com>", "date": "2023-01-19T08:41:10", "name": "[libcamera-devel,v3,6/8] pipeline: rkisp1: Add basic AF controls to the supported controls list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "51c479410a890b5a5dd9c41d77aab667114eaa06", "submitter": { "id": 126, "url": "https://patchwork.libcamera.org/api/people/126/?format=api", "name": "Daniel Semkowicz", "email": "dse@thaumatec.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18145/mbox/", "series": [ { "id": 3714, "url": "https://patchwork.libcamera.org/api/series/3714/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3714", "date": "2023-01-19T08:41:04", "name": "ipa: rkisp1: Add autofocus algorithm", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3714/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18145/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18145/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F4DBC3294\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Jan 2023 08:42:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29361625F5;\n\tThu, 19 Jan 2023 09:42:16 +0100 (CET)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B35F5625EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jan 2023 09:42:12 +0100 (CET)", "by mail-wm1-x330.google.com with SMTP id\n\tc10-20020a05600c0a4a00b003db0636ff84so709546wmq.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jan 2023 00:42:12 -0800 (PST)", "from localhost.localdomain (ip092042140082.rev.nessus.at.\n\t[92.42.140.82]) by smtp.gmail.com with ESMTPSA id\n\tj10-20020a05600c074a00b003db0ee277b2sm3935754wmn.5.2023.01.19.00.42.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Jan 2023 00:42:12 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674117736;\n\tbh=IZZ5Wh2pvaVQNIJJ8KSNaIOZYWKPqd9L61yGyhai0do=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=DHZ1T8SevMbm4sDA5W8b9kc56RX3DOjAdIZHkhp5Cmbf98V32RTPMcz937uaJgSUr\n\tX/HdojQk6VzZ3ywnCoDTtc4yJKbFVDMEvO+TMbWyYBi65Tauwge4tMJYClc6Z5COvE\n\tOjNtCD4/RwlPocq4YJSlMqQ8aEQPbwxt802J9w8KgD9kKPwcKdiRiqCdQqAgDSEuXC\n\t952Wcun0NNhc5htzLAdxhEWIKpMTIeIbmeFjFakBPxEl+fhQ2DJ61meGyZNilIckHF\n\t1u4EaOIXD07YDz2GIIdHU8lN/yyK+VAH6RY3yeeIn5+4rGYHWvL04I7d7jCf4rF8jv\n\tSA6hm9OReqPKg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=8Rg5efG+ONNAzDMKsRD/WP/E/KL6zi12dSbPHOjcxRc=;\n\tb=RHddAhf2T1BywXkCChFzkAu2BQHXGbU6zBhSCMpngDfjl68PvNBzogLYceVyDQ+QOK\n\tJakaNTSE4fAv9qK9zfl/IqF2e5oe40/IZbRNV11gxFKvXyBTU7QERvVjRSbC9/eG/9+o\n\tmAzZTXedpa+YDDJ6mC/RmT1vqIuMXNkP/isYUzwc+Dq5nr7fcrKJPIsxATDeQ7G9bcaU\n\tRx33oi/jPwMKCSGAsMPPPxmYD7PHnVQwW8Xmjpw64kATMU+CbB1+F52fTCpNFlR3YSjs\n\tQbK3LV2jkdRUeOcZS5GJ5QJgd3TEg2TI0fq9LI5sgqEKQ4zU2WAhy6KwMuaOSMpgnPxw\n\tIQBA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"RHddAhf2\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=8Rg5efG+ONNAzDMKsRD/WP/E/KL6zi12dSbPHOjcxRc=;\n\tb=8PWqyElp9k3MaKgp1hYkCWaTzmGCZ25cP0ZdEECyGD3ibkvvJF3jucRLQzeg/LpvuR\n\tr4egMr1Ceqj+K8/vtYaVBNCKkOqV4pN1w61EZP/0wQ3HItCip75hzQo43PvRN7i1onxf\n\tvc9gybJAJe4UV6lCy8DEfFvPvBZvZWnq1wl105HdxeyZw8zG0APmqTiptPH/3KRZReDJ\n\tEwktTyFh44o5NwE6b8yRj4qYIZEg3EMjQ3UVA/dKzyOCpjFMhoDkt2n0hIAn7BgEi9ra\n\tuI3AljfQ/0EjGor/OvxkIwkZuiMnMEHVWfwvWadbbS3ZjrDiZaazNamM+kjnJNt97Zon\n\tRgfA==", "X-Gm-Message-State": "AFqh2kpVtTmFA1fLrCUrBFqggm9URbtB0r4EyqK1mLufUQcQhMjvNNeh\n\tc2EAjJHTPgm8Gk/QkNAHjaxSUbxjYeOZEeEtbUM=", "X-Google-Smtp-Source": "AMrXdXtH6rONd7NGfcgFTCtWuW5OnKDSkXnZf5+G7hpIxEjYu4P9WKZh1oqK8iQo2cEJt8ticTp+yg==", "X-Received": "by 2002:a05:600c:540c:b0:3da:fa18:a535 with SMTP id\n\the12-20020a05600c540c00b003dafa18a535mr9457239wmb.29.1674117732412; \n\tThu, 19 Jan 2023 00:42:12 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 19 Jan 2023 09:41:10 +0100", "Message-Id": "<20230119084112.20564-7-dse@thaumatec.com>", "X-Mailer": "git-send-email 2.39.0", "In-Reply-To": "<20230119084112.20564-1-dse@thaumatec.com>", "References": "<20230119084112.20564-1-dse@thaumatec.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 6/8] pipeline: rkisp1: Add basic AF\n\tcontrols to the supported controls list", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Semkowicz via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Semkowicz <dse@thaumatec.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This will expose the AF controls and will allow controlling them using\nthe top level API.\n\nSigned-off-by: Daniel Semkowicz <dse@thaumatec.com>\n---\n src/ipa/rkisp1/rkisp1.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 297161b2..bc2508a2 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -101,10 +101,14 @@ namespace {\n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n \t{ &controls::AeEnable, ControlInfo(false, true) },\n+\t{ &controls::AfMode, ControlInfo(controls::AfModeValues) },\n+\t{ &controls::AfPause, ControlInfo(controls::AfPauseValues) },\n+\t{ &controls::AfTrigger, ControlInfo(controls::AfTriggerValues) },\n \t{ &controls::AwbEnable, ControlInfo(false, true) },\n \t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n \t{ &controls::Brightness, ControlInfo(-1.0f, 0.993f, 0.0f) },\n \t{ &controls::Contrast, ControlInfo(0.0f, 1.993f, 1.0f) },\n+\t{ &controls::LensPosition, ControlInfo(0.0f, 2147483647.0f) },\n \t{ &controls::Saturation, ControlInfo(0.0f, 1.993f, 1.0f) },\n \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n", "prefixes": [ "libcamera-devel", "v3", "6/8" ] }