Patch Detail
Show a patch.
GET /api/patches/18138/?format=api
{ "id": 18138, "url": "https://patchwork.libcamera.org/api/patches/18138/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18138/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230118085953.7027-13-naush@raspberrypi.com>", "date": "2023-01-18T08:59:53", "name": "[libcamera-devel,v5,12/12] pipeline: raspberrypi: Add minimal memory usage config file", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d5f82bf433b245270a163b5c125e7fbf133b61b6", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18138/mbox/", "series": [ { "id": 3713, "url": "https://patchwork.libcamera.org/api/series/3713/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3713", "date": "2023-01-18T08:59:41", "name": "Raspberry Pi: Platform configuration and buffer allocation improvements", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3713/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18138/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18138/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2DE6C3294\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 Jan 2023 09:01:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7127625F8;\n\tWed, 18 Jan 2023 10:01:29 +0100 (CET)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F8CB625FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Jan 2023 10:01:24 +0100 (CET)", "by mail-wr1-x42c.google.com with SMTP id d2so13062185wrp.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Jan 2023 01:01:24 -0800 (PST)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ti6-20020adfe486000000b002423dc3b1a9sm30312464wrm.52.2023.01.18.01.01.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 18 Jan 2023 01:01:23 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674032489;\n\tbh=a3YaJE7CSXCIWHjsIpjMGKKlrxVHNtGXnCOROHKsYI0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=iSmbQp5s4EG60Zl326abZxD5r3vSYghEDST0jjNP7XFA8tkH6qhU16fUt+yMJumDC\n\t525zcN0kV3uTmYu7sSx1iBjXEwRiXl6ZyOqDiaHR+tm9zm+F80+VZ6+nt68ARLnPvh\n\t5LwWoUw0FDZpDRz9IK5KKHINbDdRfBDCJx7HWsrJ2nMrkYLUv8JHJodu+It0FE2RBt\n\tfWH1nHLh3PgF0/1MvVw8Max24QWBrIcsKqm4zNp7gmZ+lYCuKYNEpkj+ktv3P6vOrH\n\t6yrNWDluwg22zsDTSXE7b3Oxo8H90yYhn1g596EWg5d18Eg2oa7nQcQJ/QvRUKzw8L\n\tGzHqiXjAZ3jjA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=sWILBBIXlzAhPGU6fvcIkhjxcYBCw5crq4jorvb3iUU=;\n\tb=tvfctysQOa8FpzKUR4vVKGBkyvciMZg2vPcPJY5TmvicTeBvFRzKlRin4ZJSnRZ7J5\n\tDCeH6XT34/Cw4aYtymdLCYo+hzxLY8sL08HnH5jWBNcFFFA/7Ih+z2gWreDX6avhkbFU\n\tDBp4SDqryRkzhyfb68svoWyLcYQXvDmIWcK9HiaLKhPKnPtNwM+IiHC4aWvA1307GKzv\n\tr+Gu8MTImHWZjuGNFCN6knD/Yy2WAePkbcmIvoX4hfUeHmpMPILg06whYADaFrM+xRXY\n\t8NVpLLXuJKmRkmADNBOvbjSgLluQmn7Q/qUb7WU/bGux2OTnwceZqsCw5hqnymDqxNyR\n\tFc0Q==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"tvfctysQ\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=sWILBBIXlzAhPGU6fvcIkhjxcYBCw5crq4jorvb3iUU=;\n\tb=qw8aYXiOGVZEC6g+4Sk3voLa01vwDXd2grO+tiI9qeSh6z1hzW4NinBH8ah1SvHZOE\n\t0TGHLCyCtVuSZPAf3fZn6EkxtFfZNQg8cc7+r2mqBYWEncu3MBo0mwbkGkZ+d/eOWMxy\n\tP6/iB1T7hjJNpzMis0Rdb+lsi+gvqP+riKBP+Fq2ZyeTxK7M7gs1A3rbmqH6fLUNeMWB\n\tle/40t44wQEDSpp7rEAxCsmE3mmzLOklADzZAs/dQqCqebhKDSDSsKtE9vs0aa1btG2d\n\tLEReUHJE8HT5K3GZMyS+2w/aIrpZ4S840Y1VpjjlDJRKRdJSLwhRCVXGwFGvAkfbwpBr\n\tytlA==", "X-Gm-Message-State": "AFqh2kqLFE8/djXwba+X8VdZfn9gukVct69FaYCZmgRkzTZX6PexA5m9\n\tq/vR6R0NZ85N5Ks379UBzWWRYpMIZ+PAPZgMP+w=", "X-Google-Smtp-Source": "AMrXdXulM0i2nh8gD0yGuMavAinP9tEMBPvFCk/ZnsiiS8n+4eK2wolUu3sPCMIx3goY+7mVRCMgUg==", "X-Received": "by 2002:a5d:4dc9:0:b0:2be:21fc:ae3 with SMTP id\n\tf9-20020a5d4dc9000000b002be21fc0ae3mr4194808wru.11.1674032483651; \n\tWed, 18 Jan 2023 01:01:23 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 18 Jan 2023 08:59:53 +0000", "Message-Id": "<20230118085953.7027-13-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230118085953.7027-1-naush@raspberrypi.com>", "References": "<20230118085953.7027-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 12/12] pipeline: raspberrypi: Add\n\tminimal memory usage config file", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a platform configuration file that allocates the least amount of frame\nbuffer memory possible. This configuration does come with the following\ncompromises:\n\n- Startup frame drops are disabled, so the first few frames will not have\nfully converged AE/AWB/ALSC applied.\n\n- Applications must provide ISP Output0 and Unicam Image (if a RAW stream is\nconfigured) buffers in requests.\n\n- Only 1 Unicam Image buffer will be allocated if a RAW stream is not\nconfigured, causing the framerate to be effectively halved.\n\nTo use the configuration on the Raspberry Pi platform, invoke the application\nwith the following prepended to the command line:\n\nLIBCAMERA_RPI_CONFIG_FILE=/usr/local/share/libcamera/pipeline/raspberrypi/minimal_mem.yaml\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n .../pipeline/raspberrypi/data/meson.build | 1 +\n .../raspberrypi/data/minimal_mem.yaml | 29 +++++++++++++++++++\n 2 files changed, 30 insertions(+)\n create mode 100644 src/libcamera/pipeline/raspberrypi/data/minimal_mem.yaml", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/data/meson.build b/src/libcamera/pipeline/raspberrypi/data/meson.build\nindex 1c70433bbcbc..6aecd8ae68c8 100644\n--- a/src/libcamera/pipeline/raspberrypi/data/meson.build\n+++ b/src/libcamera/pipeline/raspberrypi/data/meson.build\n@@ -2,6 +2,7 @@\n \n conf_files = files([\n 'example.yaml',\n+ 'minimal_mem.yaml',\n ])\n \n install_data(conf_files,\ndiff --git a/src/libcamera/pipeline/raspberrypi/data/minimal_mem.yaml b/src/libcamera/pipeline/raspberrypi/data/minimal_mem.yaml\nnew file mode 100644\nindex 000000000000..5cd593025140\n--- /dev/null\n+++ b/src/libcamera/pipeline/raspberrypi/data/minimal_mem.yaml\n@@ -0,0 +1,29 @@\n+{\n+ \"version\": 1.0,\n+ \"target\": \"bcm2835\",\n+\n+ \"pipeline_handler\":\n+ {\n+ # The minimum number of internal buffers to be allocated for\n+ # Unicam. This value must be greater than 0, but less than or\n+ # equal to min_total_unicam_buffers.\n+ \"min_unicam_buffers\": 0,\n+\n+ # The minimum total (internal + external) buffer count used for\n+ # Unicam. The number of internal buffers allocated for Unicam is\n+ # given by:\n+ #\n+ # internal buffer count = max(min_unicam_buffers,\n+ # min_total_unicam_buffers - external buffer count)\n+ \"min_total_unicam_buffers\": 1,\n+\n+ # Override any request from the IPA to drop a number of startup\n+ # frames.\n+ \"disable_startup_frame_drops\": true,\n+\n+ # Always process a pending request with the last captured sensor\n+ # frame. Note that this might lead to avoidable frame drops\n+ # during periods of transient heavy CPU loading.\n+ \"return_newest_frames\": false\n+ }\n+}\n", "prefixes": [ "libcamera-devel", "v5", "12/12" ] }