Patch Detail
Show a patch.
GET /api/patches/18106/?format=api
{ "id": 18106, "url": "https://patchwork.libcamera.org/api/patches/18106/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18106/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230112173411.11276-1-daniel.oakley@ideasonboard.com>", "date": "2023-01-12T17:34:11", "name": "[libcamera-devel] py: cam.py: Fix duplicate metadata output if more than one steam", "commit_ref": "20e33bc0df452232378b317e46e370e25db1cc2a", "pull_url": null, "state": "accepted", "archived": false, "hash": "1ed507aea3c4c6720eac779d53a4238ffa8dfb4b", "submitter": { "id": 145, "url": "https://patchwork.libcamera.org/api/people/145/?format=api", "name": "Daniel Oakley", "email": "daniel.oakley@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18106/mbox/", "series": [ { "id": 3707, "url": "https://patchwork.libcamera.org/api/series/3707/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3707", "date": "2023-01-12T17:34:11", "name": "[libcamera-devel] py: cam.py: Fix duplicate metadata output if more than one steam", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3707/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18106/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18106/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33FB4C3292\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Jan 2023 17:39:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89B55625E4;\n\tThu, 12 Jan 2023 18:39:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D214361F04\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Jan 2023 18:34:50 +0100 (CET)", "from danielLaptop.tendawifi.com (unknown [90.242.103.36])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 061E3492;\n\tThu, 12 Jan 2023 18:34:49 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1673545184;\n\tbh=6t3gqeqQGiUWzbLgFcbAcyeqVFnoYvBhwqfB9zvgsiM=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=NrSue/2wTuCOQ53rNHpJxKsq9aWyATb8YVqwPb2jxwtZGmzwOqfbymmjfiZPoPKp6\n\tDNDSUrFZ/6M+cRt7rITvpbraXamqTZsJWEuSZo2E+Bqdd+Wqp1BSuetEbhvIlzVPJK\n\tZc6agD/NWxQJT/+vdbb9XWp187mqvvOvJ3IUpt03X2zAjnoWJklXJNm1pTc+54hBeh\n\trRMN3KXBzylUulxmJvZkSl0WT46YoIi4AR/8WKuckaDq5xq4jeonZJYZrAgssxXjLv\n\tbOfkX9hHDyrQNCcAqVIV7ggLjKxkGcIg9RBZaNcFHiKNWhKwHlC7YxLO1zO0p2OQyu\n\tr3E4Os23UV8Zw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1673544890;\n\tbh=6t3gqeqQGiUWzbLgFcbAcyeqVFnoYvBhwqfB9zvgsiM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=AJGkkNL3NdiVOkGpZsCsSabT9HhaW5Vfc8KP3srmJ5DriVhYyG7XPDZT9S2UCrKQM\n\ti+fJJB1Pmlo8sqcXW4fjtZ2mh1EPJOo8ep79Wn1Ic8H++tLyRKJ2mdFjogWn7r4Rjp\n\tSCpRvSJGnuQV/3A77891W9zxFjK/pW+vQtLTEpB8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AJGkkNL3\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 12 Jan 2023 17:34:11 +0000", "Message-Id": "<20230112173411.11276-1-daniel.oakley@ideasonboard.com>", "X-Mailer": "git-send-email 2.38.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Thu, 12 Jan 2023 18:39:43 +0100", "Subject": "[libcamera-devel] [PATCH] py: cam.py: Fix duplicate metadata output\n\tif more than one steam", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Oakley via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Oakley <daniel.oakley@ideasonboard.com>", "Cc": "Daniel Oakley <daniel.oakley@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Currently, if there are multiple steams, the --metadata flag will\nprint the metadata for each request multiple times.\n\nMoving the metadata print logic outside the steam for loop this will\nno longer occur.\n\nSigned-off-by: Daniel Oakley <daniel.oakley@ideasonboard.com>\n---\n src/py/cam/cam.py | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex 2701d937..967a72f5 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -266,6 +266,11 @@ class CaptureState:\n ctx.last = ts\n ctx.fps = fps\n \n+ if ctx.opt_metadata:\n+ reqmeta = req.metadata\n+ for ctrl, val in reqmeta.items():\n+ print(f'\\t{ctrl} = {val}')\n+\n for stream, fb in buffers.items():\n stream_name = ctx.stream_names[stream]\n \n@@ -284,11 +289,6 @@ class CaptureState:\n '/'.join([str(p.bytes_used) for p in meta.planes]),\n crcs))\n \n- if ctx.opt_metadata:\n- reqmeta = req.metadata\n- for ctrl, val in reqmeta.items():\n- print(f'\\t{ctrl} = {val}')\n-\n if ctx.opt_save_frames:\n with libcamera.utils.MappedFrameBuffer(fb) as mfb:\n filename = 'frame-{}-{}-{}.data'.format(ctx.id, stream_name, ctx.reqs_completed)\n", "prefixes": [ "libcamera-devel" ] }