Patch Detail
Show a patch.
GET /api/patches/18100/?format=api
{ "id": 18100, "url": "https://patchwork.libcamera.org/api/patches/18100/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18100/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230111232221.265057-1-javierm@redhat.com>", "date": "2023-01-11T23:22:21", "name": "[libcamera-devel] meson: Remove pipelines list duplication", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "ca8d873423cfb62a44116710e97c3c3bd5983d61", "submitter": { "id": 95, "url": "https://patchwork.libcamera.org/api/people/95/?format=api", "name": "Javier Martinez Canillas", "email": "javierm@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18100/mbox/", "series": [ { "id": 3703, "url": "https://patchwork.libcamera.org/api/series/3703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3703", "date": "2023-01-11T23:22:21", "name": "[libcamera-devel] meson: Remove pipelines list duplication", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18100/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18100/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9ED8AC3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jan 2023 23:22:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6FD7625DE;\n\tThu, 12 Jan 2023 00:22:35 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC72A61F07\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Jan 2023 00:22:33 +0100 (CET)", "from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n\t[209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id\n\tus-mta-227-qHrSWbhnN0CjUHlcP2e65A-1; Wed, 11 Jan 2023 18:22:31 -0500", "by mail-wr1-f70.google.com with SMTP id\n\tn13-20020adfc60d000000b0029bdfcf52eeso3073879wrg.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jan 2023 15:22:31 -0800 (PST)", "from minerva.home (205.pool92-176-231.dynamic.orange.es.\n\t[92.176.231.205]) by smtp.gmail.com with ESMTPSA id\n\tu5-20020adfdb85000000b002ba2646fd30sm17511459wri.36.2023.01.11.15.22.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 11 Jan 2023 15:22:29 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1673479355;\n\tbh=3me9dXsJ9OeaXuKt3E7E0UY69qrLoHK1CyqYZF46w4Q=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=fFdHSp6pYTe5mYObO/NNAxi7bJbSI6Jp/hila/zvViuzCMqTQXyy/pF8c2ql0seMb\n\trX4BPI6RCMr456b4H0sfvmWeX8ug56nzzTi2WQbRButdSrfhrd79JVy3MvlFikQb4d\n\tdy4RCKsaUb5MsjD3dpNqIeb3IX1xyRihGhR96yCcFlaIYRI7ChU0VGGGUkNeoBePrd\n\tY9ZpSj1UMQC4wD7T7Mgf+xXcbWPT4CoeF9cMRwFAtNo5iiq9TqmrdrIy7B8cVZRB3h\n\t+uOtHoSZf0WN33NEOz8Eicd5oiVGIf1RD2HF9wtyWqH2scUecFAFh17Khkc28xN36c\n\tgSj0yGK4DIpPA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1673479352;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=/0bYrOmMoo2KXDT3V2foTyD+xgqmrJPiMnVA/Z20zG8=;\n\tb=RvDo4e3L4O84qd7Eyxesi5Z1YU3dfGfjb42vJ1w8tMe8akTiAi6xmwcLvCh+UpmsBTDS+d\n\tMOe8Pu6izLcY1RyYvC6s1g/+VrxJwT1QzzBIBNBhgdCg7SvjoT9NIpaMz6nhq8wElhk1NY\n\tFzGZkXK2z62+Qqb2pFXBLIPAYhpUjPM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"RvDo4e3L\"; \n\tdkim-atps=neutral", "X-MC-Unique": "qHrSWbhnN0CjUHlcP2e65A-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=/0bYrOmMoo2KXDT3V2foTyD+xgqmrJPiMnVA/Z20zG8=;\n\tb=5XfZ9IU8Tt9kYgF6U9aYzC0HPH4/cggQKCz7kMIxpw2LO/85Ks8365mQKooFcr3Cph\n\tD8p0ifhFKPXLlB5GJ9WnSQQoGFjk0KHCWSkxnryfZSSaqF1lVpfLUlzKi1y9nnvOz8ns\n\tprUa9VUHNRKUqnJHRDljFYKynaPy6ebJkfJk/TLSKYIWR8rVm3wsXK81nfPgSmsrg011\n\t51jKYJGyzCnoCr1oeFLCAP6XyQLKJ7Ux82Ui9neLURPCduf3ySBlRk/8Q6LGx9b+6ykf\n\tlu4vctALF52uvtllbY4IpEBHgbXGsfTspLlSp5qJ5Q6zPXIwUqFrwdNupcvUtHXObja4\n\t6buA==", "X-Gm-Message-State": "AFqh2kow4eMLP5251vfMXCILn69U+r58QhCMDBJkMB7lwUoBxCnqscKR\n\tITsCURDtrCkTf3cWsyTSN6x+LpE7c/HMwPDI8igd7OwGRXokpe41SXnfD6el4NJ6eZljs9VzO99\n\tOPSTgHnTTKIwKqMnnm8TTxVfNTmA3cajPt+dJg6iqJ/R7aKyCBvlY47lzKsSuCwH7RpDBgEx0ai\n\tv7BaBLAeyB", "X-Received": [ "by 2002:a5d:620e:0:b0:242:7307:ae04 with SMTP id\n\ty14-20020a5d620e000000b002427307ae04mr41614883wru.57.1673479350176; \n\tWed, 11 Jan 2023 15:22:30 -0800 (PST)", "by 2002:a5d:620e:0:b0:242:7307:ae04 with SMTP id\n\ty14-20020a5d620e000000b002427307ae04mr41614873wru.57.1673479349862; \n\tWed, 11 Jan 2023 15:22:29 -0800 (PST)" ], "X-Google-Smtp-Source": "AMrXdXvhvGoj9CVapBpO8wK8arig+ooHxJhOB2SFCb9KYWUtxVu0CIaik8wuwp0xcz7xRtZnifrLHg==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 12 Jan 2023 00:22:21 +0100", "Message-Id": "<20230111232221.265057-1-javierm@redhat.com>", "X-Mailer": "git-send-email 2.39.0", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "Subject": "[libcamera-devel] [PATCH] meson: Remove pipelines list duplication", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Javier Martinez Canillas via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Javier Martinez Canillas <javierm@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The supported pipelines are listed in three places: the meson_options.txt\nfile, the defined array when a user selects -Dpipelines=\"all\", and arrays\ndefined when the default -Dpipelines=\"auto\" is selected.\n\nThis is hard to maintain and error prone, let's at least in the meson file\nhave a single place where these pipelines lists are defined.\n\nSigned-off-by: Javier Martinez Canillas <javierm@redhat.com>\n---\n\n meson.build | 31 +++++++++++++++++--------------\n 1 file changed, 17 insertions(+), 14 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 389c547206fb..f9e3280ec0f2 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -168,38 +168,41 @@ liblttng = dependency('lttng-ust', required : get_option('tracing'))\n # are enabled.\n pipelines = get_option('pipelines')\n \n+pipelines_aarch64 = ['imx8-isi', 'rkisp1']\n+pipelines_arm = ['raspberrypi', 'simple']\n+pipelines_agnostic = ['uvcvideo']\n+pipelines_test = ['vimc']\n+pipelines_x86 = ['ipu3']\n+\n if pipelines.contains('all')\n- pipelines = [\n- 'imx8-isi',\n- 'ipu3',\n- 'raspberrypi',\n- 'rkisp1',\n- 'simple',\n- 'uvcvideo',\n- 'vimc',\n- ]\n+ pipelines = []\n+ pipelines += pipelines_aarch64\n+ pipelines += pipelines_arm\n+ pipelines += pipelines_agnostic\n+ pipelines += pipelines_test\n+ pipelines += pipelines_x86\n endif\n \n if pipelines.contains('auto')\n host_cpu = host_machine.cpu_family()\n pipelines = []\n if host_cpu == 'x86' or host_cpu == 'x86_64'\n- pipelines += ['ipu3']\n+ pipelines += pipelines_x86\n elif host_cpu == 'aarch64'\n- pipelines += ['imx8-isi', 'rkisp1']\n+ pipelines += pipelines_aarch64\n endif\n \n if host_cpu == 'arm' or host_cpu == 'aarch64'\n- pipelines += ['raspberrypi', 'simple']\n+ pipelines += pipeines_arm\n endif\n \n # Always include the uvcvideo pipeline handler.\n- pipelines += ['uvcvideo']\n+ pipelines += pipelines_agnostic\n endif\n \n if get_option('test') and 'vimc' not in pipelines\n message('Enabling vimc pipeline handler to support tests')\n- pipelines += ['vimc']\n+ pipelines += pipelines_test\n endif\n \n # Utilities are parsed first to provide support for other components.\n", "prefixes": [ "libcamera-devel" ] }